All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@kernel.org>
Cc: hch@lst.de, linux-nvme@lists.infradead.org, sagi@grimberg.me
Subject: Re: [PATCH] nvme/pci: Remove last_cq_head
Date: Tue, 3 Dec 2019 08:36:55 +0100	[thread overview]
Message-ID: <20191203073655.GA23881@lst.de> (raw)
In-Reply-To: <20191202221829.1940-1-kbusch@kernel.org>

On Tue, Dec 03, 2019 at 07:18:29AM +0900, Keith Busch wrote:
> We had been saving the last_cq_head seen from an interrupt so that a
> polled queue wouldn't mistakenly trigger spruious interrupt detection. We
> don't poll interrupt driven queues any more, so saving this value is
> pointless.

Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>

Btw, didn't you also have some other patches to shrink the size of
struct nvme_queue from a few months ago?

_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

  reply	other threads:[~2019-12-03  7:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-02 22:18 [PATCH] nvme/pci: Remove last_cq_head Keith Busch
2019-12-03  7:36 ` Christoph Hellwig [this message]
2019-12-03 15:41   ` Keith Busch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191203073655.GA23881@lst.de \
    --to=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.