From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B720BC432C3 for ; Tue, 3 Dec 2019 08:34:12 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8D0E92068E for ; Tue, 3 Dec 2019 08:34:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="mhKNpXQ/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8D0E92068E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/CQxcGt5EriFHll+5XDYGDa7zxs5BEDWiLOlDYlgjiM=; b=mhKNpXQ/MboOfA b9OKht3/B12F6QNQ1oteMmMB6Xy1Wl6rm1dMb1s82wzhUR8jVYj8nmlPB1N48nL4aJUxvIKecVzXt z9bZHZKEqAzmKZs1mUz58mvXHZuDvzU47auUhP+tnqC/LOsscpttgSd8yK2NcJNDwwVZb26MRHTlV qw69iO/ej2dWAdgShPmoJ00gN//lZj9UXPwmReLkd+iE/WOKsnk/amUMuMR+1TJPDx6l6EHJZ7geP HZGK6bbMB5Ptv+zse6JRHaafSX6LP+8yjNL2WvJgBgaN1QJHd/eEILjtVYudx7NdgTVjVe1UB3MXy eswcG1ocNJkGzCi5hh2Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ic3dL-0001Yg-J5; Tue, 03 Dec 2019 08:34:11 +0000 Received: from asavdk4.altibox.net ([109.247.116.15]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ic3dB-0001Pd-P2; Tue, 03 Dec 2019 08:34:03 +0000 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id 33C3D80478; Tue, 3 Dec 2019 09:33:53 +0100 (CET) Date: Tue, 3 Dec 2019 09:33:51 +0100 From: Sam Ravnborg To: Laurent Pinchart Subject: Re: [PATCH v1 0/26] drm/panel infrastructure + backlight update Message-ID: <20191203083351.GA30687@ravnborg.org> References: <20191202193230.21310-1-sam@ravnborg.org> <20191203072443.GK4730@pendragon.ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191203072443.GK4730@pendragon.ideasonboard.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=VcLZwmh9 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=9hfdOVt4OdhUXmoMrC4A:9 a=CjuIK1q_8ugA:10 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191203_003402_002076_FBC1B70D X-CRM114-Status: GOOD ( 22.99 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , David Airlie , Linus Walleij , dri-devel@lists.freedesktop.org, Andrzej Hajda , Thierry Reding , Benjamin Gaignard , Stefan Agner , linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, Tomi Valkeinen , NXP Linux Team , Jagan Teki , Jitao Shi , Pengutronix Kernel Team , Maarten Lankhorst , Maxime Ripard , linux-mediatek@lists.infradead.org, Abhinav Kumar , linux-tegra@vger.kernel.org, Sean Paul , linux-arm-kernel@lists.infradead.org, Purism Kernel Team , linux-renesas-soc@vger.kernel.org, Boris Brezillon , Daniel Vetter Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi Laurent. > > This patchset include a couple of different > > things - all related to panels. > > > > - The panel callbacks are optional - so drop error if > > callback is not present. > > > > - Add support for backlight in drm_panel. > > This allows us to make much simpler backlight > > support to most panels. > > The patchset include conversion of most of the > > trivial cases. > > > > - Drop drm_connector from drm_panel. > > This change required many changes to most > > panels and many bridges and display drivers. > > This is by far the most invasive change in this patchset. > > > > - Drop the unused get_timings() callback. > > No users, so no need to keep it around. > > > > With this patchset drm_panel_(attach|detach) are nop's > > but they are kept for now. > > > > A few of these patches has been sent out before - but versioning > > started again from v1 - as the most patches are new. > > > > I have tested the panel-simple changes, and thus some > > of the infrastructure changes. > > The testing was done on an earlier iteration - and I ended > > up submitting this as Laurent and others started to depend on it. > > Jitao has a patch to add more callbacks, and I wanted the > > simplification of the callbacks before we add more callbacks. > > Great series !!! Thanks for working on this. And likewise - thanks for the detailed reviews! I have a patch to remove drm_panel_(attach|detach), but they was not included because there is also a patchset floating that add more functionality to these. I will address the feedback, it looked all straighforward, and post an updated series. > drm/panel: remove get_timings I will drop this patch as we may need this later. Sam _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Subject: Re: [PATCH v1 0/26] drm/panel infrastructure + backlight update Date: Tue, 3 Dec 2019 09:33:51 +0100 Message-ID: <20191203083351.GA30687@ravnborg.org> References: <20191202193230.21310-1-sam@ravnborg.org> <20191203072443.GK4730@pendragon.ideasonboard.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20191203072443.GK4730@pendragon.ideasonboard.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Laurent Pinchart Cc: Neil Armstrong , David Airlie , dri-devel@lists.freedesktop.org, Thierry Reding , linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, Tomi Valkeinen , NXP Linux Team , Jagan Teki , Jitao Shi , Pengutronix Kernel Team , linux-mediatek@lists.infradead.org, Abhinav Kumar , linux-tegra@vger.kernel.org, Sean Paul , linux-arm-kernel@lists.infradead.org, Purism Kernel Team , linux-renesas-soc@vger.kernel.org, Boris Brezillon List-Id: linux-rockchip.vger.kernel.org SGkgTGF1cmVudC4KCj4gPiBUaGlzIHBhdGNoc2V0IGluY2x1ZGUgYSBjb3VwbGUgb2YgZGlmZmVy ZW50Cj4gPiB0aGluZ3MgLSBhbGwgcmVsYXRlZCB0byBwYW5lbHMuCj4gPiAKPiA+IC0gVGhlIHBh bmVsIGNhbGxiYWNrcyBhcmUgb3B0aW9uYWwgLSBzbyBkcm9wIGVycm9yIGlmCj4gPiAgIGNhbGxi YWNrIGlzIG5vdCBwcmVzZW50Lgo+ID4gIAo+ID4gLSBBZGQgc3VwcG9ydCBmb3IgYmFja2xpZ2h0 IGluIGRybV9wYW5lbC4KPiA+ICAgVGhpcyBhbGxvd3MgdXMgdG8gbWFrZSBtdWNoIHNpbXBsZXIg YmFja2xpZ2h0Cj4gPiAgIHN1cHBvcnQgdG8gbW9zdCBwYW5lbHMuCj4gPiAgIFRoZSBwYXRjaHNl dCBpbmNsdWRlIGNvbnZlcnNpb24gb2YgbW9zdCBvZiB0aGUKPiA+ICAgdHJpdmlhbCBjYXNlcy4K PiA+IAo+ID4gLSBEcm9wIGRybV9jb25uZWN0b3IgZnJvbSBkcm1fcGFuZWwuCj4gPiAgIFRoaXMg Y2hhbmdlIHJlcXVpcmVkIG1hbnkgY2hhbmdlcyB0byBtb3N0Cj4gPiAgIHBhbmVscyBhbmQgbWFu eSBicmlkZ2VzIGFuZCBkaXNwbGF5IGRyaXZlcnMuCj4gPiAgIFRoaXMgaXMgYnkgZmFyIHRoZSBt b3N0IGludmFzaXZlIGNoYW5nZSBpbiB0aGlzIHBhdGNoc2V0Lgo+ID4gCj4gPiAtIERyb3AgdGhl IHVudXNlZCBnZXRfdGltaW5ncygpIGNhbGxiYWNrLgo+ID4gICBObyB1c2Vycywgc28gbm8gbmVl ZCB0byBrZWVwIGl0IGFyb3VuZC4KPiA+IAo+ID4gV2l0aCB0aGlzIHBhdGNoc2V0IGRybV9wYW5l bF8oYXR0YWNofGRldGFjaCkgYXJlIG5vcCdzCj4gPiBidXQgdGhleSBhcmUga2VwdCBmb3Igbm93 Lgo+ID4gCj4gPiBBIGZldyBvZiB0aGVzZSBwYXRjaGVzIGhhcyBiZWVuIHNlbnQgb3V0IGJlZm9y ZSAtIGJ1dCB2ZXJzaW9uaW5nCj4gPiBzdGFydGVkIGFnYWluIGZyb20gdjEgLSBhcyB0aGUgbW9z dCBwYXRjaGVzIGFyZSBuZXcuCj4gPiAKPiA+IEkgaGF2ZSB0ZXN0ZWQgdGhlIHBhbmVsLXNpbXBs ZSBjaGFuZ2VzLCBhbmQgdGh1cyBzb21lCj4gPiBvZiB0aGUgaW5mcmFzdHJ1Y3R1cmUgY2hhbmdl cy4KPiA+IFRoZSB0ZXN0aW5nIHdhcyBkb25lIG9uIGFuIGVhcmxpZXIgaXRlcmF0aW9uIC0gYW5k IEkgZW5kZWQKPiA+IHVwIHN1Ym1pdHRpbmcgdGhpcyBhcyBMYXVyZW50IGFuZCBvdGhlcnMgc3Rh cnRlZCB0byBkZXBlbmQgb24gaXQuCj4gPiBKaXRhbyBoYXMgYSBwYXRjaCB0byBhZGQgbW9yZSBj YWxsYmFja3MsIGFuZCBJIHdhbnRlZCB0aGUKPiA+IHNpbXBsaWZpY2F0aW9uIG9mIHRoZSBjYWxs YmFja3MgYmVmb3JlIHdlIGFkZCBtb3JlIGNhbGxiYWNrcy4KPiAKPiBHcmVhdCBzZXJpZXMgISEh IFRoYW5rcyBmb3Igd29ya2luZyBvbiB0aGlzLgpBbmQgbGlrZXdpc2UgLSB0aGFua3MgZm9yIHRo ZSBkZXRhaWxlZCByZXZpZXdzIQoKSSBoYXZlIGEgcGF0Y2ggdG8gcmVtb3ZlIGRybV9wYW5lbF8o YXR0YWNofGRldGFjaCksCmJ1dCB0aGV5IHdhcyBub3QgaW5jbHVkZWQgYmVjYXVzZSB0aGVyZSBp cyBhbHNvIGEgcGF0Y2hzZXQgZmxvYXRpbmcKdGhhdCBhZGQgbW9yZSBmdW5jdGlvbmFsaXR5IHRv IHRoZXNlLgoKSSB3aWxsIGFkZHJlc3MgdGhlIGZlZWRiYWNrLCBpdCBsb29rZWQgYWxsIHN0cmFp Z2hmb3J3YXJkLCBhbmQgcG9zdAphbiB1cGRhdGVkIHNlcmllcy4KCj4gZHJtL3BhbmVsOiByZW1v dmUgZ2V0X3RpbWluZ3MKSSB3aWxsIGRyb3AgdGhpcyBwYXRjaCBhcyB3ZSBtYXkgbmVlZCB0aGlz IGxhdGVyLgoKCVNhbQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2 ZWw= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F3BBC432C0 for ; Tue, 3 Dec 2019 08:34:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DF3BE2068E for ; Tue, 3 Dec 2019 08:34:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726105AbfLCIeB (ORCPT ); Tue, 3 Dec 2019 03:34:01 -0500 Received: from asavdk4.altibox.net ([109.247.116.15]:35460 "EHLO asavdk4.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725773AbfLCIeB (ORCPT ); Tue, 3 Dec 2019 03:34:01 -0500 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id 33C3D80478; Tue, 3 Dec 2019 09:33:53 +0100 (CET) Date: Tue, 3 Dec 2019 09:33:51 +0100 From: Sam Ravnborg To: Laurent Pinchart Cc: dri-devel@lists.freedesktop.org, Thierry Reding , Abhinav Kumar , Andrzej Hajda , Benjamin Gaignard , Boris Brezillon , Daniel Vetter , David Airlie , Jagan Teki , Jitao Shi , Linus Walleij , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-tegra@vger.kernel.org, Maarten Lankhorst , Maxime Ripard , Neil Armstrong , NXP Linux Team , Pengutronix Kernel Team , Purism Kernel Team , Sean Paul , Stefan Agner , Tomi Valkeinen Subject: Re: [PATCH v1 0/26] drm/panel infrastructure + backlight update Message-ID: <20191203083351.GA30687@ravnborg.org> References: <20191202193230.21310-1-sam@ravnborg.org> <20191203072443.GK4730@pendragon.ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191203072443.GK4730@pendragon.ideasonboard.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=VcLZwmh9 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=9hfdOVt4OdhUXmoMrC4A:9 a=CjuIK1q_8ugA:10 Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org Hi Laurent. > > This patchset include a couple of different > > things - all related to panels. > > > > - The panel callbacks are optional - so drop error if > > callback is not present. > > > > - Add support for backlight in drm_panel. > > This allows us to make much simpler backlight > > support to most panels. > > The patchset include conversion of most of the > > trivial cases. > > > > - Drop drm_connector from drm_panel. > > This change required many changes to most > > panels and many bridges and display drivers. > > This is by far the most invasive change in this patchset. > > > > - Drop the unused get_timings() callback. > > No users, so no need to keep it around. > > > > With this patchset drm_panel_(attach|detach) are nop's > > but they are kept for now. > > > > A few of these patches has been sent out before - but versioning > > started again from v1 - as the most patches are new. > > > > I have tested the panel-simple changes, and thus some > > of the infrastructure changes. > > The testing was done on an earlier iteration - and I ended > > up submitting this as Laurent and others started to depend on it. > > Jitao has a patch to add more callbacks, and I wanted the > > simplification of the callbacks before we add more callbacks. > > Great series !!! Thanks for working on this. And likewise - thanks for the detailed reviews! I have a patch to remove drm_panel_(attach|detach), but they was not included because there is also a patchset floating that add more functionality to these. I will address the feedback, it looked all straighforward, and post an updated series. > drm/panel: remove get_timings I will drop this patch as we may need this later. Sam From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25F74C432C0 for ; Tue, 3 Dec 2019 08:34:08 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EEBB5206DF for ; Tue, 3 Dec 2019 08:34:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="mMd5Ei+p" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EEBB5206DF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AcZo2hHU4XC4pfo9TK6cNSJw2PIQC4tXtHymI3L1YS0=; b=mMd5Ei+pwagVrh lDHHauoq/am3VjGMkG2lGRLr67PmBulEgqr8YY5ssEq9Zezb4nhC9USyl3h3/n3V2xnkiPh5RenuT buGGE0c7T6LKu581moK6KAdN3nBI0osITr/09VnQITVPINOYCKiubwGri/vpmXzSr45h0nnk6W4lK VnhnLmWRm/WZ7vOJ51og5buA/upeIvwMhERTVjFk0rlKjljK8Lngmip9/m6CctpxaAQPO/AypZloz BVG2enFCRnfR9w39Bnf9V5UyuR7iayKkFkY1+JRm3nsmqU10DXZ3JFOe/BTd3ILGxGM8khQn3/+nW NJhobl8ePv4XLEmZoMZQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ic3dF-0001QC-2z; Tue, 03 Dec 2019 08:34:05 +0000 Received: from asavdk4.altibox.net ([109.247.116.15]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ic3dB-0001Pd-P2; Tue, 03 Dec 2019 08:34:03 +0000 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id 33C3D80478; Tue, 3 Dec 2019 09:33:53 +0100 (CET) Date: Tue, 3 Dec 2019 09:33:51 +0100 From: Sam Ravnborg To: Laurent Pinchart Subject: Re: [PATCH v1 0/26] drm/panel infrastructure + backlight update Message-ID: <20191203083351.GA30687@ravnborg.org> References: <20191202193230.21310-1-sam@ravnborg.org> <20191203072443.GK4730@pendragon.ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191203072443.GK4730@pendragon.ideasonboard.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=VcLZwmh9 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=9hfdOVt4OdhUXmoMrC4A:9 a=CjuIK1q_8ugA:10 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191203_003402_002076_FBC1B70D X-CRM114-Status: GOOD ( 22.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , David Airlie , Linus Walleij , dri-devel@lists.freedesktop.org, Andrzej Hajda , Thierry Reding , Benjamin Gaignard , Stefan Agner , linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, Tomi Valkeinen , NXP Linux Team , Jagan Teki , Jitao Shi , Pengutronix Kernel Team , Maarten Lankhorst , Maxime Ripard , linux-mediatek@lists.infradead.org, Abhinav Kumar , linux-tegra@vger.kernel.org, Sean Paul , linux-arm-kernel@lists.infradead.org, Purism Kernel Team , linux-renesas-soc@vger.kernel.org, Boris Brezillon , Daniel Vetter Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Laurent. > > This patchset include a couple of different > > things - all related to panels. > > > > - The panel callbacks are optional - so drop error if > > callback is not present. > > > > - Add support for backlight in drm_panel. > > This allows us to make much simpler backlight > > support to most panels. > > The patchset include conversion of most of the > > trivial cases. > > > > - Drop drm_connector from drm_panel. > > This change required many changes to most > > panels and many bridges and display drivers. > > This is by far the most invasive change in this patchset. > > > > - Drop the unused get_timings() callback. > > No users, so no need to keep it around. > > > > With this patchset drm_panel_(attach|detach) are nop's > > but they are kept for now. > > > > A few of these patches has been sent out before - but versioning > > started again from v1 - as the most patches are new. > > > > I have tested the panel-simple changes, and thus some > > of the infrastructure changes. > > The testing was done on an earlier iteration - and I ended > > up submitting this as Laurent and others started to depend on it. > > Jitao has a patch to add more callbacks, and I wanted the > > simplification of the callbacks before we add more callbacks. > > Great series !!! Thanks for working on this. And likewise - thanks for the detailed reviews! I have a patch to remove drm_panel_(attach|detach), but they was not included because there is also a patchset floating that add more functionality to these. I will address the feedback, it looked all straighforward, and post an updated series. > drm/panel: remove get_timings I will drop this patch as we may need this later. Sam _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel