From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============5340704591660377719==" MIME-Version: 1.0 From: Michael S. Tsirkin To: kbuild-all@lists.01.org Subject: Re: [PATCH RFC v7 net-next] netdev: pass the stuck queue to the timeout handler Date: Tue, 03 Dec 2019 14:45:09 -0500 Message-ID: <20191203144459-mutt-send-email-mst@kernel.org> In-Reply-To: List-Id: --===============5340704591660377719== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Tue, Dec 03, 2019 at 10:37:48AM -0800, Nick Desaulniers wrote: > Hi Michael, > Below is a report from 0day from a build w/ Clang, can you please take > a look? Looks like the signedness of the final parameter of the > callback should be changed? Yep, fixing it up, thanks! > On Tue, Dec 3, 2019 at 9:46 AM kbuild test robot wrote: > > > > CC: kbuild-all(a)lists.01.org > > In-Reply-To: <20191203071101.427592-1-mst@redhat.com> > > References: <20191203071101.427592-1-mst@redhat.com> > > TO: "Michael S. Tsirkin" > > > > Hi "Michael, > > > > [FYI, it's a private test report for your RFC patch.] > > [auto build test ERROR on v5.4-rc8] > > [also build test ERROR on v5.4 v5.4-rc7] > > [cannot apply to net-next/master jkirsher-next-queue/dev-queue net/mast= er next-20191202 next-20191203] > > [if your patch is applied to the wrong git tree, please drop us a note = to help > > improve the system. BTW, we also suggest to use '--base' option to spec= ify the > > base tree in git format-patch, please see https://stackoverflow.com/a/3= 7406982] > > > > url: https://github.com/0day-ci/linux/commits/Michael-S-Tsirkin/netd= ev-pass-the-stuck-queue-to-the-timeout-handler/20191203-152315 > > base: af42d3466bdc8f39806b26f593604fdc54140bcb > > config: x86_64-rhel-7.6 (attached as .config) > > compiler: clang version 10.0.0 (git://gitmirror/llvm_project 7999cd41d1= 6d841d66c9c91b56bddaf209c54955) > > reproduce: > > # save the attached .config to linux build tree > > make ARCH=3Dx86_64 > > > > If you fix the issue, kindly add following tag > > Reported-by: kbuild test robot > > > > All errors (new ones prefixed by >>): > > > > >> drivers/net/ethernet/sfc/efx.c:2467:21: error: incompatible pointer = types initializing 'void (*)(struct net_device *, unsigned int)' with an ex= pression of type 'void (struct net_device *, int)' [-Werror,-Wincompatible-= pointer-types] > > .ndo_tx_timeout =3D efx_watchdog, > > ^~~~~~~~~~~~ > > 1 error generated. > > -- > > >> drivers/net/ethernet/sfc/falcon/efx.c:2219:21: error: incompatible p= ointer types initializing 'void (*)(struct net_device *, unsigned int)' wit= h an expression of type 'void (struct net_device *, int)' [-Werror,-Wincomp= atible-pointer-types] > > .ndo_tx_timeout =3D ef4_watchdog, > > ^~~~~~~~~~~~ > > 1 error generated. > > > > vim +2467 drivers/net/ethernet/sfc/efx.c > > > > e5fbd977641c92 drivers/net/ethernet/sfc/efx.c Jon Cooper 2017-02= -08 2462 > > 7fa8d547049aae drivers/net/ethernet/sfc/efx.c Shradha Shah 2015-05= -06 2463 static const struct net_device_ops efx_netdev_ops =3D { > > c3ecb9f3235ce6 drivers/net/sfc/efx.c Stephen Hemminger 2008-11= -21 2464 .ndo_open =3D efx_net_open, > > c3ecb9f3235ce6 drivers/net/sfc/efx.c Stephen Hemminger 2008-11= -21 2465 .ndo_stop =3D efx_net_stop, > > 4472702e657580 drivers/net/sfc/efx.c Ben Hutchings 2010-06= -08 2466 .ndo_get_stats64 =3D efx_net_stats, > > c3ecb9f3235ce6 drivers/net/sfc/efx.c Stephen Hemminger 2008-11= -21 @2467 .ndo_tx_timeout =3D efx_watchdog, > > c3ecb9f3235ce6 drivers/net/sfc/efx.c Stephen Hemminger 2008-11= -21 2468 .ndo_start_xmit =3D efx_hard_start_xmit, > > c3ecb9f3235ce6 drivers/net/sfc/efx.c Stephen Hemminger 2008-11= -21 2469 .ndo_validate_addr =3D eth_validate_addr, > > c3ecb9f3235ce6 drivers/net/sfc/efx.c Stephen Hemminger 2008-11= -21 2470 .ndo_do_ioctl =3D efx_ioctl, > > c3ecb9f3235ce6 drivers/net/sfc/efx.c Stephen Hemminger 2008-11= -21 2471 .ndo_change_mtu =3D efx_change_mtu, > > c3ecb9f3235ce6 drivers/net/sfc/efx.c Stephen Hemminger 2008-11= -21 2472 .ndo_set_mac_address =3D efx_set_mac_address, > > 0fca8c97612f90 drivers/net/ethernet/sfc/efx.c Ben Hutchings 2012-01= -09 2473 .ndo_set_rx_mode =3D efx_set_rx_mode, > > abfe903980161b drivers/net/sfc/efx.c Ben Hutchings 2011-04= -05 2474 .ndo_set_features =3D efx_set_features, > > 4a53ea8a74248a drivers/net/ethernet/sfc/efx.c Andrew Rybchenko 2016-06= -15 2475 .ndo_vlan_rx_add_vid =3D efx_vlan_rx_add_vid, > > 4a53ea8a74248a drivers/net/ethernet/sfc/efx.c Andrew Rybchenko 2016-06= -15 2476 .ndo_vlan_rx_kill_vid =3D efx_vlan_rx_kill_vid, > > cd2d5b529cdb9b drivers/net/ethernet/sfc/efx.c Ben Hutchings 2012-02= -14 2477 #ifdef CONFIG_SFC_SRIOV > > 7fa8d547049aae drivers/net/ethernet/sfc/efx.c Shradha Shah 2015-05= -06 2478 .ndo_set_vf_mac =3D efx_sriov_set_vf_mac, > > 7fa8d547049aae drivers/net/ethernet/sfc/efx.c Shradha Shah 2015-05= -06 2479 .ndo_set_vf_vlan =3D efx_sriov_set_vf_vlan, > > 7fa8d547049aae drivers/net/ethernet/sfc/efx.c Shradha Shah 2015-05= -06 2480 .ndo_set_vf_spoofchk =3D efx_sriov_set_vf_spoofchk, > > 7fa8d547049aae drivers/net/ethernet/sfc/efx.c Shradha Shah 2015-05= -06 2481 .ndo_get_vf_config =3D efx_sriov_get_vf_config, > > 4392dc6900618c drivers/net/ethernet/sfc/efx.c Edward Cree 2015-05= -20 2482 .ndo_set_vf_link_state =3D efx_sriov_set_vf_link_state, > > cd2d5b529cdb9b drivers/net/ethernet/sfc/efx.c Ben Hutchings 2012-02= -14 2483 #endif > > 08a7b29be9734a drivers/net/ethernet/sfc/efx.c Bert Kenward 2017-01= -10 2484 .ndo_get_phys_port_id =3D efx_get_phys_port_id, > > ac019f08953278 drivers/net/ethernet/sfc/efx.c Bert Kenward 2017-01= -10 2485 .ndo_get_phys_port_name =3D efx_get_phys_port_name, > > 94b274bf5fba6c drivers/net/sfc/efx.c Ben Hutchings 2011-01= -10 2486 .ndo_setup_tc =3D efx_setup_tc, > > 64d8ad6d745bbb drivers/net/sfc/efx.c Ben Hutchings 2011-01= -05 2487 #ifdef CONFIG_RFS_ACCEL > > 64d8ad6d745bbb drivers/net/sfc/efx.c Ben Hutchings 2011-01= -05 2488 .ndo_rx_flow_steer =3D efx_filter_rfs, > > 64d8ad6d745bbb drivers/net/sfc/efx.c Ben Hutchings 2011-01= -05 2489 #endif > > e5fbd977641c92 drivers/net/ethernet/sfc/efx.c Jon Cooper 2017-02= -08 2490 .ndo_udp_tunnel_add =3D efx_udp_tunnel_add, > > e5fbd977641c92 drivers/net/ethernet/sfc/efx.c Jon Cooper 2017-02= -08 2491 .ndo_udp_tunnel_del =3D efx_udp_tunnel_del, > > c3ecb9f3235ce6 drivers/net/sfc/efx.c Stephen Hemminger 2008-11= -21 2492 }; > > c3ecb9f3235ce6 drivers/net/sfc/efx.c Stephen Hemminger 2008-11= -21 2493 > > > > :::::: The code at line 2467 was first introduced by commit > > :::::: c3ecb9f3235ce6e39249690cdd24d678894c2c72 sfc: convert to net_dev= ice_ops > > > > :::::: TO: Stephen Hemminger > > :::::: CC: David S. Miller > > > > --- > > 0-DAY kernel test infrastructure Open Source Technology= Center > > https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org Intel Co= rporation > = > = > = > -- = > Thanks, > ~Nick Desaulniers --===============5340704591660377719==--