From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CE65C432C0 for ; Tue, 3 Dec 2019 18:02:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D13A0206DF for ; Tue, 3 Dec 2019 18:02:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="eIscy6XJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726452AbfLCSCe (ORCPT ); Tue, 3 Dec 2019 13:02:34 -0500 Received: from perceval.ideasonboard.com ([213.167.242.64]:39294 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726057AbfLCSCe (ORCPT ); Tue, 3 Dec 2019 13:02:34 -0500 Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 03B3E309; Tue, 3 Dec 2019 19:02:30 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1575396151; bh=m36J6IT7250D3XBj/8ZSZZRsiNcc0jchQ6du9m7Wnbk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eIscy6XJQ+KROvAxHpEQAp6dfxLbPL6Wd0AWK6S+YTU/VG0XvumtLxzstNedE6GwB zs6pxR1dT6tSMVWFf4fXRWeseaLgyohDjjIU9CCofa9ynCDmlEp+DwSJMyttho5HBS rlX0N3pDlSxggOulzXHuJo3kzWzDGRvsmvDmYlwI= Date: Tue, 3 Dec 2019 20:02:23 +0200 From: Laurent Pinchart To: Boris Brezillon Cc: dri-devel@lists.freedesktop.org, Lucas Stach , Chris Healy , Andrey Smirnov , Nikita Yushchenko , kernel@collabora.com, Daniel Vetter , Inki Dae , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Thierry Reding , Sam Ravnborg , Philipp Zabel , Rob Clark , Andrzej Hajda , Neil Armstrong , Jonas Karlman , Jernej Skrabec , Rob Herring , Mark Rutland , devicetree@vger.kernel.org, Eric Anholt Subject: Re: [PATCH v4 07/11] drm/bridge: Clarify the atomic enable/disable hooks semantics Message-ID: <20191203180223.GS4730@pendragon.ideasonboard.com> References: <20191203141515.3597631-1-boris.brezillon@collabora.com> <20191203141515.3597631-8-boris.brezillon@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20191203141515.3597631-8-boris.brezillon@collabora.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Boris, Thanks for the patch. On Tue, Dec 03, 2019 at 03:15:11PM +0100, Boris Brezillon wrote: > The [pre_]enable/[post_]disable hooks are passed the old atomic state. > Update the doc and rename the arguments to make it clear. > > Signed-off-by: Boris Brezillon > Reviewed-by: Laurent Pinchart > Reviewed-by: Neil Armstrong > --- > Changes in v4: > * Drop the doc update (Laurent) I was referring to the doc updates in drm_bridge.h only. Is there a reason you dropped the changes from drm_bridge.c ? I think those were good. > * Add Rbs > > Changes in v3: > * New patch > --- > include/drm/drm_bridge.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/include/drm/drm_bridge.h b/include/drm/drm_bridge.h > index bfb0385163f1..d7d714023050 100644 > --- a/include/drm/drm_bridge.h > +++ b/include/drm/drm_bridge.h > @@ -263,7 +263,7 @@ struct drm_bridge_funcs { > * The @atomic_pre_enable callback is optional. > */ > void (*atomic_pre_enable)(struct drm_bridge *bridge, > - struct drm_atomic_state *state); > + struct drm_atomic_state *old_state); > > /** > * @atomic_enable: > @@ -288,7 +288,7 @@ struct drm_bridge_funcs { > * The @atomic_enable callback is optional. > */ > void (*atomic_enable)(struct drm_bridge *bridge, > - struct drm_atomic_state *state); > + struct drm_atomic_state *old_state); > /** > * @atomic_disable: > * > @@ -311,7 +311,7 @@ struct drm_bridge_funcs { > * The @atomic_disable callback is optional. > */ > void (*atomic_disable)(struct drm_bridge *bridge, > - struct drm_atomic_state *state); > + struct drm_atomic_state *old_state); > > /** > * @atomic_post_disable: > @@ -337,7 +337,7 @@ struct drm_bridge_funcs { > * The @atomic_post_disable callback is optional. > */ > void (*atomic_post_disable)(struct drm_bridge *bridge, > - struct drm_atomic_state *state); > + struct drm_atomic_state *old_state); > }; > > /** -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 577C3C432C3 for ; Tue, 3 Dec 2019 18:02:35 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2FA992073B for ; Tue, 3 Dec 2019 18:02:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2FA992073B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AAA526E86C; Tue, 3 Dec 2019 18:02:34 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id B3BFF898BC for ; Tue, 3 Dec 2019 18:02:33 +0000 (UTC) Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 03B3E309; Tue, 3 Dec 2019 19:02:30 +0100 (CET) Date: Tue, 3 Dec 2019 20:02:23 +0200 From: Laurent Pinchart To: Boris Brezillon Subject: Re: [PATCH v4 07/11] drm/bridge: Clarify the atomic enable/disable hooks semantics Message-ID: <20191203180223.GS4730@pendragon.ideasonboard.com> References: <20191203141515.3597631-1-boris.brezillon@collabora.com> <20191203141515.3597631-8-boris.brezillon@collabora.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191203141515.3597631-8-boris.brezillon@collabora.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1575396151; bh=m36J6IT7250D3XBj/8ZSZZRsiNcc0jchQ6du9m7Wnbk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eIscy6XJQ+KROvAxHpEQAp6dfxLbPL6Wd0AWK6S+YTU/VG0XvumtLxzstNedE6GwB zs6pxR1dT6tSMVWFf4fXRWeseaLgyohDjjIU9CCofa9ynCDmlEp+DwSJMyttho5HBS rlX0N3pDlSxggOulzXHuJo3kzWzDGRvsmvDmYlwI= X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Neil Armstrong , dri-devel@lists.freedesktop.org, Thierry Reding , kernel@collabora.com, Sam Ravnborg , Nikita Yushchenko , Andrey Smirnov , Kyungmin Park , Chris Healy , devicetree@vger.kernel.org, Jonas Karlman , Rob Herring , Jernej Skrabec , Seung-Woo Kim Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" SGkgQm9yaXMsCgpUaGFua3MgZm9yIHRoZSBwYXRjaC4KCk9uIFR1ZSwgRGVjIDAzLCAyMDE5IGF0 IDAzOjE1OjExUE0gKzAxMDAsIEJvcmlzIEJyZXppbGxvbiB3cm90ZToKPiBUaGUgW3ByZV9dZW5h YmxlL1twb3N0X11kaXNhYmxlIGhvb2tzIGFyZSBwYXNzZWQgdGhlIG9sZCBhdG9taWMgc3RhdGUu Cj4gVXBkYXRlIHRoZSBkb2MgYW5kIHJlbmFtZSB0aGUgYXJndW1lbnRzIHRvIG1ha2UgaXQgY2xl YXIuCj4gCj4gU2lnbmVkLW9mZi1ieTogQm9yaXMgQnJlemlsbG9uIDxib3Jpcy5icmV6aWxsb25A Y29sbGFib3JhLmNvbT4KPiBSZXZpZXdlZC1ieTogTGF1cmVudCBQaW5jaGFydCA8bGF1cmVudC5w aW5jaGFydEBpZGVhc29uYm9hcmQuY29tPgo+IFJldmlld2VkLWJ5OiBOZWlsIEFybXN0cm9uZyA8 bmFybXN0cm9uZ0BiYXlsaWJyZS5jb20+Cj4gLS0tCj4gQ2hhbmdlcyBpbiB2NDoKPiAqIERyb3Ag dGhlIGRvYyB1cGRhdGUgKExhdXJlbnQpCgpJIHdhcyByZWZlcnJpbmcgdG8gdGhlIGRvYyB1cGRh dGVzIGluIGRybV9icmlkZ2UuaCBvbmx5LiBJcyB0aGVyZSBhCnJlYXNvbiB5b3UgZHJvcHBlZCB0 aGUgY2hhbmdlcyBmcm9tIGRybV9icmlkZ2UuYyA/IEkgdGhpbmsgdGhvc2Ugd2VyZQpnb29kLgoK PiAqIEFkZCBSYnMKPiAKPiBDaGFuZ2VzIGluIHYzOgo+ICogTmV3IHBhdGNoCj4gLS0tCj4gIGlu Y2x1ZGUvZHJtL2RybV9icmlkZ2UuaCB8IDggKysrKy0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDQg aW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS9k cm0vZHJtX2JyaWRnZS5oIGIvaW5jbHVkZS9kcm0vZHJtX2JyaWRnZS5oCj4gaW5kZXggYmZiMDM4 NTE2M2YxLi5kN2Q3MTQwMjMwNTAgMTAwNjQ0Cj4gLS0tIGEvaW5jbHVkZS9kcm0vZHJtX2JyaWRn ZS5oCj4gKysrIGIvaW5jbHVkZS9kcm0vZHJtX2JyaWRnZS5oCj4gQEAgLTI2Myw3ICsyNjMsNyBA QCBzdHJ1Y3QgZHJtX2JyaWRnZV9mdW5jcyB7Cj4gIAkgKiBUaGUgQGF0b21pY19wcmVfZW5hYmxl IGNhbGxiYWNrIGlzIG9wdGlvbmFsLgo+ICAJICovCj4gIAl2b2lkICgqYXRvbWljX3ByZV9lbmFi bGUpKHN0cnVjdCBkcm1fYnJpZGdlICpicmlkZ2UsCj4gLQkJCQkgIHN0cnVjdCBkcm1fYXRvbWlj X3N0YXRlICpzdGF0ZSk7Cj4gKwkJCQkgIHN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpvbGRfc3Rh dGUpOwo+ICAKPiAgCS8qKgo+ICAJICogQGF0b21pY19lbmFibGU6Cj4gQEAgLTI4OCw3ICsyODgs NyBAQCBzdHJ1Y3QgZHJtX2JyaWRnZV9mdW5jcyB7Cj4gIAkgKiBUaGUgQGF0b21pY19lbmFibGUg Y2FsbGJhY2sgaXMgb3B0aW9uYWwuCj4gIAkgKi8KPiAgCXZvaWQgKCphdG9taWNfZW5hYmxlKShz dHJ1Y3QgZHJtX2JyaWRnZSAqYnJpZGdlLAo+IC0JCQkgICAgICBzdHJ1Y3QgZHJtX2F0b21pY19z dGF0ZSAqc3RhdGUpOwo+ICsJCQkgICAgICBzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAqb2xkX3N0 YXRlKTsKPiAgCS8qKgo+ICAJICogQGF0b21pY19kaXNhYmxlOgo+ICAJICoKPiBAQCAtMzExLDcg KzMxMSw3IEBAIHN0cnVjdCBkcm1fYnJpZGdlX2Z1bmNzIHsKPiAgCSAqIFRoZSBAYXRvbWljX2Rp c2FibGUgY2FsbGJhY2sgaXMgb3B0aW9uYWwuCj4gIAkgKi8KPiAgCXZvaWQgKCphdG9taWNfZGlz YWJsZSkoc3RydWN0IGRybV9icmlkZ2UgKmJyaWRnZSwKPiAtCQkJICAgICAgIHN0cnVjdCBkcm1f YXRvbWljX3N0YXRlICpzdGF0ZSk7Cj4gKwkJCSAgICAgICBzdHJ1Y3QgZHJtX2F0b21pY19zdGF0 ZSAqb2xkX3N0YXRlKTsKPiAgCj4gIAkvKioKPiAgCSAqIEBhdG9taWNfcG9zdF9kaXNhYmxlOgo+ IEBAIC0zMzcsNyArMzM3LDcgQEAgc3RydWN0IGRybV9icmlkZ2VfZnVuY3Mgewo+ICAJICogVGhl IEBhdG9taWNfcG9zdF9kaXNhYmxlIGNhbGxiYWNrIGlzIG9wdGlvbmFsLgo+ICAJICovCj4gIAl2 b2lkICgqYXRvbWljX3Bvc3RfZGlzYWJsZSkoc3RydWN0IGRybV9icmlkZ2UgKmJyaWRnZSwKPiAt CQkJCSAgICBzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAqc3RhdGUpOwo+ICsJCQkJICAgIHN0cnVj dCBkcm1fYXRvbWljX3N0YXRlICpvbGRfc3RhdGUpOwo+ICB9Owo+ICAKPiAgLyoqCgotLSAKUmVn YXJkcywKCkxhdXJlbnQgUGluY2hhcnQKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu Zm8vZHJpLWRldmVs