From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76E30C432C0 for ; Tue, 3 Dec 2019 18:19:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3FB7220661 for ; Tue, 3 Dec 2019 18:19:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="p+CtxNTA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726763AbfLCSTf (ORCPT ); Tue, 3 Dec 2019 13:19:35 -0500 Received: from perceval.ideasonboard.com ([213.167.242.64]:39498 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726564AbfLCSTf (ORCPT ); Tue, 3 Dec 2019 13:19:35 -0500 Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id E4DF9309; Tue, 3 Dec 2019 19:19:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1575397173; bh=cBB4j+7hkCsBm/IXK9DIP4kp1uIXKZ/+DCGVNlsPr1s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=p+CtxNTA+gZlqDwPLyEEK72fUFWR6FFq+hD+tZWz+BO1CzlktoMonO5K4T3zidB7M A2enTxKE2ptJsvNpZvTRmx6W6cJiRywD4zuM0bUJLS+S29A6q3sjaG536wsYu5EsHC bDMhzubkXiE65TD0MfV/NEfC53sAbDC3BjytcPtQ= Date: Tue, 3 Dec 2019 20:19:24 +0200 From: Laurent Pinchart To: Boris Brezillon Cc: dri-devel@lists.freedesktop.org, Lucas Stach , Chris Healy , Andrey Smirnov , Nikita Yushchenko , kernel@collabora.com, Daniel Vetter , Inki Dae , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Thierry Reding , Sam Ravnborg , Philipp Zabel , Rob Clark , Andrzej Hajda , Neil Armstrong , Jonas Karlman , Jernej Skrabec , Rob Herring , Mark Rutland , devicetree@vger.kernel.org, Eric Anholt Subject: Re: [PATCH v4 00/11] drm: Add support for bus-format negotiation Message-ID: <20191203181924.GU4730@pendragon.ideasonboard.com> References: <20191203141515.3597631-1-boris.brezillon@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20191203141515.3597631-1-boris.brezillon@collabora.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Boris, On Tue, Dec 03, 2019 at 03:15:04PM +0100, Boris Brezillon wrote: > This patch series aims at adding support for runtime bus-format > negotiation between all elements of the > 'encoder -> bridges -> connector/display' section of the pipeline. > > In order to support that, we need drm bridges to fully take part in the > atomic state validation process, which requires adding a > drm_bridge_state and a new drm_bridge_funcs.atomic_check() hook. > Once those basic building blocks are in place, we can add new hooks to > allow bus format negotiation (those are called just before > ->atomic_check()). The bus format selection is done at runtime by > testing all possible combinations across the whole bridge chain until > one is reported to work. > > No Major changes in this v4. I think I addressed all comments I got > from Neil and Laurent (thanks for the detailed reviews BTW). Note that > this version only contains core changes. Once those changes are merged > I'll send the imx/panel/lvds-codec specific bits. I think it would make sense to fast-track patches 01 to 07 (a bit selfishly as I would have a need for them in omapdrm :-)), but starting from 08 I wonder if it wouldn't make more sense to merge them with the imx/panel/lvds-codec bits to have a user. > A more detailed changelog is provided in each patch. > > This patch series is also available here [1]. > > Thanks, > > Boris > > [1]https://github.com/bbrezillon/linux-0day/commits/drm-bridge-busfmt-v4 > > Boris Brezillon (11): > drm/bridge: Rename bridge helpers targeting a bridge chain > drm/bridge: Introduce drm_bridge_get_next_bridge() > drm: Stop accessing encoder->bridge directly > drm/bridge: Make the bridge chain a double-linked list > drm/bridge: Add the drm_for_each_bridge_in_chain() helper > drm/bridge: Add the drm_bridge_get_prev_bridge() helper > drm/bridge: Clarify the atomic enable/disable hooks semantics > drm/bridge: Add a drm_bridge_state object > drm/bridge: Patch atomic hooks to take a drm_bridge_state > drm/bridge: Add an ->atomic_check() hook > drm/bridge: Add the necessary bits to support bus format negotiation > > .../drm/bridge/analogix/analogix_dp_core.c | 41 +- > drivers/gpu/drm/drm_atomic.c | 39 + > drivers/gpu/drm/drm_atomic_helper.c | 53 +- > drivers/gpu/drm/drm_bridge.c | 756 +++++++++++++++--- > drivers/gpu/drm/drm_encoder.c | 15 +- > drivers/gpu/drm/drm_probe_helper.c | 4 +- > drivers/gpu/drm/exynos/exynos_drm_dsi.c | 13 +- > drivers/gpu/drm/mediatek/mtk_hdmi.c | 8 +- > drivers/gpu/drm/msm/edp/edp_bridge.c | 10 +- > drivers/gpu/drm/omapdrm/omap_drv.c | 4 +- > drivers/gpu/drm/omapdrm/omap_encoder.c | 3 +- > drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 10 +- > drivers/gpu/drm/vc4/vc4_dsi.c | 18 +- > include/drm/drm_atomic.h | 3 + > include/drm/drm_bridge.h | 404 +++++++++- > include/drm/drm_encoder.h | 7 +- > 16 files changed, 1174 insertions(+), 214 deletions(-) -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30B8BC432C3 for ; Tue, 3 Dec 2019 18:19:38 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0D7B420661 for ; Tue, 3 Dec 2019 18:19:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0D7B420661 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 609FE6E0B6; Tue, 3 Dec 2019 18:19:37 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by gabe.freedesktop.org (Postfix) with ESMTPS id BF9666E0B6 for ; Tue, 3 Dec 2019 18:19:35 +0000 (UTC) Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id E4DF9309; Tue, 3 Dec 2019 19:19:32 +0100 (CET) Date: Tue, 3 Dec 2019 20:19:24 +0200 From: Laurent Pinchart To: Boris Brezillon Subject: Re: [PATCH v4 00/11] drm: Add support for bus-format negotiation Message-ID: <20191203181924.GU4730@pendragon.ideasonboard.com> References: <20191203141515.3597631-1-boris.brezillon@collabora.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191203141515.3597631-1-boris.brezillon@collabora.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1575397173; bh=cBB4j+7hkCsBm/IXK9DIP4kp1uIXKZ/+DCGVNlsPr1s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=p+CtxNTA+gZlqDwPLyEEK72fUFWR6FFq+hD+tZWz+BO1CzlktoMonO5K4T3zidB7M A2enTxKE2ptJsvNpZvTRmx6W6cJiRywD4zuM0bUJLS+S29A6q3sjaG536wsYu5EsHC bDMhzubkXiE65TD0MfV/NEfC53sAbDC3BjytcPtQ= X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Neil Armstrong , dri-devel@lists.freedesktop.org, Thierry Reding , kernel@collabora.com, Sam Ravnborg , Nikita Yushchenko , Andrey Smirnov , Kyungmin Park , Chris Healy , devicetree@vger.kernel.org, Jonas Karlman , Rob Herring , Jernej Skrabec , Seung-Woo Kim Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" SGkgQm9yaXMsCgpPbiBUdWUsIERlYyAwMywgMjAxOSBhdCAwMzoxNTowNFBNICswMTAwLCBCb3Jp cyBCcmV6aWxsb24gd3JvdGU6Cj4gVGhpcyBwYXRjaCBzZXJpZXMgYWltcyBhdCBhZGRpbmcgc3Vw cG9ydCBmb3IgcnVudGltZSBidXMtZm9ybWF0Cj4gbmVnb3RpYXRpb24gYmV0d2VlbiBhbGwgZWxl bWVudHMgb2YgdGhlCj4gJ2VuY29kZXIgLT4gYnJpZGdlcyAtPiBjb25uZWN0b3IvZGlzcGxheScg c2VjdGlvbiBvZiB0aGUgcGlwZWxpbmUuCj4gCj4gSW4gb3JkZXIgdG8gc3VwcG9ydCB0aGF0LCB3 ZSBuZWVkIGRybSBicmlkZ2VzIHRvIGZ1bGx5IHRha2UgcGFydCBpbiB0aGUKPiBhdG9taWMgc3Rh dGUgdmFsaWRhdGlvbiBwcm9jZXNzLCB3aGljaCByZXF1aXJlcyBhZGRpbmcgYQo+IGRybV9icmlk Z2Vfc3RhdGUgYW5kIGEgbmV3IGRybV9icmlkZ2VfZnVuY3MuYXRvbWljX2NoZWNrKCkgaG9vay4K PiBPbmNlIHRob3NlIGJhc2ljIGJ1aWxkaW5nIGJsb2NrcyBhcmUgaW4gcGxhY2UsIHdlIGNhbiBh ZGQgbmV3IGhvb2tzIHRvCj4gYWxsb3cgYnVzIGZvcm1hdCBuZWdvdGlhdGlvbiAodGhvc2UgYXJl IGNhbGxlZCBqdXN0IGJlZm9yZQo+IC0+YXRvbWljX2NoZWNrKCkpLiBUaGUgYnVzIGZvcm1hdCBz ZWxlY3Rpb24gaXMgZG9uZSBhdCBydW50aW1lIGJ5Cj4gdGVzdGluZyBhbGwgcG9zc2libGUgY29t YmluYXRpb25zIGFjcm9zcyB0aGUgd2hvbGUgYnJpZGdlIGNoYWluIHVudGlsCj4gb25lIGlzIHJl cG9ydGVkIHRvIHdvcmsuCj4gCj4gTm8gTWFqb3IgY2hhbmdlcyBpbiB0aGlzIHY0LiBJIHRoaW5r IEkgYWRkcmVzc2VkIGFsbCBjb21tZW50cyBJIGdvdAo+IGZyb20gTmVpbCBhbmQgTGF1cmVudCAo dGhhbmtzIGZvciB0aGUgZGV0YWlsZWQgcmV2aWV3cyBCVFcpLiBOb3RlIHRoYXQKPiB0aGlzIHZl cnNpb24gb25seSBjb250YWlucyBjb3JlIGNoYW5nZXMuIE9uY2UgdGhvc2UgY2hhbmdlcyBhcmUg bWVyZ2VkCj4gSSdsbCBzZW5kIHRoZSBpbXgvcGFuZWwvbHZkcy1jb2RlYyBzcGVjaWZpYyBiaXRz LgoKSSB0aGluayBpdCB3b3VsZCBtYWtlIHNlbnNlIHRvIGZhc3QtdHJhY2sgcGF0Y2hlcyAwMSB0 byAwNyAoYSBiaXQKc2VsZmlzaGx5IGFzIEkgd291bGQgaGF2ZSBhIG5lZWQgZm9yIHRoZW0gaW4g b21hcGRybSA6LSkpLCBidXQgc3RhcnRpbmcKZnJvbSAwOCBJIHdvbmRlciBpZiBpdCB3b3VsZG4n dCBtYWtlIG1vcmUgc2Vuc2UgdG8gbWVyZ2UgdGhlbSB3aXRoIHRoZQppbXgvcGFuZWwvbHZkcy1j b2RlYyBiaXRzIHRvIGhhdmUgYSB1c2VyLgoKPiBBIG1vcmUgZGV0YWlsZWQgY2hhbmdlbG9nIGlz IHByb3ZpZGVkIGluIGVhY2ggcGF0Y2guCj4gCj4gVGhpcyBwYXRjaCBzZXJpZXMgaXMgYWxzbyBh dmFpbGFibGUgaGVyZSBbMV0uCj4gCj4gVGhhbmtzLAo+IAo+IEJvcmlzCj4gCj4gWzFdaHR0cHM6 Ly9naXRodWIuY29tL2JicmV6aWxsb24vbGludXgtMGRheS9jb21taXRzL2RybS1icmlkZ2UtYnVz Zm10LXY0Cj4gCj4gQm9yaXMgQnJlemlsbG9uICgxMSk6Cj4gICBkcm0vYnJpZGdlOiBSZW5hbWUg YnJpZGdlIGhlbHBlcnMgdGFyZ2V0aW5nIGEgYnJpZGdlIGNoYWluCj4gICBkcm0vYnJpZGdlOiBJ bnRyb2R1Y2UgZHJtX2JyaWRnZV9nZXRfbmV4dF9icmlkZ2UoKQo+ICAgZHJtOiBTdG9wIGFjY2Vz c2luZyBlbmNvZGVyLT5icmlkZ2UgZGlyZWN0bHkKPiAgIGRybS9icmlkZ2U6IE1ha2UgdGhlIGJy aWRnZSBjaGFpbiBhIGRvdWJsZS1saW5rZWQgbGlzdAo+ICAgZHJtL2JyaWRnZTogQWRkIHRoZSBk cm1fZm9yX2VhY2hfYnJpZGdlX2luX2NoYWluKCkgaGVscGVyCj4gICBkcm0vYnJpZGdlOiBBZGQg dGhlIGRybV9icmlkZ2VfZ2V0X3ByZXZfYnJpZGdlKCkgaGVscGVyCj4gICBkcm0vYnJpZGdlOiBD bGFyaWZ5IHRoZSBhdG9taWMgZW5hYmxlL2Rpc2FibGUgaG9va3Mgc2VtYW50aWNzCj4gICBkcm0v YnJpZGdlOiBBZGQgYSBkcm1fYnJpZGdlX3N0YXRlIG9iamVjdAo+ICAgZHJtL2JyaWRnZTogUGF0 Y2ggYXRvbWljIGhvb2tzIHRvIHRha2UgYSBkcm1fYnJpZGdlX3N0YXRlCj4gICBkcm0vYnJpZGdl OiBBZGQgYW4gLT5hdG9taWNfY2hlY2soKSBob29rCj4gICBkcm0vYnJpZGdlOiBBZGQgdGhlIG5l Y2Vzc2FyeSBiaXRzIHRvIHN1cHBvcnQgYnVzIGZvcm1hdCBuZWdvdGlhdGlvbgo+IAo+ICAuLi4v ZHJtL2JyaWRnZS9hbmFsb2dpeC9hbmFsb2dpeF9kcF9jb3JlLmMgICAgfCAgNDEgKy0KPiAgZHJp dmVycy9ncHUvZHJtL2RybV9hdG9taWMuYyAgICAgICAgICAgICAgICAgIHwgIDM5ICsKPiAgZHJp dmVycy9ncHUvZHJtL2RybV9hdG9taWNfaGVscGVyLmMgICAgICAgICAgIHwgIDUzICstCj4gIGRy aXZlcnMvZ3B1L2RybS9kcm1fYnJpZGdlLmMgICAgICAgICAgICAgICAgICB8IDc1NiArKysrKysr KysrKysrKystLS0KPiAgZHJpdmVycy9ncHUvZHJtL2RybV9lbmNvZGVyLmMgICAgICAgICAgICAg ICAgIHwgIDE1ICstCj4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fcHJvYmVfaGVscGVyLmMgICAgICAg ICAgICB8ICAgNCArLQo+ICBkcml2ZXJzL2dwdS9kcm0vZXh5bm9zL2V4eW5vc19kcm1fZHNpLmMg ICAgICAgfCAgMTMgKy0KPiAgZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19oZG1pLmMgICAg ICAgICAgIHwgICA4ICstCj4gIGRyaXZlcnMvZ3B1L2RybS9tc20vZWRwL2VkcF9icmlkZ2UuYyAg ICAgICAgICB8ICAxMCArLQo+ICBkcml2ZXJzL2dwdS9kcm0vb21hcGRybS9vbWFwX2Rydi5jICAg ICAgICAgICAgfCAgIDQgKy0KPiAgZHJpdmVycy9ncHUvZHJtL29tYXBkcm0vb21hcF9lbmNvZGVy LmMgICAgICAgIHwgICAzICstCj4gIGRyaXZlcnMvZ3B1L2RybS9yY2FyLWR1L3JjYXJfZHVfY3J0 Yy5jICAgICAgICB8ICAxMCArLQo+ICBkcml2ZXJzL2dwdS9kcm0vdmM0L3ZjNF9kc2kuYyAgICAg ICAgICAgICAgICAgfCAgMTggKy0KPiAgaW5jbHVkZS9kcm0vZHJtX2F0b21pYy5oICAgICAgICAg ICAgICAgICAgICAgIHwgICAzICsKPiAgaW5jbHVkZS9kcm0vZHJtX2JyaWRnZS5oICAgICAgICAg ICAgICAgICAgICAgIHwgNDA0ICsrKysrKysrKy0KPiAgaW5jbHVkZS9kcm0vZHJtX2VuY29kZXIu aCAgICAgICAgICAgICAgICAgICAgIHwgICA3ICstCj4gIDE2IGZpbGVzIGNoYW5nZWQsIDExNzQg aW5zZXJ0aW9ucygrKSwgMjE0IGRlbGV0aW9ucygtKQoKLS0gClJlZ2FyZHMsCgpMYXVyZW50IFBp bmNoYXJ0Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRy aS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRw czovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbA==