All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] utils/genrandconfig: fix runtime issue with Python 3
Date: Tue, 3 Dec 2019 20:58:36 +0100	[thread overview]
Message-ID: <20191203205836.66e9c82a@windsurf> (raw)
In-Reply-To: <1a56a5b4-e64b-3844-7352-d12c6407585b@mind.be>

Hello,

On Tue, 3 Dec 2019 20:36:17 +0100
Arnout Vandecappelle <arnout@mind.be> wrote:

>  Just guessing here, but: originally this file was downloaded with
> urlopen_closing() instead of being read from a local file.

Ah, that must be it!

> Since we only use genrandconfig in the autobuilders in python2 (cfr.
> the shebang)

I'm not sure why you say "in python2" ? The shebang in genrandconfig is:

#!/usr/bin/env python

and I indeed noticed the issue with Python 3.x because I started using
genrandconfig on my updated Fedora system, which now uses Python 3.x as
"python".

>, nobody noticed that this broke when I switched to
> reading from file instead of URL two years ago (84929a53a4).

Indeed. I'll update the commit log and resend.

Thanks for the hint!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2019-12-03 19:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-03 16:51 [Buildroot] [PATCH] utils/genrandconfig: fix runtime issue with Python 3 Thomas Petazzoni
2019-12-03 19:36 ` Arnout Vandecappelle
2019-12-03 19:58   ` Thomas Petazzoni [this message]
2019-12-04 12:52     ` Arnout Vandecappelle
2019-12-04 12:58       ` Thomas Petazzoni
2019-12-03 22:01 ` Arnout Vandecappelle
2019-12-06  8:53 ` Peter Korsgaard
2019-12-06  9:00 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191203205836.66e9c82a@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.