From: Jonathan Nieder <jrnieder@gmail.com>
To: Jeff King <peff@peff.net>
Cc: "Junio C Hamano" <gitster@pobox.com>,
"SZEDER Gábor" <szeder.dev@gmail.com>,
"Colin Stolley" <cstolley@runbox.com>,
git@vger.kernel.org, "Martin Fick" <mfick@codeaurora.org>
Subject: Re: [PATCH] packfile.c: speed up loading lots of packfiles.
Date: Tue, 3 Dec 2019 20:23:32 -0800 [thread overview]
Message-ID: <20191204042332.GG214771@google.com> (raw)
In-Reply-To: <20191203221730.GA28419@sigill.intra.peff.net>
Jeff King wrote:
> I agree that 10,000 packs is ridiculous, but we do see it (and worse)
> occasionally from people pushing in a loop before our scheduled
> maintenance kicks in.
On that subject: one thing Martin Fick (cc-ed) has suggested is moving
more of the garbage collection work "inline" into the push path. That
is, instead of letting someone push 10,000 packs in a loop, build
concatenated packs ("exponential rollup") in the push path and don't
return success and commit the packs into the object store until we're
done. That way a reasonably small amortized cost is paid up front by
the pusher instead of later by everyone.
Midx changes things a little: it might make sense to build
concatenated idxes instead of packs, which would still avoid the same
quadratic behavior.
Just a random thought,
Jonathan
next prev parent reply other threads:[~2019-12-04 4:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-27 22:24 [PATCH] packfile.c: speed up loading lots of packfiles Colin Stolley
2019-11-28 0:42 ` hashmap vs khash? " Eric Wong
2019-11-30 17:36 ` Junio C Hamano
2019-12-02 14:39 ` Jeff King
2019-12-02 17:40 ` SZEDER Gábor
2019-12-02 19:42 ` Jeff King
2019-12-03 6:17 ` Taylor Blau
2019-12-03 15:34 ` Jeff King
2019-12-03 16:04 ` Junio C Hamano
2019-12-03 17:33 ` Colin Stolley
2019-12-03 22:18 ` Jeff King
2019-12-04 18:15 ` Junio C Hamano
2019-12-03 22:17 ` Jeff King
2019-12-04 4:23 ` Jonathan Nieder [this message]
2019-12-03 6:19 ` Taylor Blau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191204042332.GG214771@google.com \
--to=jrnieder@gmail.com \
--cc=cstolley@runbox.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mfick@codeaurora.org \
--cc=peff@peff.net \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.