From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8A8EC43603 for ; Wed, 4 Dec 2019 09:03:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C1A5F2073B for ; Wed, 4 Dec 2019 09:03:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726166AbfLDJDI (ORCPT ); Wed, 4 Dec 2019 04:03:08 -0500 Received: from bhuna.collabora.co.uk ([46.235.227.227]:47438 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725994AbfLDJDI (ORCPT ); Wed, 4 Dec 2019 04:03:08 -0500 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 928FF291100; Wed, 4 Dec 2019 09:03:04 +0000 (GMT) Date: Wed, 4 Dec 2019 10:03:02 +0100 From: Boris Brezillon To: Laurent Pinchart Cc: dri-devel@lists.freedesktop.org, Lucas Stach , Chris Healy , Andrey Smirnov , Nikita Yushchenko , kernel@collabora.com, Daniel Vetter , Inki Dae , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Thierry Reding , Sam Ravnborg , Philipp Zabel , Rob Clark , Andrzej Hajda , Neil Armstrong , Jonas Karlman , Jernej Skrabec , Rob Herring , Mark Rutland , devicetree@vger.kernel.org, Eric Anholt Subject: Re: [PATCH v4 08/11] drm/bridge: Add a drm_bridge_state object Message-ID: <20191204100302.38096544@collabora.com> In-Reply-To: <20191203181705.GT4730@pendragon.ideasonboard.com> References: <20191203141515.3597631-1-boris.brezillon@collabora.com> <20191203141515.3597631-9-boris.brezillon@collabora.com> <20191203181705.GT4730@pendragon.ideasonboard.com> Organization: Collabora X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, 3 Dec 2019 20:17:05 +0200 Laurent Pinchart wrote: > Hi Boris, > > Thank you for the patch. > > On Tue, Dec 03, 2019 at 03:15:12PM +0100, Boris Brezillon wrote: > > One of the last remaining objects to not have its atomic state. > > > > This is being motivated by our attempt to support runtime bus-format > > negotiation between elements of the bridge chain. > > This patch just paves the road for such a feature by adding a new > > drm_bridge_state object inheriting from drm_private_obj so we can > > re-use some of the existing state initialization/tracking logic. > > > > Signed-off-by: Boris Brezillon > > Reviewed-by: Neil Armstrong > > --- > > Changes in v4: > > * Fix the doc > > * Kill default helpers (inlined) > > I liked the default helpers, inlining their content makes the code more > difficult to follow in my opinion. I'll go back to this approach then. Should I keep the original helper names even though they're not globally visible (and should probably never be)? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7318BC0044D for ; Wed, 4 Dec 2019 09:03:10 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4F58E2073B for ; Wed, 4 Dec 2019 09:03:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4F58E2073B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 909056F473; Wed, 4 Dec 2019 09:03:09 +0000 (UTC) Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by gabe.freedesktop.org (Postfix) with ESMTPS id BA0E56F473 for ; Wed, 4 Dec 2019 09:03:07 +0000 (UTC) Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 928FF291100; Wed, 4 Dec 2019 09:03:04 +0000 (GMT) Date: Wed, 4 Dec 2019 10:03:02 +0100 From: Boris Brezillon To: Laurent Pinchart Subject: Re: [PATCH v4 08/11] drm/bridge: Add a drm_bridge_state object Message-ID: <20191204100302.38096544@collabora.com> In-Reply-To: <20191203181705.GT4730@pendragon.ideasonboard.com> References: <20191203141515.3597631-1-boris.brezillon@collabora.com> <20191203141515.3597631-9-boris.brezillon@collabora.com> <20191203181705.GT4730@pendragon.ideasonboard.com> Organization: Collabora X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Neil Armstrong , dri-devel@lists.freedesktop.org, Thierry Reding , kernel@collabora.com, Sam Ravnborg , Nikita Yushchenko , Andrey Smirnov , Kyungmin Park , Chris Healy , devicetree@vger.kernel.org, Jonas Karlman , Rob Herring , Jernej Skrabec , Seung-Woo Kim Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gVHVlLCAzIERlYyAyMDE5IDIwOjE3OjA1ICswMjAwCkxhdXJlbnQgUGluY2hhcnQgPGxhdXJl bnQucGluY2hhcnRAaWRlYXNvbmJvYXJkLmNvbT4gd3JvdGU6Cgo+IEhpIEJvcmlzLAo+IAo+IFRo YW5rIHlvdSBmb3IgdGhlIHBhdGNoLgo+IAo+IE9uIFR1ZSwgRGVjIDAzLCAyMDE5IGF0IDAzOjE1 OjEyUE0gKzAxMDAsIEJvcmlzIEJyZXppbGxvbiB3cm90ZToKPiA+IE9uZSBvZiB0aGUgbGFzdCBy ZW1haW5pbmcgb2JqZWN0cyB0byBub3QgaGF2ZSBpdHMgYXRvbWljIHN0YXRlLgo+ID4gCj4gPiBU aGlzIGlzIGJlaW5nIG1vdGl2YXRlZCBieSBvdXIgYXR0ZW1wdCB0byBzdXBwb3J0IHJ1bnRpbWUg YnVzLWZvcm1hdAo+ID4gbmVnb3RpYXRpb24gYmV0d2VlbiBlbGVtZW50cyBvZiB0aGUgYnJpZGdl IGNoYWluLgo+ID4gVGhpcyBwYXRjaCBqdXN0IHBhdmVzIHRoZSByb2FkIGZvciBzdWNoIGEgZmVh dHVyZSBieSBhZGRpbmcgYSBuZXcKPiA+IGRybV9icmlkZ2Vfc3RhdGUgb2JqZWN0IGluaGVyaXRp bmcgZnJvbSBkcm1fcHJpdmF0ZV9vYmogc28gd2UgY2FuCj4gPiByZS11c2Ugc29tZSBvZiB0aGUg ZXhpc3Rpbmcgc3RhdGUgaW5pdGlhbGl6YXRpb24vdHJhY2tpbmcgbG9naWMuCj4gPiAKPiA+IFNp Z25lZC1vZmYtYnk6IEJvcmlzIEJyZXppbGxvbiA8Ym9yaXMuYnJlemlsbG9uQGNvbGxhYm9yYS5j b20+Cj4gPiBSZXZpZXdlZC1ieTogTmVpbCBBcm1zdHJvbmcgPG5hcm1zdHJvbmdAYmF5bGlicmUu Y29tPgo+ID4gLS0tCj4gPiBDaGFuZ2VzIGluIHY0Ogo+ID4gKiBGaXggdGhlIGRvYwo+ID4gKiBL aWxsIGRlZmF1bHQgaGVscGVycyAoaW5saW5lZCkgIAo+IAo+IEkgbGlrZWQgdGhlIGRlZmF1bHQg aGVscGVycywgaW5saW5pbmcgdGhlaXIgY29udGVudCBtYWtlcyB0aGUgY29kZSBtb3JlCj4gZGlm ZmljdWx0IHRvIGZvbGxvdyBpbiBteSBvcGluaW9uLgoKSSdsbCBnbyBiYWNrIHRvIHRoaXMgYXBw cm9hY2ggdGhlbi4gU2hvdWxkIEkga2VlcCB0aGUgb3JpZ2luYWwgaGVscGVyCm5hbWVzIGV2ZW4g dGhvdWdoIHRoZXkncmUgbm90IGdsb2JhbGx5IHZpc2libGUgKGFuZCBzaG91bGQgcHJvYmFibHkK bmV2ZXIgYmUpPwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn Cmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs