From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A236DC43603 for ; Wed, 4 Dec 2019 09:10:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 76456206DB for ; Wed, 4 Dec 2019 09:10:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727158AbfLDJKD (ORCPT ); Wed, 4 Dec 2019 04:10:03 -0500 Received: from bhuna.collabora.co.uk ([46.235.227.227]:47610 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725922AbfLDJKC (ORCPT ); Wed, 4 Dec 2019 04:10:02 -0500 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 9238B291115; Wed, 4 Dec 2019 09:10:00 +0000 (GMT) Date: Wed, 4 Dec 2019 10:09:57 +0100 From: Boris Brezillon To: Laurent Pinchart Cc: dri-devel@lists.freedesktop.org, Lucas Stach , Chris Healy , Andrey Smirnov , Nikita Yushchenko , kernel@collabora.com, Daniel Vetter , Inki Dae , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Thierry Reding , Sam Ravnborg , Philipp Zabel , Rob Clark , Andrzej Hajda , Neil Armstrong , Jonas Karlman , Jernej Skrabec , Rob Herring , Mark Rutland , devicetree@vger.kernel.org, Eric Anholt Subject: Re: [PATCH v4 00/11] drm: Add support for bus-format negotiation Message-ID: <20191204100957.15406559@collabora.com> In-Reply-To: <20191203181924.GU4730@pendragon.ideasonboard.com> References: <20191203141515.3597631-1-boris.brezillon@collabora.com> <20191203181924.GU4730@pendragon.ideasonboard.com> Organization: Collabora X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, 3 Dec 2019 20:19:24 +0200 Laurent Pinchart wrote: > Hi Boris, > > On Tue, Dec 03, 2019 at 03:15:04PM +0100, Boris Brezillon wrote: > > This patch series aims at adding support for runtime bus-format > > negotiation between all elements of the > > 'encoder -> bridges -> connector/display' section of the pipeline. > > > > In order to support that, we need drm bridges to fully take part in the > > atomic state validation process, which requires adding a > > drm_bridge_state and a new drm_bridge_funcs.atomic_check() hook. > > Once those basic building blocks are in place, we can add new hooks to > > allow bus format negotiation (those are called just before > > ->atomic_check()). The bus format selection is done at runtime by > > testing all possible combinations across the whole bridge chain until > > one is reported to work. > > > > No Major changes in this v4. I think I addressed all comments I got > > from Neil and Laurent (thanks for the detailed reviews BTW). Note that > > this version only contains core changes. Once those changes are merged > > I'll send the imx/panel/lvds-codec specific bits. > > I think it would make sense to fast-track patches 01 to 07 (a bit > selfishly as I would have a need for them in omapdrm :-)) Will do that end of this week. >, but starting > from 08 I wonder if it wouldn't make more sense to merge them with the > imx/panel/lvds-codec bits to have a user. I'd really like to see that happen early in this release cycle so we can catch bugs before those commits reach Linus' tree, and the lvds-codec changes depend on your PR. Can we make sure this one is merged just after the MW has closed and the drm-next -> drm-misc-next back merge done just after that? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DD9EC0044D for ; Wed, 4 Dec 2019 09:10:05 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 59A57206DB for ; Wed, 4 Dec 2019 09:10:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 59A57206DB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 77D3F6F9E8; Wed, 4 Dec 2019 09:10:04 +0000 (UTC) Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by gabe.freedesktop.org (Postfix) with ESMTPS id 998976FA06 for ; Wed, 4 Dec 2019 09:10:02 +0000 (UTC) Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 9238B291115; Wed, 4 Dec 2019 09:10:00 +0000 (GMT) Date: Wed, 4 Dec 2019 10:09:57 +0100 From: Boris Brezillon To: Laurent Pinchart Subject: Re: [PATCH v4 00/11] drm: Add support for bus-format negotiation Message-ID: <20191204100957.15406559@collabora.com> In-Reply-To: <20191203181924.GU4730@pendragon.ideasonboard.com> References: <20191203141515.3597631-1-boris.brezillon@collabora.com> <20191203181924.GU4730@pendragon.ideasonboard.com> Organization: Collabora X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Neil Armstrong , dri-devel@lists.freedesktop.org, Thierry Reding , kernel@collabora.com, Sam Ravnborg , Nikita Yushchenko , Andrey Smirnov , Kyungmin Park , Chris Healy , devicetree@vger.kernel.org, Jonas Karlman , Rob Herring , Jernej Skrabec , Seung-Woo Kim Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gVHVlLCAzIERlYyAyMDE5IDIwOjE5OjI0ICswMjAwCkxhdXJlbnQgUGluY2hhcnQgPGxhdXJl bnQucGluY2hhcnRAaWRlYXNvbmJvYXJkLmNvbT4gd3JvdGU6Cgo+IEhpIEJvcmlzLAo+IAo+IE9u IFR1ZSwgRGVjIDAzLCAyMDE5IGF0IDAzOjE1OjA0UE0gKzAxMDAsIEJvcmlzIEJyZXppbGxvbiB3 cm90ZToKPiA+IFRoaXMgcGF0Y2ggc2VyaWVzIGFpbXMgYXQgYWRkaW5nIHN1cHBvcnQgZm9yIHJ1 bnRpbWUgYnVzLWZvcm1hdAo+ID4gbmVnb3RpYXRpb24gYmV0d2VlbiBhbGwgZWxlbWVudHMgb2Yg dGhlCj4gPiAnZW5jb2RlciAtPiBicmlkZ2VzIC0+IGNvbm5lY3Rvci9kaXNwbGF5JyBzZWN0aW9u IG9mIHRoZSBwaXBlbGluZS4KPiA+IAo+ID4gSW4gb3JkZXIgdG8gc3VwcG9ydCB0aGF0LCB3ZSBu ZWVkIGRybSBicmlkZ2VzIHRvIGZ1bGx5IHRha2UgcGFydCBpbiB0aGUKPiA+IGF0b21pYyBzdGF0 ZSB2YWxpZGF0aW9uIHByb2Nlc3MsIHdoaWNoIHJlcXVpcmVzIGFkZGluZyBhCj4gPiBkcm1fYnJp ZGdlX3N0YXRlIGFuZCBhIG5ldyBkcm1fYnJpZGdlX2Z1bmNzLmF0b21pY19jaGVjaygpIGhvb2su Cj4gPiBPbmNlIHRob3NlIGJhc2ljIGJ1aWxkaW5nIGJsb2NrcyBhcmUgaW4gcGxhY2UsIHdlIGNh biBhZGQgbmV3IGhvb2tzIHRvCj4gPiBhbGxvdyBidXMgZm9ybWF0IG5lZ290aWF0aW9uICh0aG9z ZSBhcmUgY2FsbGVkIGp1c3QgYmVmb3JlICAKPiA+IC0+YXRvbWljX2NoZWNrKCkpLiBUaGUgYnVz IGZvcm1hdCBzZWxlY3Rpb24gaXMgZG9uZSBhdCBydW50aW1lIGJ5ICAKPiA+IHRlc3RpbmcgYWxs IHBvc3NpYmxlIGNvbWJpbmF0aW9ucyBhY3Jvc3MgdGhlIHdob2xlIGJyaWRnZSBjaGFpbiB1bnRp bAo+ID4gb25lIGlzIHJlcG9ydGVkIHRvIHdvcmsuCj4gPiAKPiA+IE5vIE1ham9yIGNoYW5nZXMg aW4gdGhpcyB2NC4gSSB0aGluayBJIGFkZHJlc3NlZCBhbGwgY29tbWVudHMgSSBnb3QKPiA+IGZy b20gTmVpbCBhbmQgTGF1cmVudCAodGhhbmtzIGZvciB0aGUgZGV0YWlsZWQgcmV2aWV3cyBCVFcp LiBOb3RlIHRoYXQKPiA+IHRoaXMgdmVyc2lvbiBvbmx5IGNvbnRhaW5zIGNvcmUgY2hhbmdlcy4g T25jZSB0aG9zZSBjaGFuZ2VzIGFyZSBtZXJnZWQKPiA+IEknbGwgc2VuZCB0aGUgaW14L3BhbmVs L2x2ZHMtY29kZWMgc3BlY2lmaWMgYml0cy4gIAo+IAo+IEkgdGhpbmsgaXQgd291bGQgbWFrZSBz ZW5zZSB0byBmYXN0LXRyYWNrIHBhdGNoZXMgMDEgdG8gMDcgKGEgYml0Cj4gc2VsZmlzaGx5IGFz IEkgd291bGQgaGF2ZSBhIG5lZWQgZm9yIHRoZW0gaW4gb21hcGRybSA6LSkpCgpXaWxsIGRvIHRo YXQgZW5kIG9mIHRoaXMgd2Vlay4KCj4sIGJ1dCBzdGFydGluZwo+IGZyb20gMDggSSB3b25kZXIg aWYgaXQgd291bGRuJ3QgbWFrZSBtb3JlIHNlbnNlIHRvIG1lcmdlIHRoZW0gd2l0aCB0aGUKPiBp bXgvcGFuZWwvbHZkcy1jb2RlYyBiaXRzIHRvIGhhdmUgYSB1c2VyLgoKSSdkIHJlYWxseSBsaWtl IHRvIHNlZSB0aGF0IGhhcHBlbiBlYXJseSBpbiB0aGlzIHJlbGVhc2UgY3ljbGUgc28gd2UKY2Fu IGNhdGNoIGJ1Z3MgYmVmb3JlIHRob3NlIGNvbW1pdHMgcmVhY2ggTGludXMnIHRyZWUsIGFuZCB0 aGUKbHZkcy1jb2RlYyBjaGFuZ2VzIGRlcGVuZCBvbiB5b3VyIFBSLiBDYW4gd2UgbWFrZSBzdXJl IHRoaXMgb25lIGlzCm1lcmdlZCBqdXN0IGFmdGVyIHRoZSBNVyBoYXMgY2xvc2VkIGFuZCB0aGUg ZHJtLW5leHQgLT4gZHJtLW1pc2MtbmV4dApiYWNrIG1lcmdlIGRvbmUganVzdCBhZnRlciB0aGF0 PwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2 ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWw=