From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1B3FC43603 for ; Wed, 4 Dec 2019 10:38:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C5E272068E for ; Wed, 4 Dec 2019 10:38:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="nYNUlz4r" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727445AbfLDKiT (ORCPT ); Wed, 4 Dec 2019 05:38:19 -0500 Received: from perceval.ideasonboard.com ([213.167.242.64]:54606 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727429AbfLDKiT (ORCPT ); Wed, 4 Dec 2019 05:38:19 -0500 Received: from pendragon.ideasonboard.com (85-76-7-253-nat.elisa-mobile.fi [85.76.7.253]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id DB93C2E5; Wed, 4 Dec 2019 11:38:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1575455896; bh=VYwRJOBjxh1800/WKysrFil7fftC0CbXVFmWz6HfoEg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nYNUlz4rM9JU3o4YMkEk4KMPylmWuw6KYLkdVB+mkhIffo3E1dnrgcYy4DpS/cGtU Py9TgpAhqAhVa3g8Fk4nA4QLi/JFiYFvgiv875y4s6oNT0pgasXvWTbaqcrI0e9tdw EpyXCl+nBxjN4iHOvMlwBeOvfl13FUpttkinZTWE= Date: Wed, 4 Dec 2019 12:38:06 +0200 From: Laurent Pinchart To: Boris Brezillon Cc: dri-devel@lists.freedesktop.org, Lucas Stach , Chris Healy , Andrey Smirnov , Nikita Yushchenko , kernel@collabora.com, Daniel Vetter , Inki Dae , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Thierry Reding , Sam Ravnborg , Philipp Zabel , Rob Clark , Andrzej Hajda , Neil Armstrong , Jonas Karlman , Jernej Skrabec , Rob Herring , Mark Rutland , devicetree@vger.kernel.org, Eric Anholt Subject: Re: [PATCH v4 08/11] drm/bridge: Add a drm_bridge_state object Message-ID: <20191204103806.GD6705@pendragon.ideasonboard.com> References: <20191203141515.3597631-1-boris.brezillon@collabora.com> <20191203141515.3597631-9-boris.brezillon@collabora.com> <20191203181705.GT4730@pendragon.ideasonboard.com> <20191204100302.38096544@collabora.com> <20191204091255.GB6705@pendragon.ideasonboard.com> <20191204104207.38367944@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20191204104207.38367944@collabora.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Boris, On Wed, Dec 04, 2019 at 10:42:07AM +0100, Boris Brezillon wrote: > On Wed, 4 Dec 2019 11:12:55 +0200 Laurent Pinchart wrote: > > On Wed, Dec 04, 2019 at 10:03:02AM +0100, Boris Brezillon wrote: > > > On Tue, 3 Dec 2019 20:17:05 +0200 Laurent Pinchart wrote: > > > > On Tue, Dec 03, 2019 at 03:15:12PM +0100, Boris Brezillon wrote: > > > > > One of the last remaining objects to not have its atomic state. > > > > > > > > > > This is being motivated by our attempt to support runtime bus-format > > > > > negotiation between elements of the bridge chain. > > > > > This patch just paves the road for such a feature by adding a new > > > > > drm_bridge_state object inheriting from drm_private_obj so we can > > > > > re-use some of the existing state initialization/tracking logic. > > > > > > > > > > Signed-off-by: Boris Brezillon > > > > > Reviewed-by: Neil Armstrong > > > > > --- > > > > > Changes in v4: > > > > > * Fix the doc > > > > > * Kill default helpers (inlined) > > > > > > > > I liked the default helpers, inlining their content makes the code more > > > > difficult to follow in my opinion. > > > > > > I'll go back to this approach then. Should I keep the original helper > > > names even though they're not globally visible (and should probably > > > never be)? > > > > I agree they should probably never be visible, and I trust your > > judgement on naming. Please double-check the documentation though, to > > ensure that it matches the implementation. > > Is there any point keeping the documentation if they're not exposed? I'll let you decide on that, depending on if the documentation could bring value or if the functions would be so trivial that it would be overkill. -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98E8EC2BC73 for ; Wed, 4 Dec 2019 10:38:20 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 772582068E for ; Wed, 4 Dec 2019 10:38:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 772582068E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C35C26E8B8; Wed, 4 Dec 2019 10:38:19 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7A90A6E8B8 for ; Wed, 4 Dec 2019 10:38:18 +0000 (UTC) Received: from pendragon.ideasonboard.com (85-76-7-253-nat.elisa-mobile.fi [85.76.7.253]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id DB93C2E5; Wed, 4 Dec 2019 11:38:15 +0100 (CET) Date: Wed, 4 Dec 2019 12:38:06 +0200 From: Laurent Pinchart To: Boris Brezillon Subject: Re: [PATCH v4 08/11] drm/bridge: Add a drm_bridge_state object Message-ID: <20191204103806.GD6705@pendragon.ideasonboard.com> References: <20191203141515.3597631-1-boris.brezillon@collabora.com> <20191203141515.3597631-9-boris.brezillon@collabora.com> <20191203181705.GT4730@pendragon.ideasonboard.com> <20191204100302.38096544@collabora.com> <20191204091255.GB6705@pendragon.ideasonboard.com> <20191204104207.38367944@collabora.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191204104207.38367944@collabora.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1575455896; bh=VYwRJOBjxh1800/WKysrFil7fftC0CbXVFmWz6HfoEg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nYNUlz4rM9JU3o4YMkEk4KMPylmWuw6KYLkdVB+mkhIffo3E1dnrgcYy4DpS/cGtU Py9TgpAhqAhVa3g8Fk4nA4QLi/JFiYFvgiv875y4s6oNT0pgasXvWTbaqcrI0e9tdw EpyXCl+nBxjN4iHOvMlwBeOvfl13FUpttkinZTWE= X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Neil Armstrong , dri-devel@lists.freedesktop.org, Thierry Reding , kernel@collabora.com, Sam Ravnborg , Nikita Yushchenko , Andrey Smirnov , Kyungmin Park , Chris Healy , devicetree@vger.kernel.org, Jonas Karlman , Rob Herring , Jernej Skrabec , Seung-Woo Kim Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" SGkgQm9yaXMsCgpPbiBXZWQsIERlYyAwNCwgMjAxOSBhdCAxMDo0MjowN0FNICswMTAwLCBCb3Jp cyBCcmV6aWxsb24gd3JvdGU6Cj4gT24gV2VkLCA0IERlYyAyMDE5IDExOjEyOjU1ICswMjAwIExh dXJlbnQgUGluY2hhcnQgd3JvdGU6Cj4gPiBPbiBXZWQsIERlYyAwNCwgMjAxOSBhdCAxMDowMzow MkFNICswMTAwLCBCb3JpcyBCcmV6aWxsb24gd3JvdGU6Cj4gPiA+IE9uIFR1ZSwgMyBEZWMgMjAx OSAyMDoxNzowNSArMDIwMCBMYXVyZW50IFBpbmNoYXJ0IHdyb3RlOiAgCj4gPiA+ID4gT24gVHVl LCBEZWMgMDMsIDIwMTkgYXQgMDM6MTU6MTJQTSArMDEwMCwgQm9yaXMgQnJlemlsbG9uIHdyb3Rl OiAgCj4gPiA+ID4gPiBPbmUgb2YgdGhlIGxhc3QgcmVtYWluaW5nIG9iamVjdHMgdG8gbm90IGhh dmUgaXRzIGF0b21pYyBzdGF0ZS4KPiA+ID4gPiA+IAo+ID4gPiA+ID4gVGhpcyBpcyBiZWluZyBt b3RpdmF0ZWQgYnkgb3VyIGF0dGVtcHQgdG8gc3VwcG9ydCBydW50aW1lIGJ1cy1mb3JtYXQKPiA+ ID4gPiA+IG5lZ290aWF0aW9uIGJldHdlZW4gZWxlbWVudHMgb2YgdGhlIGJyaWRnZSBjaGFpbi4K PiA+ID4gPiA+IFRoaXMgcGF0Y2gganVzdCBwYXZlcyB0aGUgcm9hZCBmb3Igc3VjaCBhIGZlYXR1 cmUgYnkgYWRkaW5nIGEgbmV3Cj4gPiA+ID4gPiBkcm1fYnJpZGdlX3N0YXRlIG9iamVjdCBpbmhl cml0aW5nIGZyb20gZHJtX3ByaXZhdGVfb2JqIHNvIHdlIGNhbgo+ID4gPiA+ID4gcmUtdXNlIHNv bWUgb2YgdGhlIGV4aXN0aW5nIHN0YXRlIGluaXRpYWxpemF0aW9uL3RyYWNraW5nIGxvZ2ljLgo+ ID4gPiA+ID4gCj4gPiA+ID4gPiBTaWduZWQtb2ZmLWJ5OiBCb3JpcyBCcmV6aWxsb24gPGJvcmlz LmJyZXppbGxvbkBjb2xsYWJvcmEuY29tPgo+ID4gPiA+ID4gUmV2aWV3ZWQtYnk6IE5laWwgQXJt c3Ryb25nIDxuYXJtc3Ryb25nQGJheWxpYnJlLmNvbT4KPiA+ID4gPiA+IC0tLQo+ID4gPiA+ID4g Q2hhbmdlcyBpbiB2NDoKPiA+ID4gPiA+ICogRml4IHRoZSBkb2MKPiA+ID4gPiA+ICogS2lsbCBk ZWZhdWx0IGhlbHBlcnMgKGlubGluZWQpICAgIAo+ID4gPiA+IAo+ID4gPiA+IEkgbGlrZWQgdGhl IGRlZmF1bHQgaGVscGVycywgaW5saW5pbmcgdGhlaXIgY29udGVudCBtYWtlcyB0aGUgY29kZSBt b3JlCj4gPiA+ID4gZGlmZmljdWx0IHRvIGZvbGxvdyBpbiBteSBvcGluaW9uLiAgCj4gPiA+IAo+ ID4gPiBJJ2xsIGdvIGJhY2sgdG8gdGhpcyBhcHByb2FjaCB0aGVuLiBTaG91bGQgSSBrZWVwIHRo ZSBvcmlnaW5hbCBoZWxwZXIKPiA+ID4gbmFtZXMgZXZlbiB0aG91Z2ggdGhleSdyZSBub3QgZ2xv YmFsbHkgdmlzaWJsZSAoYW5kIHNob3VsZCBwcm9iYWJseQo+ID4gPiBuZXZlciBiZSk/ICAKPiA+ IAo+ID4gSSBhZ3JlZSB0aGV5IHNob3VsZCBwcm9iYWJseSBuZXZlciBiZSB2aXNpYmxlLCBhbmQg SSB0cnVzdCB5b3VyCj4gPiBqdWRnZW1lbnQgb24gbmFtaW5nLiBQbGVhc2UgZG91YmxlLWNoZWNr IHRoZSBkb2N1bWVudGF0aW9uIHRob3VnaCwgdG8KPiA+IGVuc3VyZSB0aGF0IGl0IG1hdGNoZXMg dGhlIGltcGxlbWVudGF0aW9uLgo+IAo+IElzIHRoZXJlIGFueSBwb2ludCBrZWVwaW5nIHRoZSBk b2N1bWVudGF0aW9uIGlmIHRoZXkncmUgbm90IGV4cG9zZWQ/CgpJJ2xsIGxldCB5b3UgZGVjaWRl IG9uIHRoYXQsIGRlcGVuZGluZyBvbiBpZiB0aGUgZG9jdW1lbnRhdGlvbiBjb3VsZApicmluZyB2 YWx1ZSBvciBpZiB0aGUgZnVuY3Rpb25zIHdvdWxkIGJlIHNvIHRyaXZpYWwgdGhhdCBpdCB3b3Vs ZCBiZQpvdmVya2lsbC4KCi0tIApSZWdhcmRzLAoKTGF1cmVudCBQaW5jaGFydApfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBs aXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWw=