From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1A29C43603 for ; Wed, 4 Dec 2019 09:42:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7D18120637 for ; Wed, 4 Dec 2019 09:42:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725971AbfLDJmN (ORCPT ); Wed, 4 Dec 2019 04:42:13 -0500 Received: from bhuna.collabora.co.uk ([46.235.227.227]:48282 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725922AbfLDJmN (ORCPT ); Wed, 4 Dec 2019 04:42:13 -0500 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 5889C290EFA; Wed, 4 Dec 2019 09:42:10 +0000 (GMT) Date: Wed, 4 Dec 2019 10:42:07 +0100 From: Boris Brezillon To: Laurent Pinchart Cc: dri-devel@lists.freedesktop.org, Lucas Stach , Chris Healy , Andrey Smirnov , Nikita Yushchenko , kernel@collabora.com, Daniel Vetter , Inki Dae , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Thierry Reding , Sam Ravnborg , Philipp Zabel , Rob Clark , Andrzej Hajda , Neil Armstrong , Jonas Karlman , Jernej Skrabec , Rob Herring , Mark Rutland , devicetree@vger.kernel.org, Eric Anholt Subject: Re: [PATCH v4 08/11] drm/bridge: Add a drm_bridge_state object Message-ID: <20191204104207.38367944@collabora.com> In-Reply-To: <20191204091255.GB6705@pendragon.ideasonboard.com> References: <20191203141515.3597631-1-boris.brezillon@collabora.com> <20191203141515.3597631-9-boris.brezillon@collabora.com> <20191203181705.GT4730@pendragon.ideasonboard.com> <20191204100302.38096544@collabora.com> <20191204091255.GB6705@pendragon.ideasonboard.com> Organization: Collabora X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, 4 Dec 2019 11:12:55 +0200 Laurent Pinchart wrote: > Hi Boris, > > On Wed, Dec 04, 2019 at 10:03:02AM +0100, Boris Brezillon wrote: > > On Tue, 3 Dec 2019 20:17:05 +0200 Laurent Pinchart wrote: > > > On Tue, Dec 03, 2019 at 03:15:12PM +0100, Boris Brezillon wrote: > > > > One of the last remaining objects to not have its atomic state. > > > > > > > > This is being motivated by our attempt to support runtime bus-format > > > > negotiation between elements of the bridge chain. > > > > This patch just paves the road for such a feature by adding a new > > > > drm_bridge_state object inheriting from drm_private_obj so we can > > > > re-use some of the existing state initialization/tracking logic. > > > > > > > > Signed-off-by: Boris Brezillon > > > > Reviewed-by: Neil Armstrong > > > > --- > > > > Changes in v4: > > > > * Fix the doc > > > > * Kill default helpers (inlined) > > > > > > I liked the default helpers, inlining their content makes the code more > > > difficult to follow in my opinion. > > > > I'll go back to this approach then. Should I keep the original helper > > names even though they're not globally visible (and should probably > > never be)? > > I agree they should probably never be visible, and I trust your > judgement on naming. Please double-check the documentation though, to > ensure that it matches the implementation. > Is there any point keeping the documentation if they're not exposed? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67155C2BBE2 for ; Wed, 4 Dec 2019 09:42:15 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 44C0920637 for ; Wed, 4 Dec 2019 09:42:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 44C0920637 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 95CAF72B00; Wed, 4 Dec 2019 09:42:13 +0000 (UTC) Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7077772B00 for ; Wed, 4 Dec 2019 09:42:12 +0000 (UTC) Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 5889C290EFA; Wed, 4 Dec 2019 09:42:10 +0000 (GMT) Date: Wed, 4 Dec 2019 10:42:07 +0100 From: Boris Brezillon To: Laurent Pinchart Subject: Re: [PATCH v4 08/11] drm/bridge: Add a drm_bridge_state object Message-ID: <20191204104207.38367944@collabora.com> In-Reply-To: <20191204091255.GB6705@pendragon.ideasonboard.com> References: <20191203141515.3597631-1-boris.brezillon@collabora.com> <20191203141515.3597631-9-boris.brezillon@collabora.com> <20191203181705.GT4730@pendragon.ideasonboard.com> <20191204100302.38096544@collabora.com> <20191204091255.GB6705@pendragon.ideasonboard.com> Organization: Collabora X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Neil Armstrong , dri-devel@lists.freedesktop.org, Thierry Reding , kernel@collabora.com, Sam Ravnborg , Nikita Yushchenko , Andrey Smirnov , Kyungmin Park , Chris Healy , devicetree@vger.kernel.org, Jonas Karlman , Rob Herring , Jernej Skrabec , Seung-Woo Kim Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gV2VkLCA0IERlYyAyMDE5IDExOjEyOjU1ICswMjAwCkxhdXJlbnQgUGluY2hhcnQgPGxhdXJl bnQucGluY2hhcnRAaWRlYXNvbmJvYXJkLmNvbT4gd3JvdGU6Cgo+IEhpIEJvcmlzLAo+IAo+IE9u IFdlZCwgRGVjIDA0LCAyMDE5IGF0IDEwOjAzOjAyQU0gKzAxMDAsIEJvcmlzIEJyZXppbGxvbiB3 cm90ZToKPiA+IE9uIFR1ZSwgMyBEZWMgMjAxOSAyMDoxNzowNSArMDIwMCBMYXVyZW50IFBpbmNo YXJ0IHdyb3RlOiAgCj4gPiA+IE9uIFR1ZSwgRGVjIDAzLCAyMDE5IGF0IDAzOjE1OjEyUE0gKzAx MDAsIEJvcmlzIEJyZXppbGxvbiB3cm90ZTogIAo+ID4gPiA+IE9uZSBvZiB0aGUgbGFzdCByZW1h aW5pbmcgb2JqZWN0cyB0byBub3QgaGF2ZSBpdHMgYXRvbWljIHN0YXRlLgo+ID4gPiA+IAo+ID4g PiA+IFRoaXMgaXMgYmVpbmcgbW90aXZhdGVkIGJ5IG91ciBhdHRlbXB0IHRvIHN1cHBvcnQgcnVu dGltZSBidXMtZm9ybWF0Cj4gPiA+ID4gbmVnb3RpYXRpb24gYmV0d2VlbiBlbGVtZW50cyBvZiB0 aGUgYnJpZGdlIGNoYWluLgo+ID4gPiA+IFRoaXMgcGF0Y2gganVzdCBwYXZlcyB0aGUgcm9hZCBm b3Igc3VjaCBhIGZlYXR1cmUgYnkgYWRkaW5nIGEgbmV3Cj4gPiA+ID4gZHJtX2JyaWRnZV9zdGF0 ZSBvYmplY3QgaW5oZXJpdGluZyBmcm9tIGRybV9wcml2YXRlX29iaiBzbyB3ZSBjYW4KPiA+ID4g PiByZS11c2Ugc29tZSBvZiB0aGUgZXhpc3Rpbmcgc3RhdGUgaW5pdGlhbGl6YXRpb24vdHJhY2tp bmcgbG9naWMuCj4gPiA+ID4gCj4gPiA+ID4gU2lnbmVkLW9mZi1ieTogQm9yaXMgQnJlemlsbG9u IDxib3Jpcy5icmV6aWxsb25AY29sbGFib3JhLmNvbT4KPiA+ID4gPiBSZXZpZXdlZC1ieTogTmVp bCBBcm1zdHJvbmcgPG5hcm1zdHJvbmdAYmF5bGlicmUuY29tPgo+ID4gPiA+IC0tLQo+ID4gPiA+ IENoYW5nZXMgaW4gdjQ6Cj4gPiA+ID4gKiBGaXggdGhlIGRvYwo+ID4gPiA+ICogS2lsbCBkZWZh dWx0IGhlbHBlcnMgKGlubGluZWQpICAgIAo+ID4gPiAKPiA+ID4gSSBsaWtlZCB0aGUgZGVmYXVs dCBoZWxwZXJzLCBpbmxpbmluZyB0aGVpciBjb250ZW50IG1ha2VzIHRoZSBjb2RlIG1vcmUKPiA+ ID4gZGlmZmljdWx0IHRvIGZvbGxvdyBpbiBteSBvcGluaW9uLiAgCj4gPiAKPiA+IEknbGwgZ28g YmFjayB0byB0aGlzIGFwcHJvYWNoIHRoZW4uIFNob3VsZCBJIGtlZXAgdGhlIG9yaWdpbmFsIGhl bHBlcgo+ID4gbmFtZXMgZXZlbiB0aG91Z2ggdGhleSdyZSBub3QgZ2xvYmFsbHkgdmlzaWJsZSAo YW5kIHNob3VsZCBwcm9iYWJseQo+ID4gbmV2ZXIgYmUpPyAgCj4gCj4gSSBhZ3JlZSB0aGV5IHNo b3VsZCBwcm9iYWJseSBuZXZlciBiZSB2aXNpYmxlLCBhbmQgSSB0cnVzdCB5b3VyCj4ganVkZ2Vt ZW50IG9uIG5hbWluZy4gUGxlYXNlIGRvdWJsZS1jaGVjayB0aGUgZG9jdW1lbnRhdGlvbiB0aG91 Z2gsIHRvCj4gZW5zdXJlIHRoYXQgaXQgbWF0Y2hlcyB0aGUgaW1wbGVtZW50YXRpb24uCj4gCgpJ cyB0aGVyZSBhbnkgcG9pbnQga2VlcGluZyB0aGUgZG9jdW1lbnRhdGlvbiBpZiB0aGV5J3JlIG5v dCBleHBvc2VkPwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWw=