From mboxrd@z Thu Jan 1 00:00:00 1970 From: Miquel Raynal Subject: Re: [PATCH] arm64: dts: rockchip: Describe PX30 caches Date: Wed, 4 Dec 2019 16:44:35 +0100 Message-ID: <20191204164435.2dd1b4fe@xps13> References: <20191204103940.22050-1-miquel.raynal@bootlin.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Peter Geis Cc: Mark Rutland , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Heiko Stuebner , Maxime Chevallier , Paul Kocialkowski , "open list:ARM/Rockchip SoC..." , Rob Herring , Thomas Petazzoni List-Id: linux-rockchip.vger.kernel.org SGkgUGV0ZXIsCgpQZXRlciBHZWlzIDxwZ3dpcGVvdXRAZ21haWwuY29tPiB3cm90ZSBvbiBXZWQs IDQgRGVjIDIwMTkgMTA6MzY6MTkKLTA1MDA6Cgo+IE9uIFdlZCwgRGVjIDQsIDIwMTkgYXQgNTo0 MCBBTSBNaXF1ZWwgUmF5bmFsIDxtaXF1ZWwucmF5bmFsQGJvb3RsaW4uY29tPiB3cm90ZToKPiA+ Cj4gPiBQWDMwIFNvQ3MgZmVhdHVyZSA0IENvcnRleC1BMzUgQ1BVcyB3aXRoIGVhY2ggb2YgdGhl bSBhIEwxIGRhdGEgYW5kCj4gPiBpbnN0cnVjdGlvbiBjYWNoZS4gQm90aCBhcmUgMzJraUIgd2lk ZSAoUFgzMCBUUk0pIGFuZCBtYWRlIG9mIDY0LWJpdAo+ID4gbGluZXMgKEFSTSBDb3J0ZXgtQTM1 IG1hbnVhbCkuIEktY2FjaGUgaXMgMi13YXkgc2V0IGFzc29jaWF0aXZlIChBUk0KPiA+IENvcnRl eC1BMzUgbWFudWFsKSwgRC1jYWNoZSBpcyA0LXdheSBzZXQgYXNzb2NpYXRpdmUgKEFSTQo+ID4g Q29ydGV4LUEzNW1hbnVhbCkuCj4gPgo+ID4gQW4gTDIgY2FjaGUgaXMgcGxhY2VkIGFmdGVyIHRo ZXNlIDQgTDEgY2FjaGVzIChQWDMwIFRSTSksIGlzIDI1NmtpQgo+ID4gd2lkZSAoUFgzMCBUUk0p IGFuZCBtYWRlIG9mIDY0LWJpdCBsaW5lcyAoQVJNIENvcnRleC1BMzUgbWFudWFsKSBhbmQKPiA+ IGlzIDgtd2F5IHNldCBhc3NvY2lhdGl2ZSAoQVJNIENvcnRleC1BMzUgbWFudWFsKS4KPiA+Cj4g PiBEZXNjcmliZSBhbGwgb2YgdGhlbSBpbiB0aGUgUFgzMCBEVFNJLgo+ID4KPiA+IFNpZ25lZC1v ZmYtYnk6IE1pcXVlbCBSYXluYWwgPG1pcXVlbC5yYXluYWxAYm9vdGxpbi5jb20+Cj4gPiAtLS0K PiA+ICBhcmNoL2FybTY0L2Jvb3QvZHRzL3JvY2tjaGlwL3B4MzAuZHRzaSB8IDM1ICsrKysrKysr KysrKysrKysrKysrKysrKysrCj4gPiAgMSBmaWxlIGNoYW5nZWQsIDM1IGluc2VydGlvbnMoKykK PiA+Cj4gPiBkaWZmIC0tZ2l0IGEvYXJjaC9hcm02NC9ib290L2R0cy9yb2NrY2hpcC9weDMwLmR0 c2kgYi9hcmNoL2FybTY0L2Jvb3QvZHRzL3JvY2tjaGlwL3B4MzAuZHRzaQo+ID4gaW5kZXggMWZk MTJiZDA5ZTgzLi4wZTEwYTIyNGE4NGIgMTAwNjQ0Cj4gPiAtLS0gYS9hcmNoL2FybTY0L2Jvb3Qv ZHRzL3JvY2tjaGlwL3B4MzAuZHRzaQo+ID4gKysrIGIvYXJjaC9hcm02NC9ib290L2R0cy9yb2Nr Y2hpcC9weDMwLmR0c2kKPiA+IEBAIC00OCw2ICs0OCwxMyBAQAo+ID4gICAgICAgICAgICAgICAg ICAgICAgICAgY3B1LWlkbGUtc3RhdGVzID0gPCZDUFVfU0xFRVAgJkNMVVNURVJfU0xFRVA+Owo+ ID4gICAgICAgICAgICAgICAgICAgICAgICAgZHluYW1pYy1wb3dlci1jb2VmZmljaWVudCA9IDw5 MD47Cj4gPiAgICAgICAgICAgICAgICAgICAgICAgICBvcGVyYXRpbmctcG9pbnRzLXYyID0gPCZj cHUwX29wcF90YWJsZT47Cj4gPiArICAgICAgICAgICAgICAgICAgICAgICBpLWNhY2hlLXNpemUg PSA8MHg4MDAwPjsKPiA+ICsgICAgICAgICAgICAgICAgICAgICAgIGktY2FjaGUtbGluZS1zaXpl ID0gPDY0PjsKPiA+ICsgICAgICAgICAgICAgICAgICAgICAgIGktY2FjaGUtc2V0cyA9IDwyNTY+ Owo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgZC1jYWNoZS1zaXplID0gPDB4ODAwMD47Cj4g PiArICAgICAgICAgICAgICAgICAgICAgICBkLWNhY2hlLWxpbmUtc2l6ZSA9IDw2ND47Cj4gPiAr ICAgICAgICAgICAgICAgICAgICAgICBkLWNhY2hlLXNldHMgPSA8MTI4PjsKPiA+ICsgICAgICAg ICAgICAgICAgICAgICAgIG5leHQtbGV2ZWwtY2FjaGUgPSA8JmwyPjsgIAo+IAo+IElmIHRoZSBp LWNhY2hlIGlzIDItd2F5IGFzc29jaWF0aXZlIGFuZCB0aGUgZC1jYWNoZSBpcyA0LXdheSwgd291 bGRuJ3QKPiB0aGF0IG1lYW4gdGhlc2UgdHdvIHZhbHVlcyBhcmUgYmFja3dhcmRzPwoKV2hpY2gg dmFsdWUgYXJlIHlvdSByZWZlcnJpbmcgdG8/IERvIHlvdSBtZWFuIGNhY2hlLXNldHM/IFRoZSBm b2xsb3dpbmcKY2FsY3VsYXRpb24gaXMgbXkgdW5kZXJzdGFuZGluZyBvZiB0aGUgc2l0dWF0aW9u IGJ1dCBpdCBpcyB0aGUgZmlyc3QKdGltZSBJIGFtIGRvaW5nIGl0IHNvIEkgbWlnaHQgYmUgdG90 YWxseSB3cm9uZy4KCk15IHVuZGVyc3RhbmRpbmcgaXMgdGhhdCBpZiB0aGVyZSBhcmUgMzI3Njgg Y2FjaGUgYnl0ZXMgbWFkZSBvZiA2NC1ieXRlCmxpbmVzLCBzbyB0aGVyZSBhcmUgNTEyIGxpbmVz IGluIGJvdGggY2FzZXMuCgpUaGVuLCBpZiB0aGUgaW5zdHJ1Y3Rpb24gY2FjaGUgaXMgMi13YXkg YXNzb2NpYXRpdmUsIGl0IG1lYW5zIHRoZXJlIGFyZQo1MTIgLyAyID0gMjU2IHNldHMuIEZvciB0 aGUgZGF0YSBjYWNoZSAoNC13YXkpLCBpdCB3b3VsZCBiZSA1MTIgLyA0ID0KMTI4LiBBbSBJIHdy b25nPwoKVGhhbmtzLApNaXF1w6hsCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpMaW51eC1yb2NrY2hpcCBtYWlsaW5nIGxpc3QKTGludXgtcm9ja2NoaXBA bGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2xpbnV4LXJvY2tjaGlwCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4A36C43603 for ; Wed, 4 Dec 2019 15:44:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B124320833 for ; Wed, 4 Dec 2019 15:44:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728216AbfLDPoj convert rfc822-to-8bit (ORCPT ); Wed, 4 Dec 2019 10:44:39 -0500 Received: from relay12.mail.gandi.net ([217.70.178.232]:50439 "EHLO relay12.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727912AbfLDPoj (ORCPT ); Wed, 4 Dec 2019 10:44:39 -0500 Received: from xps13 (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 16C7F20000E; Wed, 4 Dec 2019 15:44:36 +0000 (UTC) Date: Wed, 4 Dec 2019 16:44:35 +0100 From: Miquel Raynal To: Peter Geis Cc: Heiko Stuebner , "open list:ARM/Rockchip SoC..." , Rob Herring , Mark Rutland , devicetree@vger.kernel.org, Paul Kocialkowski , Thomas Petazzoni , Maxime Chevallier Subject: Re: [PATCH] arm64: dts: rockchip: Describe PX30 caches Message-ID: <20191204164435.2dd1b4fe@xps13> In-Reply-To: References: <20191204103940.22050-1-miquel.raynal@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Peter, Peter Geis wrote on Wed, 4 Dec 2019 10:36:19 -0500: > On Wed, Dec 4, 2019 at 5:40 AM Miquel Raynal wrote: > > > > PX30 SoCs feature 4 Cortex-A35 CPUs with each of them a L1 data and > > instruction cache. Both are 32kiB wide (PX30 TRM) and made of 64-bit > > lines (ARM Cortex-A35 manual). I-cache is 2-way set associative (ARM > > Cortex-A35 manual), D-cache is 4-way set associative (ARM > > Cortex-A35manual). > > > > An L2 cache is placed after these 4 L1 caches (PX30 TRM), is 256kiB > > wide (PX30 TRM) and made of 64-bit lines (ARM Cortex-A35 manual) and > > is 8-way set associative (ARM Cortex-A35 manual). > > > > Describe all of them in the PX30 DTSI. > > > > Signed-off-by: Miquel Raynal > > --- > > arch/arm64/boot/dts/rockchip/px30.dtsi | 35 ++++++++++++++++++++++++++ > > 1 file changed, 35 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/rockchip/px30.dtsi b/arch/arm64/boot/dts/rockchip/px30.dtsi > > index 1fd12bd09e83..0e10a224a84b 100644 > > --- a/arch/arm64/boot/dts/rockchip/px30.dtsi > > +++ b/arch/arm64/boot/dts/rockchip/px30.dtsi > > @@ -48,6 +48,13 @@ > > cpu-idle-states = <&CPU_SLEEP &CLUSTER_SLEEP>; > > dynamic-power-coefficient = <90>; > > operating-points-v2 = <&cpu0_opp_table>; > > + i-cache-size = <0x8000>; > > + i-cache-line-size = <64>; > > + i-cache-sets = <256>; > > + d-cache-size = <0x8000>; > > + d-cache-line-size = <64>; > > + d-cache-sets = <128>; > > + next-level-cache = <&l2>; > > If the i-cache is 2-way associative and the d-cache is 4-way, wouldn't > that mean these two values are backwards? Which value are you referring to? Do you mean cache-sets? The following calculation is my understanding of the situation but it is the first time I am doing it so I might be totally wrong. My understanding is that if there are 32768 cache bytes made of 64-byte lines, so there are 512 lines in both cases. Then, if the instruction cache is 2-way associative, it means there are 512 / 2 = 256 sets. For the data cache (4-way), it would be 512 / 4 = 128. Am I wrong? Thanks, Miquèl