From mboxrd@z Thu Jan 1 00:00:00 1970 From: Miquel Raynal Subject: Re: [PATCH] arm64: dts: rockchip: Describe PX30 caches Date: Wed, 4 Dec 2019 18:17:06 +0100 Message-ID: <20191204181706.0421c4f7@xps13> References: <20191204103940.22050-1-miquel.raynal@bootlin.com> <20191204164435.2dd1b4fe@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Peter Geis Cc: Mark Rutland , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Heiko Stuebner , Maxime Chevallier , Paul Kocialkowski , "open list:ARM/Rockchip SoC..." , Rob Herring , Thomas Petazzoni List-Id: linux-rockchip.vger.kernel.org SGkgUGV0ZXIsCgpQZXRlciBHZWlzIDxwZ3dpcGVvdXRAZ21haWwuY29tPiB3cm90ZSBvbiBXZWQs IDQgRGVjIDIwMTkgMTI6MTQ6NDAKLTA1MDA6Cgo+IE9uIFdlZCwgRGVjIDQsIDIwMTkgYXQgMTA6 NDQgQU0gTWlxdWVsIFJheW5hbCA8bWlxdWVsLnJheW5hbEBib290bGluLmNvbT4gd3JvdGU6Cj4g Pgo+ID4gSGkgUGV0ZXIsCj4gPgo+ID4gUGV0ZXIgR2VpcyA8cGd3aXBlb3V0QGdtYWlsLmNvbT4g d3JvdGUgb24gV2VkLCA0IERlYyAyMDE5IDEwOjM2OjE5Cj4gPiAtMDUwMDoKPiA+ICAKPiA+ID4g T24gV2VkLCBEZWMgNCwgMjAxOSBhdCA1OjQwIEFNIE1pcXVlbCBSYXluYWwgPG1pcXVlbC5yYXlu YWxAYm9vdGxpbi5jb20+IHdyb3RlOiAgCj4gPiA+ID4KPiA+ID4gPiBQWDMwIFNvQ3MgZmVhdHVy ZSA0IENvcnRleC1BMzUgQ1BVcyB3aXRoIGVhY2ggb2YgdGhlbSBhIEwxIGRhdGEgYW5kCj4gPiA+ ID4gaW5zdHJ1Y3Rpb24gY2FjaGUuIEJvdGggYXJlIDMya2lCIHdpZGUgKFBYMzAgVFJNKSBhbmQg bWFkZSBvZiA2NC1iaXQKPiA+ID4gPiBsaW5lcyAoQVJNIENvcnRleC1BMzUgbWFudWFsKS4gSS1j YWNoZSBpcyAyLXdheSBzZXQgYXNzb2NpYXRpdmUgKEFSTQo+ID4gPiA+IENvcnRleC1BMzUgbWFu dWFsKSwgRC1jYWNoZSBpcyA0LXdheSBzZXQgYXNzb2NpYXRpdmUgKEFSTQo+ID4gPiA+IENvcnRl eC1BMzVtYW51YWwpLgo+ID4gPiA+Cj4gPiA+ID4gQW4gTDIgY2FjaGUgaXMgcGxhY2VkIGFmdGVy IHRoZXNlIDQgTDEgY2FjaGVzIChQWDMwIFRSTSksIGlzIDI1NmtpQgo+ID4gPiA+IHdpZGUgKFBY MzAgVFJNKSBhbmQgbWFkZSBvZiA2NC1iaXQgbGluZXMgKEFSTSBDb3J0ZXgtQTM1IG1hbnVhbCkg YW5kCj4gPiA+ID4gaXMgOC13YXkgc2V0IGFzc29jaWF0aXZlIChBUk0gQ29ydGV4LUEzNSBtYW51 YWwpLgo+ID4gPiA+Cj4gPiA+ID4gRGVzY3JpYmUgYWxsIG9mIHRoZW0gaW4gdGhlIFBYMzAgRFRT SS4KPiA+ID4gPgo+ID4gPiA+IFNpZ25lZC1vZmYtYnk6IE1pcXVlbCBSYXluYWwgPG1pcXVlbC5y YXluYWxAYm9vdGxpbi5jb20+Cj4gPiA+ID4gLS0tCj4gPiA+ID4gIGFyY2gvYXJtNjQvYm9vdC9k dHMvcm9ja2NoaXAvcHgzMC5kdHNpIHwgMzUgKysrKysrKysrKysrKysrKysrKysrKysrKysKPiA+ ID4gPiAgMSBmaWxlIGNoYW5nZWQsIDM1IGluc2VydGlvbnMoKykKPiA+ID4gPgo+ID4gPiA+IGRp ZmYgLS1naXQgYS9hcmNoL2FybTY0L2Jvb3QvZHRzL3JvY2tjaGlwL3B4MzAuZHRzaSBiL2FyY2gv YXJtNjQvYm9vdC9kdHMvcm9ja2NoaXAvcHgzMC5kdHNpCj4gPiA+ID4gaW5kZXggMWZkMTJiZDA5 ZTgzLi4wZTEwYTIyNGE4NGIgMTAwNjQ0Cj4gPiA+ID4gLS0tIGEvYXJjaC9hcm02NC9ib290L2R0 cy9yb2NrY2hpcC9weDMwLmR0c2kKPiA+ID4gPiArKysgYi9hcmNoL2FybTY0L2Jvb3QvZHRzL3Jv Y2tjaGlwL3B4MzAuZHRzaQo+ID4gPiA+IEBAIC00OCw2ICs0OCwxMyBAQAo+ID4gPiA+ICAgICAg ICAgICAgICAgICAgICAgICAgIGNwdS1pZGxlLXN0YXRlcyA9IDwmQ1BVX1NMRUVQICZDTFVTVEVS X1NMRUVQPjsKPiA+ID4gPiAgICAgICAgICAgICAgICAgICAgICAgICBkeW5hbWljLXBvd2VyLWNv ZWZmaWNpZW50ID0gPDkwPjsKPiA+ID4gPiAgICAgICAgICAgICAgICAgICAgICAgICBvcGVyYXRp bmctcG9pbnRzLXYyID0gPCZjcHUwX29wcF90YWJsZT47Cj4gPiA+ID4gKyAgICAgICAgICAgICAg ICAgICAgICAgaS1jYWNoZS1zaXplID0gPDB4ODAwMD47Cj4gPiA+ID4gKyAgICAgICAgICAgICAg ICAgICAgICAgaS1jYWNoZS1saW5lLXNpemUgPSA8NjQ+Owo+ID4gPiA+ICsgICAgICAgICAgICAg ICAgICAgICAgIGktY2FjaGUtc2V0cyA9IDwyNTY+Owo+ID4gPiA+ICsgICAgICAgICAgICAgICAg ICAgICAgIGQtY2FjaGUtc2l6ZSA9IDwweDgwMDA+Owo+ID4gPiA+ICsgICAgICAgICAgICAgICAg ICAgICAgIGQtY2FjaGUtbGluZS1zaXplID0gPDY0PjsKPiA+ID4gPiArICAgICAgICAgICAgICAg ICAgICAgICBkLWNhY2hlLXNldHMgPSA8MTI4PjsKPiA+ID4gPiArICAgICAgICAgICAgICAgICAg ICAgICBuZXh0LWxldmVsLWNhY2hlID0gPCZsMj47ICAKPiA+ID4KPiA+ID4gSWYgdGhlIGktY2Fj aGUgaXMgMi13YXkgYXNzb2NpYXRpdmUgYW5kIHRoZSBkLWNhY2hlIGlzIDQtd2F5LCB3b3VsZG4n dAo+ID4gPiB0aGF0IG1lYW4gdGhlc2UgdHdvIHZhbHVlcyBhcmUgYmFja3dhcmRzPyAgCj4gPgo+ ID4gV2hpY2ggdmFsdWUgYXJlIHlvdSByZWZlcnJpbmcgdG8/IERvIHlvdSBtZWFuIGNhY2hlLXNl dHM/IFRoZSBmb2xsb3dpbmcKPiA+IGNhbGN1bGF0aW9uIGlzIG15IHVuZGVyc3RhbmRpbmcgb2Yg dGhlIHNpdHVhdGlvbiBidXQgaXQgaXMgdGhlIGZpcnN0Cj4gPiB0aW1lIEkgYW0gZG9pbmcgaXQg c28gSSBtaWdodCBiZSB0b3RhbGx5IHdyb25nLgo+ID4KPiA+IE15IHVuZGVyc3RhbmRpbmcgaXMg dGhhdCBpZiB0aGVyZSBhcmUgMzI3NjggY2FjaGUgYnl0ZXMgbWFkZSBvZiA2NC1ieXRlCj4gPiBs aW5lcywgc28gdGhlcmUgYXJlIDUxMiBsaW5lcyBpbiBib3RoIGNhc2VzLgo+ID4KPiA+IFRoZW4s IGlmIHRoZSBpbnN0cnVjdGlvbiBjYWNoZSBpcyAyLXdheSBhc3NvY2lhdGl2ZSwgaXQgbWVhbnMg dGhlcmUgYXJlCj4gPiA1MTIgLyAyID0gMjU2IHNldHMuIEZvciB0aGUgZGF0YSBjYWNoZSAoNC13 YXkpLCBpdCB3b3VsZCBiZSA1MTIgLyA0ID0KPiA+IDEyOC4gQW0gSSB3cm9uZz8gIAo+IAo+IEFw b2xvZ2llcywgeW91IGFyZSBjb3JyZWN0LCBpdCB3YXMgSSB3aG8gd2FzIG1pc3Rha2VuLgoKTm8g cHJvYmxlbSwgSSB3YXMgbm90IDEwMCUgc3VyZSBlaXRoZXIuIFRoYW5rcyBmb3IgdGhlIHJldmll dyBhbnl3YXkhCgpDaGVlcnMsCk1pcXXDqGwKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCkxpbnV4LXJvY2tjaGlwIG1haWxpbmcgbGlzdApMaW51eC1yb2Nr Y2hpcEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxt YW4vbGlzdGluZm8vbGludXgtcm9ja2NoaXAK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D81C2C43603 for ; Wed, 4 Dec 2019 17:17:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B36C3207DD for ; Wed, 4 Dec 2019 17:17:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727852AbfLDRRL convert rfc822-to-8bit (ORCPT ); Wed, 4 Dec 2019 12:17:11 -0500 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:35719 "EHLO relay1-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727889AbfLDRRL (ORCPT ); Wed, 4 Dec 2019 12:17:11 -0500 X-Originating-IP: 91.224.148.103 Received: from xps13 (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id C0461240006; Wed, 4 Dec 2019 17:17:07 +0000 (UTC) Date: Wed, 4 Dec 2019 18:17:06 +0100 From: Miquel Raynal To: Peter Geis Cc: Heiko Stuebner , "open list:ARM/Rockchip SoC..." , Rob Herring , Mark Rutland , devicetree@vger.kernel.org, Paul Kocialkowski , Thomas Petazzoni , Maxime Chevallier Subject: Re: [PATCH] arm64: dts: rockchip: Describe PX30 caches Message-ID: <20191204181706.0421c4f7@xps13> In-Reply-To: References: <20191204103940.22050-1-miquel.raynal@bootlin.com> <20191204164435.2dd1b4fe@xps13> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Peter, Peter Geis wrote on Wed, 4 Dec 2019 12:14:40 -0500: > On Wed, Dec 4, 2019 at 10:44 AM Miquel Raynal wrote: > > > > Hi Peter, > > > > Peter Geis wrote on Wed, 4 Dec 2019 10:36:19 > > -0500: > > > > > On Wed, Dec 4, 2019 at 5:40 AM Miquel Raynal wrote: > > > > > > > > PX30 SoCs feature 4 Cortex-A35 CPUs with each of them a L1 data and > > > > instruction cache. Both are 32kiB wide (PX30 TRM) and made of 64-bit > > > > lines (ARM Cortex-A35 manual). I-cache is 2-way set associative (ARM > > > > Cortex-A35 manual), D-cache is 4-way set associative (ARM > > > > Cortex-A35manual). > > > > > > > > An L2 cache is placed after these 4 L1 caches (PX30 TRM), is 256kiB > > > > wide (PX30 TRM) and made of 64-bit lines (ARM Cortex-A35 manual) and > > > > is 8-way set associative (ARM Cortex-A35 manual). > > > > > > > > Describe all of them in the PX30 DTSI. > > > > > > > > Signed-off-by: Miquel Raynal > > > > --- > > > > arch/arm64/boot/dts/rockchip/px30.dtsi | 35 ++++++++++++++++++++++++++ > > > > 1 file changed, 35 insertions(+) > > > > > > > > diff --git a/arch/arm64/boot/dts/rockchip/px30.dtsi b/arch/arm64/boot/dts/rockchip/px30.dtsi > > > > index 1fd12bd09e83..0e10a224a84b 100644 > > > > --- a/arch/arm64/boot/dts/rockchip/px30.dtsi > > > > +++ b/arch/arm64/boot/dts/rockchip/px30.dtsi > > > > @@ -48,6 +48,13 @@ > > > > cpu-idle-states = <&CPU_SLEEP &CLUSTER_SLEEP>; > > > > dynamic-power-coefficient = <90>; > > > > operating-points-v2 = <&cpu0_opp_table>; > > > > + i-cache-size = <0x8000>; > > > > + i-cache-line-size = <64>; > > > > + i-cache-sets = <256>; > > > > + d-cache-size = <0x8000>; > > > > + d-cache-line-size = <64>; > > > > + d-cache-sets = <128>; > > > > + next-level-cache = <&l2>; > > > > > > If the i-cache is 2-way associative and the d-cache is 4-way, wouldn't > > > that mean these two values are backwards? > > > > Which value are you referring to? Do you mean cache-sets? The following > > calculation is my understanding of the situation but it is the first > > time I am doing it so I might be totally wrong. > > > > My understanding is that if there are 32768 cache bytes made of 64-byte > > lines, so there are 512 lines in both cases. > > > > Then, if the instruction cache is 2-way associative, it means there are > > 512 / 2 = 256 sets. For the data cache (4-way), it would be 512 / 4 = > > 128. Am I wrong? > > Apologies, you are correct, it was I who was mistaken. No problem, I was not 100% sure either. Thanks for the review anyway! Cheers, Miquèl