From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v6 1/3] cmd: nand/sf: isolate legacy code
Date: Wed, 4 Dec 2019 21:53:07 -0500 [thread overview]
Message-ID: <20191205025307.GG9549@bill-the-cat> (raw)
In-Reply-To: <20191025173931.10693-2-miquel.raynal@bootlin.com>
On Fri, Oct 25, 2019 at 07:39:29PM +0200, Miquel Raynal wrote:
> The 'sf' command is not supposed to rely on the MTD stack, but both
> 'sf' and 'nand' commands use helpers located in mtd_uboot.c. Despite
> their location, these functions do not depend at all on the MTD
> stack.
>
> This file (drivers/mtd/mtd_uboot.c) is only compiled if CONFIG_MTD is
> selected, which is inconsistent with the current situation. Solve this
> by moving these three functions (which are only used by the above two
> commands) out of mtd_uboot.c and put them in a C file only compiled
> with cmd/sf.c and cmd/nand.c.
>
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20191204/c27fa452/attachment.sig>
next prev parent reply other threads:[~2019-12-05 2:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-25 17:39 [U-Boot] [PATCH v6 0/3] End of the MTD makefile cleanup Miquel Raynal
2019-10-25 17:39 ` [U-Boot] [PATCH v6 1/3] cmd: nand/sf: isolate legacy code Miquel Raynal
2019-12-05 2:53 ` Tom Rini [this message]
2019-10-25 17:39 ` [U-Boot] [PATCH v6 2/3] cmd: make MTD commands depend on MTD Miquel Raynal
2019-12-05 2:53 ` Tom Rini
2019-10-25 17:39 ` [U-Boot] [PATCH v6 3/3] mtd: Makefile: deep cleanup Miquel Raynal
2019-12-05 2:53 ` Tom Rini
2019-10-26 10:20 ` [U-Boot] [PATCH v6 0/3] End of the MTD makefile cleanup Jagan Teki
2019-10-26 22:03 ` Miquel Raynal
2019-10-27 11:53 ` Jagan Teki
2019-10-27 14:06 ` Tom Rini
2019-10-27 14:24 ` Jagan Teki
2019-10-27 14:40 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191205025307.GG9549@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.