All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Shyti <andi.shyti@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915/gem: Reinitialise the local list before repeating
Date: Thu, 5 Dec 2019 16:23:28 +0200	[thread overview]
Message-ID: <20191205142328.GA13401@intel.intel> (raw)
In-Reply-To: <20191205132912.606868-1-chris@chris-wilson.co.uk>

Hi Chris,

On Thu, Dec 05, 2019 at 01:29:12PM +0000, Chris Wilson wrote:
> As we may start the loop again, we require our local list of i915_vma
> we've processed to be reinitialised.
> 
> Fixes: aa5e4453dc05 ("drm/i915/gem: Try to flush pending unbind events")
> Closes: https://gitlab.freedesktop.org/drm/intel/issues/731
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
>  drivers/gpu/drm/i915/i915_gem.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
> index cc8c6960b689..98b65b718e1a 100644
> --- a/drivers/gpu/drm/i915/i915_gem.c
> +++ b/drivers/gpu/drm/i915/i915_gem.c
> @@ -175,7 +175,7 @@ int i915_gem_object_unbind(struct drm_i915_gem_object *obj,
>  		i915_vm_close(vm);
>  		spin_lock(&obj->vma.lock);
>  	}
> -	list_splice(&still_in_list, &obj->vma.list);
> +	list_splice_init(&still_in_list, &obj->vma.list);

Reviewed-by: Andi Shyti <andi.shyti@intel.com>

Thanks,
Andi
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2019-12-05 14:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-05 13:29 [Intel-gfx] [PATCH] drm/i915/gem: Reinitialise the local list before repeating Chris Wilson
2019-12-05 14:23 ` Andi Shyti [this message]
2019-12-05 15:18 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191205142328.GA13401@intel.intel \
    --to=andi.shyti@intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.