From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD3D7C43603 for ; Thu, 5 Dec 2019 18:29:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B43CC22525 for ; Thu, 5 Dec 2019 18:29:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729804AbfLES3d (ORCPT ); Thu, 5 Dec 2019 13:29:33 -0500 Received: from asavdk4.altibox.net ([109.247.116.15]:57490 "EHLO asavdk4.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726028AbfLES3d (ORCPT ); Thu, 5 Dec 2019 13:29:33 -0500 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id 8F92380697; Thu, 5 Dec 2019 19:29:29 +0100 (CET) Date: Thu, 5 Dec 2019 19:29:27 +0100 From: Sam Ravnborg To: Mihail Atanassov Cc: "dri-devel@lists.freedesktop.org" , Jernej Skrabec , Neil Armstrong , David Airlie , Daniel Vetter , Jonas Karlman , "linux-kernel@vger.kernel.org" , Laurent Pinchart , nd Subject: Re: [PATCH] drm: Rename drm_bridge->dev to drm Message-ID: <20191205182927.GA27091@ravnborg.org> References: <20191205163028.19941-1-mihail.atanassov@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191205163028.19941-1-mihail.atanassov@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=VcLZwmh9 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=7gkXJVJtAAAA:8 a=oBCgqzsU5Q40nlY60G0A:9 a=CjuIK1q_8ugA:10 a=E9Po1WZjFZOl8hwRPBS3:22 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mihail. On Thu, Dec 05, 2019 at 04:30:45PM +0000, Mihail Atanassov wrote: > The 'dev' name causes some confusion with 'struct device' [1][2], so use > 'drm' instead since this seems to be the prevalent name for 'struct > drm_device' members. Thanks for doing this - it helps readability. checkpatch complained: -:107: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #107: FILE: drivers/gpu/drm/bridge/nxp-ptn3460.c:251: + ret = drm_connector_init(bridge->drm, &ptn_bridge->connector, &ptn3460_connector_funcs, DRM_MODE_CONNECTOR_LVDS); -:133: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #133: FILE: drivers/gpu/drm/bridge/parade-ps8622.c:491: + ret = drm_connector_init(bridge->drm, &ps8622->connector, &ps8622_connector_funcs, DRM_MODE_CONNECTOR_LVDS); But this seems unrelated to your changes - so should be ignored. Browsed the patch and throw it after my build check script. All looked good. Acked-by: Sam Ravnborg Sam From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64D94C43603 for ; Thu, 5 Dec 2019 18:29:35 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4486F22525 for ; Thu, 5 Dec 2019 18:29:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4486F22525 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C9A356F8DE; Thu, 5 Dec 2019 18:29:34 +0000 (UTC) Received: from asavdk4.altibox.net (asavdk4.altibox.net [109.247.116.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2F60D6F8DE for ; Thu, 5 Dec 2019 18:29:33 +0000 (UTC) Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id 8F92380697; Thu, 5 Dec 2019 19:29:29 +0100 (CET) Date: Thu, 5 Dec 2019 19:29:27 +0100 From: Sam Ravnborg To: Mihail Atanassov Subject: Re: [PATCH] drm: Rename drm_bridge->dev to drm Message-ID: <20191205182927.GA27091@ravnborg.org> References: <20191205163028.19941-1-mihail.atanassov@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191205163028.19941-1-mihail.atanassov@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=VcLZwmh9 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=7gkXJVJtAAAA:8 a=oBCgqzsU5Q40nlY60G0A:9 a=CjuIK1q_8ugA:10 a=E9Po1WZjFZOl8hwRPBS3:22 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jernej Skrabec , Jonas Karlman , David Airlie , Daniel Vetter , Neil Armstrong , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , Laurent Pinchart , nd Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" SGkgTWloYWlsLgoKT24gVGh1LCBEZWMgMDUsIDIwMTkgYXQgMDQ6MzA6NDVQTSArMDAwMCwgTWlo YWlsIEF0YW5hc3NvdiB3cm90ZToKPiBUaGUgJ2RldicgbmFtZSBjYXVzZXMgc29tZSBjb25mdXNp b24gd2l0aCAnc3RydWN0IGRldmljZScgWzFdWzJdLCBzbyB1c2UKPiAnZHJtJyBpbnN0ZWFkIHNp bmNlIHRoaXMgc2VlbXMgdG8gYmUgdGhlIHByZXZhbGVudCBuYW1lIGZvciAnc3RydWN0Cj4gZHJt X2RldmljZScgbWVtYmVycy4KVGhhbmtzIGZvciBkb2luZyB0aGlzIC0gaXQgaGVscHMgcmVhZGFi aWxpdHkuCgpjaGVja3BhdGNoIGNvbXBsYWluZWQ6CgotOjEwNzogQ0hFQ0s6UEFSRU5USEVTSVNf QUxJR05NRU5UOiBBbGlnbm1lbnQgc2hvdWxkIG1hdGNoIG9wZW4gcGFyZW50aGVzaXMKIzEwNzog RklMRTogZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9ueHAtcHRuMzQ2MC5jOjI1MToKKwlyZXQgPSBk cm1fY29ubmVjdG9yX2luaXQoYnJpZGdlLT5kcm0sICZwdG5fYnJpZGdlLT5jb25uZWN0b3IsCiAJ CQkmcHRuMzQ2MF9jb25uZWN0b3JfZnVuY3MsIERSTV9NT0RFX0NPTk5FQ1RPUl9MVkRTKTsKCi06 MTMzOiBDSEVDSzpQQVJFTlRIRVNJU19BTElHTk1FTlQ6IEFsaWdubWVudCBzaG91bGQgbWF0Y2gg b3BlbiBwYXJlbnRoZXNpcwojMTMzOiBGSUxFOiBkcml2ZXJzL2dwdS9kcm0vYnJpZGdlL3BhcmFk ZS1wczg2MjIuYzo0OTE6CisJcmV0ID0gZHJtX2Nvbm5lY3Rvcl9pbml0KGJyaWRnZS0+ZHJtLCAm cHM4NjIyLT5jb25uZWN0b3IsCiAJCQkmcHM4NjIyX2Nvbm5lY3Rvcl9mdW5jcywgRFJNX01PREVf Q09OTkVDVE9SX0xWRFMpOwoKQnV0IHRoaXMgc2VlbXMgdW5yZWxhdGVkIHRvIHlvdXIgY2hhbmdl cyAtIHNvIHNob3VsZCBiZSBpZ25vcmVkLgoKCkJyb3dzZWQgdGhlIHBhdGNoIGFuZCB0aHJvdyBp dCBhZnRlciBteSBidWlsZCBjaGVjayBzY3JpcHQuCkFsbCBsb29rZWQgZ29vZC4KCkFja2VkLWJ5 OiBTYW0gUmF2bmJvcmcgPHNhbUByYXZuYm9yZy5vcmc+CgoJU2FtCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJp LWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbA==