From: Al Viro <viro@zeniv.linux.org.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Ritesh Harjani <riteshh@linux.ibm.com>
Subject: Re: [git pull] vfs.git d_inode/d_flags barriers
Date: Fri, 6 Dec 2019 02:28:51 +0000 [thread overview]
Message-ID: <20191206022851.GM4203@ZenIV.linux.org.uk> (raw)
In-Reply-To: <CAHk-=wgPd1dYZjywZqPYZP-7dD2ihwviYfYLY3i+K=OLk2ZozQ@mail.gmail.com>
On Thu, Dec 05, 2019 at 06:15:54PM -0800, Linus Torvalds wrote:
> On Thu, Dec 5, 2019 at 5:38 PM Al Viro <viro@zeniv.linux.org.uk> wrote:
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git fixes
>
> I'm not pulling this.
>
> Commit 6c2d4798a8d1 ("new helper: lookup_positive_unlocked()") results
> in a new - and valid - compiler warning:
>
> fs/quota/dquot.c: In function ‘dquot_quota_on_mount’:
> fs/quota/dquot.c:2499:1: warning: label ‘out’ defined but not used
> [-Wunused-label]
> 2499 | out:
> | ^~~
>
> and I don't want to see new warnings in my tree.
>
> I wish linux-next would complain about warnings (assuming this had
> been there), because they aren't ok.
Fixed... Could you pull #fixes1 instead? diff is literally removal of one
line; updated shortlog/diffstat follows:
The following changes since commit 3e5aeec0e267d4422a4e740ce723549a3098a4d1:
cramfs: fix usage on non-MTD device (2019-11-23 21:44:49 -0500)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git fixes1
for you to fetch changes up to 7fcd59b64a7b69718cc851865a1578138b481541:
fs/namei.c: fix missing barriers when checking positivity (2019-12-05 21:04:35 -0500)
----------------------------------------------------------------
Al Viro (4):
fs/namei.c: pull positivity check into follow_managed()
new helper: lookup_positive_unlocked()
fix dget_parent() fastpath race
fs/namei.c: fix missing barriers when checking positivity
fs/cifs/cifsfs.c | 7 +------
fs/dcache.c | 6 ++++--
fs/debugfs/inode.c | 6 +-----
fs/kernfs/mount.c | 2 +-
fs/namei.c | 56 ++++++++++++++++++++++++++++----------------------
fs/nfsd/nfs3xdr.c | 4 +---
fs/nfsd/nfs4xdr.c | 11 +---------
fs/overlayfs/namei.c | 24 ++++++++--------------
fs/quota/dquot.c | 8 +-------
include/linux/dcache.h | 5 +++++
include/linux/namei.h | 1 +
11 files changed, 56 insertions(+), 74 deletions(-)
next prev parent reply other threads:[~2019-12-06 2:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-06 1:38 [git pull] vfs.git d_inode/d_flags barriers Al Viro
2019-12-06 2:15 ` Linus Torvalds
2019-12-06 2:28 ` Al Viro [this message]
2019-12-07 2:08 ` Stephen Rothwell
2019-12-06 19:25 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191206022851.GM4203@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=riteshh@linux.ibm.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.