All of lore.kernel.org
 help / color / mirror / Atom feed
From: 'Greg KH' <gregkh@linuxfoundation.org>
To: "������/HYUN-KI KOO" <hyunki00.koo@samsung.com>
Cc: 'Krzysztof Kozlowski' <krzk@kernel.org>,
	'Hyunki Koo' <kkoos00@naver.com>,
	jslaby@suse.com, linux-serial@vger.kernel.org,
	linux-kernel@vger.kernel.org, kkoos00@gmail.com,
	'Shinbeom Choi' <sbeom.choi@samsung.com>
Subject: Re: [PATCH] tty: serial: samsung: support driver modulization
Date: Fri, 6 Dec 2019 07:40:20 +0100	[thread overview]
Message-ID: <20191206064020.GA1318959@kroah.com> (raw)
In-Reply-To: <000001d5abd6$ae5a6b50$0b0f41f0$@samsung.com>


A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top

On Fri, Dec 06, 2019 at 10:44:20AM +0900, ������/HYUN-KI KOO wrote:
> To support module for Samsung serial driver,
> I would like to split the file into 2 files.

But you did not do that here in this patch, right?

> Because it cannot be supported in one file both early console and
> module driver
> Thus some function need to change to EXPORT_SYMBOL to use in module
> driver file.
> I'm not pushed yet for module driver.

I do not understand, this patch feels wrong and incomplete as-is, right?
Please fix it up to work properly.

thanks,

greg k-h

  reply	other threads:[~2019-12-06  6:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20191201075914.23512-1-kkoos00@naver.com>
2019-12-01  8:03 ` [PATCH] tty: serial: samsung: support driver modulization Greg KH
2019-12-05 15:36   ` Krzysztof Kozlowski
2019-12-05 16:02     ` Greg KH
2019-12-06  1:44       ` 구현기/HYUN-KI KOO
2019-12-06  6:40         ` 'Greg KH' [this message]
2019-12-06  8:09         ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191206064020.GA1318959@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=hyunki00.koo@samsung.com \
    --cc=jslaby@suse.com \
    --cc=kkoos00@gmail.com \
    --cc=kkoos00@naver.com \
    --cc=krzk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=sbeom.choi@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.