All of lore.kernel.org
 help / color / mirror / Atom feed
From: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: Ingo Molnar <mingo@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Mel Gorman <mgorman@techsingularity.net>,
	Rik van Riel <riel@surriel.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Valentin Schneider <valentin.schneider@arm.com>
Subject: Re: [PATCH] sched/fair: Optimize select_idle_core
Date: Fri, 6 Dec 2019 19:09:30 +0530	[thread overview]
Message-ID: <20191206133930.GA25024@linux.vnet.ibm.com> (raw)
In-Reply-To: <CAKfTPtBOVe+-fMBd+oHxZ51q5GtaxR6uyYep+a+NWJArbV9EcQ@mail.gmail.com>

Hi Vincent,

> >
> > Collecting ticks on a Power 9 SMT 8 system around select_idle_core
> > while running schbench shows us that
> >
> > (units are in ticks, hence lesser is better)
> > Without patch
> >     N           Min           Max        Median           Avg        Stddev
> > x 130           151          1083           284     322.72308     144.41494
> >
> >
> > With patch
> >     N           Min           Max        Median           Avg        Stddev   Improvement
> > x 164            88           610           201     225.79268     106.78943        30.03%
> 
> Thanks for the figures. Might be good to include them in the commit message
> 

Since I needed a debug/hack patch on top of upstream/my-patch to get these
numbers, I wasn't sure if this would be ideal to be included in a commit
message. But if you still think it's good to have, I can re-spin the patch
with these numbers included.

> Reviewed-by: Vincent Guittot <vincent.guittot@linaro.org>
>

Thanks.

-- 
Thanks and Regards
Srikar Dronamraju


  reply	other threads:[~2019-12-06 13:39 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-05 17:23 [PATCH] sched/fair: Optimize select_idle_core Srikar Dronamraju
2019-12-05 17:27 ` Vincent Guittot
2019-12-05 17:51   ` Srikar Dronamraju
2019-12-05 18:52     ` Vincent Guittot
2019-12-06  8:16       ` Srikar Dronamraju
2019-12-06 13:27         ` Vincent Guittot
2019-12-06 13:39           ` Srikar Dronamraju [this message]
2019-12-06 16:48             ` Vincent Guittot
2019-12-06 12:00 ` Valentin Schneider
2019-12-06 12:32   ` Peter Zijlstra
2019-12-06 12:53   ` Srikar Dronamraju
2019-12-06 16:57     ` Valentin Schneider

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191206133930.GA25024@linux.vnet.ibm.com \
    --to=srikar@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgorman@techsingularity.net \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=riel@surriel.com \
    --cc=tglx@linutronix.de \
    --cc=valentin.schneider@arm.com \
    --cc=vincent.guittot@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.