From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH 2/3] x86 cpuinfo: implement sysfs nodes for x86 Date: Fri, 6 Dec 2019 17:36:56 +0100 Message-ID: <20191206163656.GC86904@kroah.com> References: <20191206162421.15050-1-trenn@suse.de> <20191206162421.15050-3-trenn@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <20191206162421.15050-3-trenn@suse.de> Sender: linux-kernel-owner@vger.kernel.org To: Thomas Renninger Cc: linux-kernel@vger.kernel.org, Felix Schnizlein , linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux@armlinux.org.uk, will.deacon@arm.com, x86@kernel.org, fschnitzlein@suse.de, Felix Schnizlein , Thomas Renninger List-Id: linux-arch.vger.kernel.org On Fri, Dec 06, 2019 at 05:24:20PM +0100, Thomas Renninger wrote: > From: Felix Schnizlein > > Enable sysfs cpuinfo for x86 based cpus. > Export often used cpu information to sysfs: > stepping, flags, bugs, bogomips, family, vendor_id, > model, and model_name are exported. > > Sysfs documentation is updated to reflect changes. > > Example (on a kvm instance running no an intel cpu): > /sys/devices/system/cpu/cpu1/info/:[0]# head * > ==> bogomips <== > 5187.72 > > ==> bugs <== > cpu_meltdown spectre_v1 spectre_v2 spec_store_bypass l1tf mds swapgs itlb_multihit > > ==> cpu_family <== > 6 > > ==> flags <== > fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid tsc_known_freq pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand hypervisor lahf_lm abm cpuid_fault invpcid_single pti ssbd ibrs ibpb fsgsbase tsc_adjust bmi1 avx2 smep bmi2 erms invpcid xsaveopt arat umip One file with all of that? We are going to run into problems eventually, that should be split up. Just like bugs, that's going to just grow over time and eventually overflow PAGE_SIZE :( Make this: ├── flags │   ├── fpu │   ├── vme ... Much simpler to parse, right? sysfs files need to be one-value-per-file, and that's a lot of different values in a single file. How did I miss that before? > @@ -0,0 +1,99 @@ > +/* > + * Copyright (C) 2017 SUSE Linux GmbH > + * Written by: Felix Schnizlein > + * > + * This program is free software; you can redistribute it and/or > + * modify it under the terms of the GNU General Public License version > + * 2 as published by the Free Software Foundation. > + * > + * This program is distributed in the hope that it will be useful, but > + * WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * General Public License for more details. Boilerplate and SPDX. You did run these through checkpatch.pl, right? It should have complained about this. thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96BB0C43603 for ; Fri, 6 Dec 2019 16:37:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 35D9C2173E for ; Fri, 6 Dec 2019 16:37:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="N1qKO1JE"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="SMLxrM14" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 35D9C2173E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uFYN7KwDhGJWFHzUXQSF/SfhdSyEiAWKB7opOc3+xj4=; b=N1qKO1JEXjHon1 Ub7fIyl8/bHqG0eFNvFAzrSxypHYmqepkkpxBVdb3hVy9zPEaaliDPeXHj3LDzw5MEZMlbfcgwbNl 0nhHW4ZrDlv+mGsCAM3O57a5wCkqhl2oga8ORszDd2JsRy26CfT3uMGvVQxOOM1rjiNalLvnVYqiQ hQ8nqIePqvSsBDSJqPgvKy0ojGFoZAYGa/dSpm4bt66yPyQkA9Mf8jymnH9TlpE/QB63eOzKXkeHr vgBMpi96tzyriQpe8GNvncN6ICaoGcNLdjZZHYlKlL9Ey7QjMJDHsLA+IwyETjnwRWBgqQnpBWUZ+ qA/Awud6u7Luc/lgOeQA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1idGbR-00022R-Pn; Fri, 06 Dec 2019 16:37:13 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1idGbD-0001ma-IA for linux-arm-kernel@lists.infradead.org; Fri, 06 Dec 2019 16:37:00 +0000 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8FB7E2173E; Fri, 6 Dec 2019 16:36:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575650219; bh=2H3ziaS3wSxYN2KRy/3/wq9E68TWEGzBwD5gyjiUZKc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SMLxrM14iP7T5hwxwaGBH+jV7xzG2sSAxPyomobXXe93MRL/+gyC6rYj5zWawvMv7 wJ28xDTpb+r1h6LV3Miyk3tpgsq2DYLWo9Lp846xgWLWDtN0DutBNoO1eywkVV/iDA LGFS8MoTVGdP6JZ1KT80jsnd12PZ2yP/wR6LJIzs= Date: Fri, 6 Dec 2019 17:36:56 +0100 From: Greg KH To: Thomas Renninger Subject: Re: [PATCH 2/3] x86 cpuinfo: implement sysfs nodes for x86 Message-ID: <20191206163656.GC86904@kroah.com> References: <20191206162421.15050-1-trenn@suse.de> <20191206162421.15050-3-trenn@suse.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191206162421.15050-3-trenn@suse.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191206_083659_632432_DA827445 X-CRM114-Status: GOOD ( 12.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, Felix Schnizlein , Felix Schnizlein , x86@kernel.org, will.deacon@arm.com, linux@armlinux.org.uk, Thomas Renninger , linux-kernel@vger.kernel.org, fschnitzlein@suse.de, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCBEZWMgMDYsIDIwMTkgYXQgMDU6MjQ6MjBQTSArMDEwMCwgVGhvbWFzIFJlbm5pbmdl ciB3cm90ZToKPiBGcm9tOiBGZWxpeCBTY2huaXpsZWluIDxmc2Nobml6bGVpbkBzdXNlLmRlPgo+ IAo+IEVuYWJsZSBzeXNmcyBjcHVpbmZvIGZvciB4ODYgYmFzZWQgY3B1cy4KPiBFeHBvcnQgb2Z0 ZW4gdXNlZCBjcHUgaW5mb3JtYXRpb24gdG8gc3lzZnM6Cj4gc3RlcHBpbmcsIGZsYWdzLCBidWdz LCBib2dvbWlwcywgZmFtaWx5LCB2ZW5kb3JfaWQsCj4gbW9kZWwsIGFuZCBtb2RlbF9uYW1lIGFy ZSBleHBvcnRlZC4KPiAKPiBTeXNmcyBkb2N1bWVudGF0aW9uIGlzIHVwZGF0ZWQgdG8gcmVmbGVj dCBjaGFuZ2VzLgo+IAo+IEV4YW1wbGUgKG9uIGEga3ZtIGluc3RhbmNlIHJ1bm5pbmcgbm8gYW4g aW50ZWwgY3B1KToKPiAvc3lzL2RldmljZXMvc3lzdGVtL2NwdS9jcHUxL2luZm8vOlswXSMgaGVh ZCAqCj4gPT0+IGJvZ29taXBzIDw9PQo+IDUxODcuNzIKPiAKPiA9PT4gYnVncyA8PT0KPiBjcHVf bWVsdGRvd24gc3BlY3RyZV92MSBzcGVjdHJlX3YyIHNwZWNfc3RvcmVfYnlwYXNzIGwxdGYgbWRz IHN3YXBncyBpdGxiX211bHRpaGl0Cj4gCj4gPT0+IGNwdV9mYW1pbHkgPD09Cj4gNgo+IAo+ID09 PiBmbGFncyA8PT0KPiBmcHUgdm1lIGRlIHBzZSB0c2MgbXNyIHBhZSBtY2UgY3g4IGFwaWMgc2Vw IG10cnIgcGdlIG1jYSBjbW92IHBhdCBwc2UzNiBjbGZsdXNoIG1teCBmeHNyIHNzZSBzc2UyIHNz IHN5c2NhbGwgbnggcGRwZTFnYiByZHRzY3AgbG0gY29uc3RhbnRfdHNjIHJlcF9nb29kIG5vcGwg eHRvcG9sb2d5IGNwdWlkIHRzY19rbm93bl9mcmVxIHBuaSBwY2xtdWxxZHEgc3NzZTMgZm1hIGN4 MTYgcGNpZCBzc2U0XzEgc3NlNF8yIHgyYXBpYyBtb3ZiZSBwb3BjbnQgdHNjX2RlYWRsaW5lX3Rp bWVyIGFlcyB4c2F2ZSBhdnggZjE2YyByZHJhbmQgaHlwZXJ2aXNvciBsYWhmX2xtIGFibSBjcHVp ZF9mYXVsdCBpbnZwY2lkX3NpbmdsZSBwdGkgc3NiZCBpYnJzIGlicGIgZnNnc2Jhc2UgdHNjX2Fk anVzdCBibWkxIGF2eDIgc21lcCBibWkyIGVybXMgaW52cGNpZCB4c2F2ZW9wdCBhcmF0IHVtaXAK Ck9uZSBmaWxlIHdpdGggYWxsIG9mIHRoYXQ/ICBXZSBhcmUgZ29pbmcgdG8gcnVuIGludG8gcHJv YmxlbXMKZXZlbnR1YWxseSwgdGhhdCBzaG91bGQgYmUgc3BsaXQgdXAuCgpKdXN0IGxpa2UgYnVn cywgdGhhdCdzIGdvaW5nIHRvIGp1c3QgZ3JvdyBvdmVyIHRpbWUgYW5kIGV2ZW50dWFsbHkKb3Zl cmZsb3cgUEFHRV9TSVpFIDooCgpNYWtlIHRoaXM6CiAg4pSc4pSA4pSAIGZsYWdzCiAg4pSCwqDC oCDilJzilIDilIAgZnB1CiAg4pSCwqDCoCDilJzilIDilIAgdm1lCi4uLgoKTXVjaCBzaW1wbGVy IHRvIHBhcnNlLCByaWdodD8KCnN5c2ZzIGZpbGVzIG5lZWQgdG8gYmUgb25lLXZhbHVlLXBlci1m aWxlLCBhbmQgdGhhdCdzIGEgbG90IG9mIGRpZmZlcmVudAp2YWx1ZXMgaW4gYSBzaW5nbGUgZmls ZS4KCkhvdyBkaWQgSSBtaXNzIHRoYXQgYmVmb3JlPwoKPiBAQCAtMCwwICsxLDk5IEBACj4gKy8q Cj4gKyAqIENvcHlyaWdodCAoQykgMjAxNyBTVVNFIExpbnV4IEdtYkgKPiArICogV3JpdHRlbiBi eTogRmVsaXggU2Nobml6bGVpbiA8ZnNjaG5pemxlaW5Ac3VzZS5jb20+Cj4gKyAqCj4gKyAqIFRo aXMgcHJvZ3JhbSBpcyBmcmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBpdCBhbmQv b3IKPiArICogbW9kaWZ5IGl0IHVuZGVyIHRoZSB0ZXJtcyBvZiB0aGUgR05VIEdlbmVyYWwgUHVi bGljIExpY2Vuc2UgdmVyc2lvbgo+ICsgKiAyIGFzIHB1Ymxpc2hlZCBieSB0aGUgRnJlZSBTb2Z0 d2FyZSBGb3VuZGF0aW9uLgo+ICsgKgo+ICsgKiBUaGlzIHByb2dyYW0gaXMgZGlzdHJpYnV0ZWQg aW4gdGhlIGhvcGUgdGhhdCBpdCB3aWxsIGJlIHVzZWZ1bCwgYnV0Cj4gKyAqIFdJVEhPVVQgQU5Z IFdBUlJBTlRZOyB3aXRob3V0IGV2ZW4gdGhlIGltcGxpZWQgd2FycmFudHkgb2YKPiArICogTUVS Q0hBTlRBQklMSVRZIG9yIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUiBQVVJQT1NFLiAgU2VlIHRo ZSBHTlUKPiArICogR2VuZXJhbCBQdWJsaWMgTGljZW5zZSBmb3IgbW9yZSBkZXRhaWxzLgoKQm9p bGVycGxhdGUgYW5kIFNQRFguCgpZb3UgZGlkIHJ1biB0aGVzZSB0aHJvdWdoIGNoZWNrcGF0Y2gu cGwsIHJpZ2h0PyAgSXQgc2hvdWxkIGhhdmUKY29tcGxhaW5lZCBhYm91dCB0aGlzLgoKdGhhbmtz LAoKZ3JlZyBrLWgKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMu aW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2xpbnV4LWFybS1rZXJuZWwK