From: Jonathan Cameron <jic23@kernel.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-iio@vger.kernel.org, Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>
Subject: Re: [PATCH] iio: as3935: Drop GPIO includes
Date: Fri, 6 Dec 2019 17:46:49 +0000 [thread overview]
Message-ID: <20191206174649.55c0cac8@archlinux> (raw)
In-Reply-To: <20191202081943.62073-1-linus.walleij@linaro.org>
On Mon, 2 Dec 2019 09:19:43 +0100
Linus Walleij <linus.walleij@linaro.org> wrote:
> The driver includes <linux/gpio.h> and <linux/of_gpio.h> yet
> fails to use symbols from any of the include files, so drop
> these includes.
>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Applied,
Thanks,
Jonathan
> ---
> drivers/iio/proximity/as3935.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/iio/proximity/as3935.c b/drivers/iio/proximity/as3935.c
> index b591c63bd6c4..bac9a433dd19 100644
> --- a/drivers/iio/proximity/as3935.c
> +++ b/drivers/iio/proximity/as3935.c
> @@ -14,7 +14,6 @@
> #include <linux/mutex.h>
> #include <linux/err.h>
> #include <linux/irq.h>
> -#include <linux/gpio.h>
> #include <linux/spi/spi.h>
> #include <linux/iio/iio.h>
> #include <linux/iio/sysfs.h>
> @@ -22,8 +21,6 @@
> #include <linux/iio/trigger_consumer.h>
> #include <linux/iio/buffer.h>
> #include <linux/iio/triggered_buffer.h>
> -#include <linux/of_gpio.h>
> -
>
> #define AS3935_AFE_GAIN 0x00
> #define AS3935_AFE_MASK 0x3F
prev parent reply other threads:[~2019-12-06 17:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-02 8:19 [PATCH] iio: as3935: Drop GPIO includes Linus Walleij
2019-12-06 17:46 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191206174649.55c0cac8@archlinux \
--to=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.