From mboxrd@z Thu Jan 1 00:00:00 1970 From: Al Viro Subject: Re: [PATCH v2 0/6] Delete timespec64_trunc() Date: Sat, 7 Dec 2019 06:02:01 +0000 Message-ID: <20191207060201.GN4203@ZenIV.linux.org.uk> References: <20191203051945.9440-1-deepa.kernel@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Deepa Dinamani Cc: Linux Kernel Mailing List , Andrew Morton , Linux FS-devel Mailing List , Arnd Bergmann , ceph-devel , OGAWA Hirofumi , Jeff Layton , CIFS , linux-mtd , Richard Weinberger , Steve French List-Id: ceph-devel.vger.kernel.org On Thu, Dec 05, 2019 at 06:43:26PM -0800, Deepa Dinamani wrote: > On Mon, Dec 2, 2019 at 9:20 PM Deepa Dinamani wrote: > > This series aims at deleting timespec64_trunc(). > > There is a new api: timestamp_truncate() that is the > > replacement api. The api additionally does a limits > > check on the filesystem timestamps. > > Al/Andrew, can one of you help merge these patches? Looks sane. Could you check if #misc.timestamp looks sane to you? One thing that leaves me scratching head is kernfs - surely we are _not_ limited by any external layouts there, so why do we need to bother with truncation? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E605C43603 for ; Sat, 7 Dec 2019 06:04:38 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3B5B720867 for ; Sat, 7 Dec 2019 06:04:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="q8axamen" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3B5B720867 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=zeniv.linux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=H7Lx2OtM+BkGdzIfLIdB/qtrmX1Fd0tMgsLZMb6UQ7g=; b=q8axamenmksS2o 0PtoOXFHj6ZGH6QQWK2FnvaOn1I8ZXn116RBFWSclmKlbS/texcDtuxS8S6+zWv2Z9Krw+T2dgLQP bZ61NlEDyrkT6dWYBXgUbYlQiQ26Y8xt/Cq4gR48RxTtixccwzLvb/HTCxxnM6rjogpIbbRh7aC44 c2QE1Li7TIVLLq/ojpnsXuWmC0j6B3YxnfGYj6WeZgzIi8X2PbY4sT7qoykvJbUfZEf42CqfC1DPJ emVqVpyPUg/FaVTA6MdGhJVavJuoznzaMkoLqpNy+q3444+Kp9AXyXUfOOHi6XzQ+Aw1wWKAqPbos ncC+p/bszCSJuPP/GuDQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1idTCX-0001uS-H0; Sat, 07 Dec 2019 06:04:21 +0000 Received: from zeniv.linux.org.uk ([195.92.253.2]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1idTCU-0001pk-JJ for linux-mtd@lists.infradead.org; Sat, 07 Dec 2019 06:04:20 +0000 Received: from viro by ZenIV.linux.org.uk with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1idTAH-0006SZ-5o; Sat, 07 Dec 2019 06:02:01 +0000 Date: Sat, 7 Dec 2019 06:02:01 +0000 From: Al Viro To: Deepa Dinamani Subject: Re: [PATCH v2 0/6] Delete timespec64_trunc() Message-ID: <20191207060201.GN4203@ZenIV.linux.org.uk> References: <20191203051945.9440-1-deepa.kernel@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191206_220418_633880_A7BDBFE5 X-CRM114-Status: GOOD ( 10.00 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: CIFS , Arnd Bergmann , Richard Weinberger , Jeff Layton , Linux Kernel Mailing List , linux-mtd , Steve French , Linux FS-devel Mailing List , Andrew Morton , ceph-devel , OGAWA Hirofumi Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Thu, Dec 05, 2019 at 06:43:26PM -0800, Deepa Dinamani wrote: > On Mon, Dec 2, 2019 at 9:20 PM Deepa Dinamani wrote: > > This series aims at deleting timespec64_trunc(). > > There is a new api: timestamp_truncate() that is the > > replacement api. The api additionally does a limits > > check on the filesystem timestamps. > > Al/Andrew, can one of you help merge these patches? Looks sane. Could you check if #misc.timestamp looks sane to you? One thing that leaves me scratching head is kernfs - surely we are _not_ limited by any external layouts there, so why do we need to bother with truncation? ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/