All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v6 5/6] package/polkit: add init service file
Date: Sun, 8 Dec 2019 16:08:08 +0100	[thread overview]
Message-ID: <20191208160808.7fcc27ec@windsurf.home> (raw)
In-Reply-To: <20191206234649.3972927-5-aduskett@gmail.com>

Hello,

+Carlos in Cc for the review of the init script.

On Fri,  6 Dec 2019 15:46:48 -0800
aduskett at gmail.com wrote:

> diff --git a/package/polkit/S50polkit b/package/polkit/S50polkit
> new file mode 100644
> index 0000000000..55c10e99ae
> --- /dev/null
> +++ b/package/polkit/S50polkit
> @@ -0,0 +1,15 @@
> +#!/bin/sh
> +#
> +# start polkitd
> +#
> +
> +case "$1" in
> +	start)
> +		start-stop-daemon -q -S -x /usr/lib/polkit-1/polkitd -- --no-debug &

Why is the & necessary at this end ?

I think this init script deserves a comment that explains why it
doesn't follow the traditional pattern for init scripts.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2019-12-08 15:08 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-06 23:46 [Buildroot] [PATCH v6 1/6] package/polkit: bump to version 0.116 aduskett at gmail.com
2019-12-06 23:46 ` [Buildroot] [PATCH v6 2/6] package/polkit: support different authentication frameworks aduskett at gmail.com
2019-12-08 15:02   ` Thomas Petazzoni
2019-12-06 23:46 ` [Buildroot] [PATCH v6 3/6] package/polkit: add systemd service file aduskett at gmail.com
2019-12-08 15:04   ` Thomas Petazzoni
2019-12-08 18:46     ` Adam Duskett
2019-12-08 19:57       ` Thomas Petazzoni
2019-12-08 21:31         ` Adam Duskett
2019-12-08 21:32           ` Adam Duskett
2019-12-06 23:46 ` [Buildroot] [PATCH v6 4/6] support/testing: add polkit systemd test aduskett at gmail.com
2019-12-08 15:07   ` Thomas Petazzoni
2019-12-06 23:46 ` [Buildroot] [PATCH v6 5/6] package/polkit: add init service file aduskett at gmail.com
2019-12-08 15:08   ` Thomas Petazzoni [this message]
2020-02-09 21:28     ` Carlos Santos
2019-12-06 23:46 ` [Buildroot] [PATCH v6 6/6] support/testing: add polkit initd test aduskett at gmail.com
2019-12-08 15:02 ` [Buildroot] [PATCH v6 1/6] package/polkit: bump to version 0.116 Thomas Petazzoni
2019-12-08 19:04   ` Adam Duskett
2019-12-08 19:58     ` Thomas Petazzoni
2019-12-09 19:03       ` Adam Duskett
2019-12-14 21:04         ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191208160808.7fcc27ec@windsurf.home \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.