From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CF9EC43603 for ; Mon, 9 Dec 2019 16:42:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1839E2073D for ; Mon, 9 Dec 2019 16:42:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726689AbfLIQmP (ORCPT ); Mon, 9 Dec 2019 11:42:15 -0500 Received: from mga17.intel.com ([192.55.52.151]:52175 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725904AbfLIQmO (ORCPT ); Mon, 9 Dec 2019 11:42:14 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Dec 2019 08:42:14 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,296,1571727600"; d="scan'208";a="215272459" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga003.jf.intel.com with ESMTP; 09 Dec 2019 08:42:13 -0800 Received: from andy by smile with local (Exim 4.93-RC5) (envelope-from ) id 1ieM6v-00015B-6B; Mon, 09 Dec 2019 18:42:13 +0200 Date: Mon, 9 Dec 2019 18:42:13 +0200 From: Andy Shevchenko To: Matt Porter , linux-kernel@vger.kernel.org Cc: Alexandre Bounine Subject: Re: [PATCH v1] rapidio: Make it dependent to DMADEVICES Message-ID: <20191209164213.GN32742@smile.fi.intel.com> References: <20190813143906.9865-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190813143906.9865-1-andriy.shevchenko@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 13, 2019 at 05:39:06PM +0300, Andy Shevchenko wrote: > DMADEVICES option depends on HAS_DMA, and this dependency is ignored > when DMADEVICES is being selected. > > Replace 'select' by 'depends on' in Kconfig for RAPIDIO_DMA_ENGINE. Anybody to comment on this? > > Fixes: e42d98ebe7d7 ("rapidio: add DMA engine support for RIO data transfers") > Cc: Alexandre Bounine > Signed-off-by: Andy Shevchenko > --- > drivers/rapidio/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/rapidio/Kconfig b/drivers/rapidio/Kconfig > index 677d1aff61b7..788e7830771b 100644 > --- a/drivers/rapidio/Kconfig > +++ b/drivers/rapidio/Kconfig > @@ -37,7 +37,7 @@ config RAPIDIO_ENABLE_RX_TX_PORTS > config RAPIDIO_DMA_ENGINE > bool "DMA Engine support for RapidIO" > depends on RAPIDIO > - select DMADEVICES > + depends on DMADEVICES > select DMA_ENGINE > help > Say Y here if you want to use DMA Engine frameork for RapidIO data > -- > 2.20.1 > -- With Best Regards, Andy Shevchenko