All of lore.kernel.org
 help / color / mirror / Atom feed
From: Beat Bolli <dev+git@drbeat.li>
To: git@vger.kernel.org
Cc: Paul Mackerras <paulus@ozlabs.org>, Beat Bolli <dev+git@drbeat.li>
Subject: [PATCH 1/2] gitk: use --pretty=reference to generate the commit summary
Date: Mon,  9 Dec 2019 19:25:33 +0100	[thread overview]
Message-ID: <20191209182534.309884-1-dev+git@drbeat.li> (raw)

Git learned the "reference" pretty format in 1f0fc1db85 (pretty:
implement 'reference' format, 2019-11-19). Use it also in gitk instead
of duplicating the format string. This way, gitk always follows the
formatting convention defined by git.

Signed-off-by: Beat Bolli <dev+git@drbeat.li>
---
Junio, this goes on top of dl/pretty-reference, currently in pu.

Thanks!

 gitk-git/gitk | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/gitk-git/gitk b/gitk-git/gitk
index a14d7a16b2..cc89fb25d2 100755
--- a/gitk-git/gitk
+++ b/gitk-git/gitk
@@ -9392,8 +9392,7 @@ proc mktaggo {} {
 proc copysummary {} {
     global rowmenuid autosellen
 
-    set format "%h (\"%s\", %ad)"
-    set cmd [list git show -s --pretty=format:$format --date=short]
+    set cmd [list git show -s --pretty=reference]
     if {$autosellen < 40} {
         lappend cmd --abbrev=$autosellen
     }
-- 
2.23.0.13.gecf2037ff6


             reply	other threads:[~2019-12-09 18:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-09 18:25 Beat Bolli [this message]
2019-12-09 18:25 ` [PATCH 2/2] gitk: rename "commit summary" to "commit reference" Beat Bolli
2019-12-09 19:33 ` [PATCH 1/2] gitk: use --pretty=reference to generate the commit summary Denton Liu
2019-12-10  1:46 ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191209182534.309884-1-dev+git@drbeat.li \
    --to=dev+git@drbeat.li \
    --cc=git@vger.kernel.org \
    --cc=paulus@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.