From: Eric Biggers <ebiggers@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>, linux-fsdevel@vger.kernel.org
Subject: [PATCH] fs/direct-io.c: include fs/internal.h for missing prototype
Date: Mon, 9 Dec 2019 15:45:44 -0800 [thread overview]
Message-ID: <20191209234544.128302-1-ebiggers@kernel.org> (raw)
From: Eric Biggers <ebiggers@google.com>
Include fs/internal.h to address the following 'sparse' warning:
fs/direct-io.c:591:5: warning: symbol 'sb_init_dio_done_wq' was not declared. Should it be static?
Signed-off-by: Eric Biggers <ebiggers@google.com>
---
Hi Andrew, please consider applying this straightforward cleanup.
This has been sent to Al four times with no response.
fs/direct-io.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/direct-io.c b/fs/direct-io.c
index 0ec4f270139f6..00b4d15bb811a 100644
--- a/fs/direct-io.c
+++ b/fs/direct-io.c
@@ -39,6 +39,8 @@
#include <linux/atomic.h>
#include <linux/prefetch.h>
+#include "internal.h"
+
/*
* How many user pages to map in one call to get_user_pages(). This determines
* the size of a structure in the slab cache
--
2.24.0.393.g34dc348eaf-goog
next reply other threads:[~2019-12-09 23:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-09 23:45 Eric Biggers [this message]
2019-12-13 10:40 ` [PATCH] fs/direct-io.c: include fs/internal.h for missing prototype Jan Kara
-- strict thread matches above, loose matches on Subject: below --
2019-05-29 21:21 Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191209234544.128302-1-ebiggers@kernel.org \
--to=ebiggers@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.