From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/libnss: fix build failure on powerpc without <sys/auxv.h>
Date: Tue, 10 Dec 2019 14:31:11 +0100 [thread overview]
Message-ID: <20191210143111.0051e59f@windsurf> (raw)
In-Reply-To: <3e33365c-5e48-b5c7-f67f-74e60c93d4c8@benettiengineering.com>
Hello,
On Tue, 10 Dec 2019 14:23:02 +0100
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:
> > I'm not really a big fan of solutions that simply consist in "it wants
> > this file, this file is not available, so let's make it ignore it",
> > without a deeper investigation.
>
> Upstream already use this solution in the same file, i.e. arm/aarch64:
> https://hg.mozilla.org/projects/nss/file/tip/lib/freebl/blinit.c#l100
>
> and only if <sys/auxv.h> is present then they probe with getauxval() to
> check which HWCAP_ is present, otherwise they consider(i.e.)
> arm_neon_support not present, that is not true in any case. But at the
> time of this writing they seem to consider this enough, probably they
> will improve it later.
OK, if this is indeed used on other architectures, then I guess doing
the same on PowerPC doesn't hurt. Thanks for the additional explanation!
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-12-10 13:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-10 12:13 [Buildroot] [PATCH] package/libnss: fix build failure on powerpc without <sys/auxv.h> Giulio Benetti
2019-12-10 12:14 ` Giulio Benetti
2019-12-10 13:09 ` Thomas Petazzoni
2019-12-10 13:23 ` Giulio Benetti
2019-12-10 13:31 ` Thomas Petazzoni [this message]
2019-12-23 22:46 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191210143111.0051e59f@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.