From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a19:c345:0:0:0:0:0 with SMTP id t66csp5828368lff; Tue, 10 Dec 2019 05:49:31 -0800 (PST) X-Google-Smtp-Source: APXvYqw7I6V7mHpsNILg74ZF/KaRadl0mQ2300KXfBHP5Dj1HQ2XH3YNhMGif3owQgsBEWAnG91E X-Received: by 2002:a9d:150:: with SMTP id 74mr14780001otu.149.1575985771614; Tue, 10 Dec 2019 05:49:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575985771; cv=none; d=google.com; s=arc-20160816; b=rO0Y6NuzADLsBnU+PFtdheD7QGIFYa+PQukDu7OGWTPn7v3BsmHZEpAMJ8b1QzEDjp zej1CDXnuvWQjqz7E7zEGsT2ILf0lRUjcqVvoI5AbZ8u4KCfUAzTsGfmH1ofb4lE6mW1 WpxYMkA5cpTlp0JzXGro8MSGgxQ4BvnuaSwwy56RB9toskKSrcBcadfHKG9jWqIIagbo yshQ1111bGfhAQu1X2V3N9ksLXdooOxSITm3gVdAvOM0XZO/TG81om5D/Tqhj9WyNwsG HAZ1ITichfkrFOGAvbg5HlsA8IJMPXpxqgGBEPwmGdBizoFLaFsO8IGOZUfLquszPIU8 ctZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:subject:to:from:date :dkim-signature; bh=I64k/0k0WqHLXmozMKl6bFkRveg8+eAnwsRxOZOuy1o=; b=zu+nPikuP6u1ZUwgcOND6UzSg5TvN3oNQCW9a2KVTTbLhmXZ5qJbZPKKItCNpKo5Ab bL+ZwbvN4afur7qV2RylGKYZinPwKztNbky6EuuT52UQnBKhTH1YiqEijcCdAtTl2dMz EZKhKNWjD/wlt6uB9Rnm9sQ3HegZZZz8IcbIXX3/O2bi6rCMpoBXrm2rxRjFRV1UDRyG +ozpNj4CqiMo3iaybRiBuvQhxlQmI9t/0r+hdkeJk2sJnI1TPpk+rSzamucfes7ty076 vE+MBanHd/xD7kpNYw1QWqwsZbr/Pqd3hU9Q7XFxmcPR7IZGwy1p6FjxHJy7X0MHRB1P +i1Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@redhat.com header.s=mimecast20190719 header.b="L35dLW/w"; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id b133si1967475oii.155.2019.12.10.05.49.31 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 10 Dec 2019 05:49:31 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@redhat.com header.s=mimecast20190719 header.b="L35dLW/w"; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:57072 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ieftK-00067M-N7 for alex.bennee@linaro.org; Tue, 10 Dec 2019 08:49:30 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44483) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ieftA-00065W-8M for qemu-arm@nongnu.org; Tue, 10 Dec 2019 08:49:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ieft8-0007jW-G4 for qemu-arm@nongnu.org; Tue, 10 Dec 2019 08:49:19 -0500 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:31733 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ieft8-0007jA-Bu for qemu-arm@nongnu.org; Tue, 10 Dec 2019 08:49:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1575985757; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=I64k/0k0WqHLXmozMKl6bFkRveg8+eAnwsRxOZOuy1o=; b=L35dLW/wFoshKygftk0jLhW8iEVTurqKxOKFB9fU5RzxaglW/mhJcrJEnUz/qCnzBL16MX 2bzuniVjLXhcKsOhRMBRzLWwXc3vJuPqcrd4e5z2vnJz1ttjxQc56g95bC6KGpK2lTYr8K 1bcwc2WAWjC0mtmOTYB5NqyrE8LJXwo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-108-mc-EPHbLP0i3DQouD872lQ-1; Tue, 10 Dec 2019 08:49:14 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 95FB112D658B; Tue, 10 Dec 2019 13:49:12 +0000 (UTC) Received: from localhost (unknown [10.43.2.114]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3ADD710016E8; Tue, 10 Dec 2019 13:49:08 +0000 (UTC) Date: Tue, 10 Dec 2019 14:49:06 +0100 From: Igor Mammedov To: Peter Maydell Subject: Re: [PATCH v6 0/2] arm/acpi: simplify aml code and enable SHPC Message-ID: <20191210144906.14e41c7a@redhat.com> In-Reply-To: References: <20191209063719.23086-1-guoheyi@huawei.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-MC-Unique: mc-EPHbLP0i3DQouD872lQ-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 205.139.110.61 X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Michael S. Tsirkin" , QEMU Developers , Shannon Zhao , qemu-arm , Heyi Guo , wanghaibin.wang@huawei.com Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-arm" X-TUID: l9kNQWIvD0Nv On Mon, 9 Dec 2019 17:51:10 +0000 Peter Maydell wrote: > On Mon, 9 Dec 2019 at 06:38, Heyi Guo wrote: > > > > After the introduction of generic PCIe root port and PCIe-PCI bridge, we will > > also have SHPC controller on ARM, and we don't support ACPI hot plug, so just > > enable SHPC native hot plug. > > > > Igor also spotted the store operation outside of bit and/or is not necessary, so > > simply the code at first. > > > > v6: > > - Fix "make check" errors by updating tests/data/acpi/virt/DSDT*. > > > > v5: > > - Refine commit message of patch 1/2 > > > > v4: > > - Improve the code indention. > > > > Cc: Shannon Zhao > > Cc: Peter Maydell > > Cc: "Michael S. Tsirkin" > > Cc: Igor Mammedov > > Thanks, applied to target-arm.next. (it's a bit awkward that acpi > table updates require also updating a bunch of binary test files, > but I suppose trying to make the golden-reference be some textual > format would be not very feasible.) Michael tried document it (commit 30c63d4fbd69) so that binary blobs would not be required (trusted). Problem is usually in blobs being un-review-able and unresolvable merge conflicts, that's why Michael updates tables manually for all changes in pull req. But in this case it touches only ARM tables and it's the first change to go in, so it could just work out. > > thanks > -- PMM >