From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexandre Belloni Date: Tue, 10 Dec 2019 15:44:56 +0000 Subject: Re: [PATCH -next] rtc: mt6397: drop free_irq of devm_ allocated irq Message-Id: <20191210154456.GQ1463890@piout.net> List-Id: References: <20191113021720.9527-1-weiyongjun1@huawei.com> In-Reply-To: <20191113021720.9527-1-weiyongjun1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Wei Yongjun Cc: linux-rtc@vger.kernel.org, Alessandro Zummo , Josef Friedl , Sean Wang , kernel-janitors@vger.kernel.org, Hulk Robot , linux-mediatek@lists.infradead.org, Matthias Brugger , Eddie Huang , linux-arm-kernel@lists.infradead.org On 13/11/2019 02:17:20+0000, Wei Yongjun wrote: > The devm_request_threaded_irq function allocates irq that is > released when a driver detaches. Thus, there is no reason to > explicitly call free_irq in probe function. > > Fixes: 851b87148aa2 ("rtc: mt6397: improvements of rtc driver") > Reported-by: Hulk Robot > Signed-off-by: Wei Yongjun > --- > drivers/rtc/rtc-mt6397.c | 10 +--------- > 1 file changed, 1 insertion(+), 9 deletions(-) > Applied, thanks. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4335FC43603 for ; Tue, 10 Dec 2019 15:45:29 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1626F207FF for ; Tue, 10 Dec 2019 15:45:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="A3hrUXRj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1626F207FF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=soYKEc2equc7pBkpnbxI/GPTNzbQaHkNAZjF446mEbw=; b=A3hrUXRjMsbZyW Qu3zdOgvWCnscD5JVWNbp3IHEQ/QwSBaGmHm6kCDR5qTAYxCHnqrARoBSWQTPx+/yRKoaxj61yYTH qV3gUXH+0rkD3o6bWQdoGG6/ffwoq1ptHZcwMEtTBuGNzk19Q2zAG/T4DcdROt9svmhBvUm8FTv49 MorkrUdYqw43XtECBUc03LiuiiNcV3h6gHGX4j6eoL+gV4mw+Q25lpLC3YNFxVEypJENzMO+YnigG vMUDIkhcCNcLYW3kDNShz8jfYaolp9nxj2xkB/r2ufcr8iP9F+MSbOHTyrf5exoYPi9w9+6PnDSV4 T5Ts5U5Eq67D1dD6UTBA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iehhP-0007vm-Us; Tue, 10 Dec 2019 15:45:19 +0000 Received: from relay11.mail.gandi.net ([217.70.178.231]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iehhD-00072c-5O; Tue, 10 Dec 2019 15:45:08 +0000 Received: from localhost (136.112.broadband15.iol.cz [90.182.112.136]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay11.mail.gandi.net (Postfix) with ESMTPSA id 7565810000F; Tue, 10 Dec 2019 15:44:59 +0000 (UTC) Date: Tue, 10 Dec 2019 16:44:56 +0100 From: Alexandre Belloni To: Wei Yongjun Subject: Re: [PATCH -next] rtc: mt6397: drop free_irq of devm_ allocated irq Message-ID: <20191210154456.GQ1463890@piout.net> References: <20191113021720.9527-1-weiyongjun1@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191113021720.9527-1-weiyongjun1@huawei.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191210_074507_355548_431AAF43 X-CRM114-Status: UNSURE ( 9.38 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-rtc@vger.kernel.org, Alessandro Zummo , Josef Friedl , Sean Wang , kernel-janitors@vger.kernel.org, Hulk Robot , linux-mediatek@lists.infradead.org, Matthias Brugger , Eddie Huang , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On 13/11/2019 02:17:20+0000, Wei Yongjun wrote: > The devm_request_threaded_irq function allocates irq that is > released when a driver detaches. Thus, there is no reason to > explicitly call free_irq in probe function. > > Fixes: 851b87148aa2 ("rtc: mt6397: improvements of rtc driver") > Reported-by: Hulk Robot > Signed-off-by: Wei Yongjun > --- > drivers/rtc/rtc-mt6397.c | 10 +--------- > 1 file changed, 1 insertion(+), 9 deletions(-) > Applied, thanks. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24D5FC43603 for ; Tue, 10 Dec 2019 15:45:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F3E2B207FF for ; Tue, 10 Dec 2019 15:45:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727332AbfLJPpC (ORCPT ); Tue, 10 Dec 2019 10:45:02 -0500 Received: from relay11.mail.gandi.net ([217.70.178.231]:47295 "EHLO relay11.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727330AbfLJPpC (ORCPT ); Tue, 10 Dec 2019 10:45:02 -0500 Received: from localhost (136.112.broadband15.iol.cz [90.182.112.136]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay11.mail.gandi.net (Postfix) with ESMTPSA id 7565810000F; Tue, 10 Dec 2019 15:44:59 +0000 (UTC) Date: Tue, 10 Dec 2019 16:44:56 +0100 From: Alexandre Belloni To: Wei Yongjun Cc: Eddie Huang , Sean Wang , Alessandro Zummo , Matthias Brugger , Josef Friedl , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-rtc@vger.kernel.org, kernel-janitors@vger.kernel.org, Hulk Robot Subject: Re: [PATCH -next] rtc: mt6397: drop free_irq of devm_ allocated irq Message-ID: <20191210154456.GQ1463890@piout.net> References: <20191113021720.9527-1-weiyongjun1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191113021720.9527-1-weiyongjun1@huawei.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-rtc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org On 13/11/2019 02:17:20+0000, Wei Yongjun wrote: > The devm_request_threaded_irq function allocates irq that is > released when a driver detaches. Thus, there is no reason to > explicitly call free_irq in probe function. > > Fixes: 851b87148aa2 ("rtc: mt6397: improvements of rtc driver") > Reported-by: Hulk Robot > Signed-off-by: Wei Yongjun > --- > drivers/rtc/rtc-mt6397.c | 10 +--------- > 1 file changed, 1 insertion(+), 9 deletions(-) > Applied, thanks. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93A3BC00454 for ; Tue, 10 Dec 2019 15:45:12 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5D929207FF for ; Tue, 10 Dec 2019 15:45:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="mhhQhCJY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5D929207FF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kiFUsfVd1ZWmhlGeGEUeJF7oA4JNf+sfd2orRhf6Wao=; b=mhhQhCJYQtDRh5 1/EYxhaGg2cK0DSGbVYILMkOz7+lUX2bvzpz6Wu+V5NwscHjomAqzdOe3GjVinHsQViOo9Gt49TDD dAHzPHwMzIXrWie7GWQXoz1c1Kn0PyKOtXMNwvAHFCqkARHG9J4aZL1DfTg1FfkrXgNcNrW3P4Z1x dvPlMRAYOqnzJ1rIxE0HkUzAFRu+fYijmnObrqUecKMPsZa/v019+oe5qss2DvHbQ3GCxGTWg9Y6b ocEllLNbB4RQ/lH1tAudmjKv3A5pxQsydICshjsF1kUuKw7ng7m//HgYkKmfCvdu7pLQB2JKkLI31 R3Yh1KRHlu0vo70fGnNg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iehhH-0007nT-4u; Tue, 10 Dec 2019 15:45:11 +0000 Received: from relay11.mail.gandi.net ([217.70.178.231]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iehhD-00072c-5O; Tue, 10 Dec 2019 15:45:08 +0000 Received: from localhost (136.112.broadband15.iol.cz [90.182.112.136]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay11.mail.gandi.net (Postfix) with ESMTPSA id 7565810000F; Tue, 10 Dec 2019 15:44:59 +0000 (UTC) Date: Tue, 10 Dec 2019 16:44:56 +0100 From: Alexandre Belloni To: Wei Yongjun Subject: Re: [PATCH -next] rtc: mt6397: drop free_irq of devm_ allocated irq Message-ID: <20191210154456.GQ1463890@piout.net> References: <20191113021720.9527-1-weiyongjun1@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191113021720.9527-1-weiyongjun1@huawei.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191210_074507_355548_431AAF43 X-CRM114-Status: UNSURE ( 9.38 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-rtc@vger.kernel.org, Alessandro Zummo , Josef Friedl , Sean Wang , kernel-janitors@vger.kernel.org, Hulk Robot , linux-mediatek@lists.infradead.org, Matthias Brugger , Eddie Huang , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 13/11/2019 02:17:20+0000, Wei Yongjun wrote: > The devm_request_threaded_irq function allocates irq that is > released when a driver detaches. Thus, there is no reason to > explicitly call free_irq in probe function. > > Fixes: 851b87148aa2 ("rtc: mt6397: improvements of rtc driver") > Reported-by: Hulk Robot > Signed-off-by: Wei Yongjun > --- > drivers/rtc/rtc-mt6397.c | 10 +--------- > 1 file changed, 1 insertion(+), 9 deletions(-) > Applied, thanks. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel