From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AF3BC43603 for ; Tue, 10 Dec 2019 16:52:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CE88B2073D for ; Tue, 10 Dec 2019 16:52:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="gbExjgtd"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="Fg2Y/4ME" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CE88B2073D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lO9Co6ib92eHGi7YkV0W6Au84IuEoXtt+Ikb3wsk3A8=; b=gbExjgtdb6r3jn IFtCxDyE/V33BqKw6LKD4crPnNXYGAwxSkWrinDELIfqPsEQCeN2gRHFS3ionc6ctJVFKSU+jSBBx /hT+ZUkNh9zeSkTKQg41adb/ljpErhRF0kdtkF4OJgcHbzZnoM6dyP14xYQygWlLd9b+WFzlqzZJ9 lA7tZQdxJ0dJJf6w1SYygeX5yK0uxD+ChrQ2w4oYPrWOiDrnm5jNhRU8+ezfqszkjU1qQrBuHXGFU HK9Qb3zvI/rVAWW6ezFIJGfw/dLAX65qIuilz1t9/wh/tfxmnZCEn9wPmZty2kus0NIaGd/hY60wv 4xTLkkNEEHaOvsTNXW9w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ieiju-0000nI-36; Tue, 10 Dec 2019 16:51:58 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ieijs-0000mp-3W for linux-mediatek@lists.infradead.org; Tue, 10 Dec 2019 16:51:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=GS7ZQbG13kNNPclSha9kEVSYY0gWUbSimOQ+b8lUzFk=; b=Fg2Y/4MEnZ0sK7PeMIPC0QuEDc IpAtOZ1ZZ6ctnmLPYuczyZnzpozeJLjqJKz7bjbw6X7GmXnmL21fxTHIT64sRjdtC6f3eSBhMRTN1 bRyJTfeaTfsXEC46CiMXFWiAnGFnvktmWsmrhTwaPSFbgsgIfnBZuhu7ytRHzWqi76vY=; Received: from andrew by vps0.lunn.ch with local (Exim 4.92.2) (envelope-from ) id 1ieijl-0005RP-HK; Tue, 10 Dec 2019 17:51:49 +0100 Date: Tue, 10 Dec 2019 17:51:49 +0100 From: Andrew Lunn To: Landen Chao Subject: Re: [PATCH net-next 5/6] arm64: dts: mt7622: add mt7531 dsa to mt7622-rfb1 board Message-ID: <20191210165149.GF27714@lunn.ch> References: <7f5a690281664a0fe47cfe7726f26d7f6211d015.1575914275.git.landen.chao@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <7f5a690281664a0fe47cfe7726f26d7f6211d015.1575914275.git.landen.chao@mediatek.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191210_085156_143761_09DAF90F X-CRM114-Status: UNSURE ( 6.39 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, frank-w@public-files.de, f.fainelli@gmail.com, vivien.didelot@savoirfairelinux.com, netdev@vger.kernel.org, sean.wang@mediatek.com, linux-kernel@vger.kernel.org, opensource@vdorst.com, robh+dt@kernel.org, linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com, davem@davemloft.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org > + port@6 { > + reg = <6>; > + label = "cpu"; > + ethernet = <&gmac0>; > + phy-mode = "2500base-x"; > + > + fixed-link { > + speed = <2500>; > + full-duplex; > + pause; > + }; This fixed-link should not be needed. The DSA driver is supposed to configure the CPU port to its fastest speed by default. 2500 is the fastest speed a 2500Base-X link can do... Andrew _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B886C43603 for ; Tue, 10 Dec 2019 16:51:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 08B0C2073D for ; Tue, 10 Dec 2019 16:51:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="Fg2Y/4ME" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727506AbfLJQv5 (ORCPT ); Tue, 10 Dec 2019 11:51:57 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:45148 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727505AbfLJQv5 (ORCPT ); Tue, 10 Dec 2019 11:51:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=GS7ZQbG13kNNPclSha9kEVSYY0gWUbSimOQ+b8lUzFk=; b=Fg2Y/4MEnZ0sK7PeMIPC0QuEDc IpAtOZ1ZZ6ctnmLPYuczyZnzpozeJLjqJKz7bjbw6X7GmXnmL21fxTHIT64sRjdtC6f3eSBhMRTN1 bRyJTfeaTfsXEC46CiMXFWiAnGFnvktmWsmrhTwaPSFbgsgIfnBZuhu7ytRHzWqi76vY=; Received: from andrew by vps0.lunn.ch with local (Exim 4.92.2) (envelope-from ) id 1ieijl-0005RP-HK; Tue, 10 Dec 2019 17:51:49 +0100 Date: Tue, 10 Dec 2019 17:51:49 +0100 From: Andrew Lunn To: Landen Chao Cc: f.fainelli@gmail.com, vivien.didelot@savoirfairelinux.com, matthias.bgg@gmail.com, robh+dt@kernel.org, mark.rutland@arm.com, devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, davem@davemloft.net, sean.wang@mediatek.com, opensource@vdorst.com, frank-w@public-files.de Subject: Re: [PATCH net-next 5/6] arm64: dts: mt7622: add mt7531 dsa to mt7622-rfb1 board Message-ID: <20191210165149.GF27714@lunn.ch> References: <7f5a690281664a0fe47cfe7726f26d7f6211d015.1575914275.git.landen.chao@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7f5a690281664a0fe47cfe7726f26d7f6211d015.1575914275.git.landen.chao@mediatek.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org > + port@6 { > + reg = <6>; > + label = "cpu"; > + ethernet = <&gmac0>; > + phy-mode = "2500base-x"; > + > + fixed-link { > + speed = <2500>; > + full-duplex; > + pause; > + }; This fixed-link should not be needed. The DSA driver is supposed to configure the CPU port to its fastest speed by default. 2500 is the fastest speed a 2500Base-X link can do... Andrew