From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1A2FC2D0BF for ; Tue, 10 Dec 2019 21:12:26 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 958912073D for ; Tue, 10 Dec 2019 21:12:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="nWZLDrdg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 958912073D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8C3266E94B; Tue, 10 Dec 2019 21:12:24 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id 292736E94A for ; Tue, 10 Dec 2019 21:12:23 +0000 (UTC) Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6801221D7D; Tue, 10 Dec 2019 21:04:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576011852; bh=ceteDlM2gzudgpK7lNIbnJYzwn+zR/DJXRfsggSRc00=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nWZLDrdgdmxqvSiASswsIDBFiLH6jJIT7+masRpXwKfUip0Bpe44enKWZwftOMnH6 Xgi/nAiSZa4oG5/NNZYE8QftEGp0OugucXwWPc7v4niwQ6E+JveTvD5zfKRU5nehJK lDxex0ew0pRBUmI64CMLZdUB8tZmzH6kzNu8CuJc= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH AUTOSEL 5.4 007/350] drm: Use EOPNOTSUPP, not ENOTSUPP Date: Tue, 10 Dec 2019 15:58:19 -0500 Message-Id: <20191210210402.8367-7-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191210210402.8367-1-sashal@kernel.org> References: <20191210210402.8367-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sasha Levin , Daniel Vetter , dri-devel@lists.freedesktop.org, =?UTF-8?q?Jos=C3=A9=20Roberto=20de=20Souza?= , Alex Deucher , Daniel Vetter , Sean Paul , Andres Rodriguez Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" RnJvbTogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KClsgVXBzdHJlYW0g Y29tbWl0IGM3NTgxYTQxNGQyODQxM2MxZGQ2ZDExNmQ0NDg1OWI1YTUyZTA5NTAgXQoKLSBpdCdz IHdoYXQgd2UgcmVjb21tZW5kIGluIG91ciBkb2NzOgoKaHR0cHM6Ly9kcmkuZnJlZWRlc2t0b3Au b3JnL2RvY3MvZHJtL2dwdS9kcm0tdWFwaS5odG1sI3JlY29tbWVuZGVkLWlvY3RsLXJldHVybi12 YWx1ZXMKCi0gaXQncyB0aGUgb3ZlcndoZWxtaW5nbHkgdXNlZCBlcnJvciBjb2RlIGZvciAib3Bl cmF0aW9uIG5vdAogIHN1cHBvcnRlZCIsIGF0IGxlYXN0IGluIGRybSBjb3JlIChzbGlnaHRseSBs ZXNzIHNvIGluIGRyaXZlcnMpOgoKJCBnaXQgZ3JlcCBFT1BOT1RTVVBQIC0tIGRyaXZlcnMvZ3B1 L2RybS8qYyB8IHdjIC1sCjgzCiQgZ2l0IGdyZXAgRU5PVFNVUFAgLS0gZHJpdmVycy9ncHUvZHJt LypjIHwgd2MgLWwKNQoKLSBpbmNsdWRlL2xpbnV4L2Vycm5vLmggbWFrZXMgaXQgZmFpcmx5IGNs ZWFyIHRoYXQgdGhlc2UgYXJlIGZvciBuZnN2MwogIChwbHVzIHRoZXkgYWxzbyBoYXZlIGVycm9y IGNvZGVzIGFib3ZlIDUxMiwgd2hpY2ggaXMgdGhlIGJsb2NrIHdpdGgKICBzb21lIHNwZWNpYWwg YmVoYXZpb3VyIC4uLikKCi8qIERlZmluZWQgZm9yIHRoZSBORlN2MyBwcm90b2NvbCAqLwoKSWYg dGhlIGFib3ZlIGlzbid0IHJlZmxlY3RpbmcgY3VycmVudCBwcmFjdGljZSwgdGhlbiBJIGd1ZXNz IHdlIHNob3VsZAphdCBsZWFzdCB1cGRhdGUgdGhlIGRvY3MuCgpOb3JhbGYgY29tbWVudGVkOgoK QmVuIEh1dGNoaW5ncyBtYWRlIHRoaXMgY29tbWVudFsxXSBpbiBhIHRocmVhZCBhYm91dCB1c2Ug b2YgRU5PVFNVUFAgaW4KZHJpdmVyczoKCiAgZ2xpYmMncyBzdHJlcnJvcigpIHJldHVybnMgdGhl c2Ugc3RyaW5ncyBmb3IgRU5PVFNVUFAgYW5kIEVPUE5PVFNVUFAKICByZXNwZWN0aXZlbHk6Cgog ICJVbmtub3duIGVycm9yIDUyNCIKICAiT3BlcmF0aW9uIG5vdCBzdXBwb3J0ZWQiCgpTbyBhdCBs ZWFzdCBmb3IgZXJyb3JzIHJldHVybmVkIHRvIHVzZXJzcGFjZSBFT1BOT1RTVVBQIG1ha2VzIHNl bnNlLgoKSm9zw6kgYXNrZWQ6Cgo+IEhvcGVmdWxseSB0aGlzIHdpbGwgbm90IGJyZWFrIGFueSB1 c2Vyc3BhY2UKCk5vbmUgb2YgdGhlIGZ1bmN0aW9ucyBpbiBkcm1fZWRpZC5jIGFmZmVjdGVkIGJ5 IHRoaXMgcmVhY2ggdXNlcnNwYWNlLAppdCdzIGFsbCBkcml2ZXIgaW50ZXJuYWwuCgpTYW1lIGZv ciB0aGUgbWlwaSBmdW5jdGlvbiwgdGhhdCBlcnJvciBjb2RlIHNob3VsZCBiZSBoYW5kbGVkIGJ5 CmRyaXZlcnMuIERyaXZlcnMgYXJlIHN1cHBvc2VkIHRvIHJlbWFwICJ0aGUgaHcgaXMgb24gZmly ZSIgdG8gRUlPIHdoZW4KcmVwb3J0aW5nIHVwIHRvIHVzZXJzcGFjZSwgYnV0IEkgdGhpbmsgaWYg YSBkcml2ZXIgc2VlcyB0aGlzIGl0IHdvdWxkCmJlIGEgZHJpdmVyIGJ1Zy4KdjI6IEF1Z21lbnQg Y29tbWl0IG1lc3NhZ2Ugd2l0aCBjb21tZW50cyBmcm9tIE5vcmFsZiBhbmQgSm9zw6kKClJldmll d2VkLWJ5OiBKb3PDqSBSb2JlcnRvIGRlIFNvdXphIDxqb3NlLnNvdXphQGludGVsLmNvbT4KQWNr ZWQtYnk6IE5vcmFsZiBUcsO4bm5lcyA8bm9yYWxmQHRyb25uZXMub3JnPgpDYzogSm9zw6kgUm9i ZXJ0byBkZSBTb3V6YSA8am9zZS5zb3V6YUBpbnRlbC5jb20+CkNjOiBNYWFydGVuIExhbmtob3Jz dCA8bWFhcnRlbi5sYW5raG9yc3RAbGludXguaW50ZWwuY29tPgpDYzogTWF4aW1lIFJpcGFyZCA8 bXJpcGFyZEBrZXJuZWwub3JnPgpDYzogU2VhbiBQYXVsIDxzZWFuQHBvb3JseS5ydW4+CkNjOiBB bGV4IERldWNoZXIgPGFsZXhhbmRlci5kZXVjaGVyQGFtZC5jb20+CkNjOiBBbmRyZXMgUm9kcmln dWV6IDxhbmRyZXN4N0BnbWFpbC5jb20+CkNjOiBOb3JhbGYgVHLDuG5uZXMgPG5vcmFsZkB0cm9u bmVzLm9yZz4KU2lnbmVkLW9mZi1ieTogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBpbnRl bC5jb20+Ckxpbms6IGh0dHBzOi8vcGF0Y2h3b3JrLmZyZWVkZXNrdG9wLm9yZy9wYXRjaC9tc2dp ZC8yMDE5MDkwNDE0Mzk0Mi4zMTc1Ni0xLWRhbmllbC52ZXR0ZXJAZmZ3bGwuY2gKU2lnbmVkLW9m Zi1ieTogU2FzaGEgTGV2aW4gPHNhc2hhbEBrZXJuZWwub3JnPgotLS0KIGRyaXZlcnMvZ3B1L2Ry bS9kcm1fZWRpZC5jICAgICB8IDYgKysrLS0tCiBkcml2ZXJzL2dwdS9kcm0vZHJtX21pcGlfZGJp LmMgfCAyICstCiAyIGZpbGVzIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMo LSkKCmRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2VkaWQuYyBiL2RyaXZlcnMvZ3B1 L2RybS9kcm1fZWRpZC5jCmluZGV4IDZiMDE3NzExMmUxOGQuLjNmNTBiODg2NWRiNGMgMTAwNjQ0 Ci0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fZWRpZC5jCisrKyBiL2RyaXZlcnMvZ3B1L2RybS9k cm1fZWRpZC5jCkBAIC0zNzIyLDcgKzM3MjIsNyBAQCBjZWFfZGJfb2Zmc2V0cyhjb25zdCB1OCAq Y2VhLCBpbnQgKnN0YXJ0LCBpbnQgKmVuZCkKIAkJaWYgKCplbmQgPCA0IHx8ICplbmQgPiAxMjcp CiAJCQlyZXR1cm4gLUVSQU5HRTsKIAl9IGVsc2UgewotCQlyZXR1cm4gLUVOT1RTVVBQOworCQly ZXR1cm4gLUVPUE5PVFNVUFA7CiAJfQogCiAJcmV0dXJuIDA7CkBAIC00MTkxLDcgKzQxOTEsNyBA QCBpbnQgZHJtX2VkaWRfdG9fc2FkKHN0cnVjdCBlZGlkICplZGlkLCBzdHJ1Y3QgY2VhX3NhZCAq KnNhZHMpCiAKIAlpZiAoY2VhX3JldmlzaW9uKGNlYSkgPCAzKSB7CiAJCURSTV9ERUJVR19LTVMo IlNBRDogd3JvbmcgQ0VBIHJldmlzaW9uXG4iKTsKLQkJcmV0dXJuIC1FTk9UU1VQUDsKKwkJcmV0 dXJuIC1FT1BOT1RTVVBQOwogCX0KIAogCWlmIChjZWFfZGJfb2Zmc2V0cyhjZWEsICZzdGFydCwg JmVuZCkpIHsKQEAgLTQyNTIsNyArNDI1Miw3IEBAIGludCBkcm1fZWRpZF90b19zcGVha2VyX2Fs bG9jYXRpb24oc3RydWN0IGVkaWQgKmVkaWQsIHU4ICoqc2FkYikKIAogCWlmIChjZWFfcmV2aXNp b24oY2VhKSA8IDMpIHsKIAkJRFJNX0RFQlVHX0tNUygiU0FEOiB3cm9uZyBDRUEgcmV2aXNpb25c biIpOwotCQlyZXR1cm4gLUVOT1RTVVBQOworCQlyZXR1cm4gLUVPUE5PVFNVUFA7CiAJfQogCiAJ aWYgKGNlYV9kYl9vZmZzZXRzKGNlYSwgJnN0YXJ0LCAmZW5kKSkgewpkaWZmIC0tZ2l0IGEvZHJp dmVycy9ncHUvZHJtL2RybV9taXBpX2RiaS5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9taXBpX2Ri aS5jCmluZGV4IGM0ZWUyNzA5YTZmMzIuLmY4MTU0MzE2YTNiMGQgMTAwNjQ0Ci0tLSBhL2RyaXZl cnMvZ3B1L2RybS9kcm1fbWlwaV9kYmkuYworKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX21pcGlf ZGJpLmMKQEAgLTk1NSw3ICs5NTUsNyBAQCBzdGF0aWMgaW50IG1pcGlfZGJpX3R5cGVjMV9jb21t YW5kKHN0cnVjdCBtaXBpX2RiaSAqZGJpLCB1OCAqY21kLAogCWludCByZXQ7CiAKIAlpZiAobWlw aV9kYmlfY29tbWFuZF9pc19yZWFkKGRiaSwgKmNtZCkpCi0JCXJldHVybiAtRU5PVFNVUFA7CisJ CXJldHVybiAtRU9QTk9UU1VQUDsKIAogCU1JUElfREJJX0RFQlVHX0NPTU1BTkQoKmNtZCwgcGFy YW1ldGVycywgbnVtKTsKIAotLSAKMi4yMC4xCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90501C43603 for ; Tue, 10 Dec 2019 21:07:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6019424683 for ; Tue, 10 Dec 2019 21:07:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576012020; bh=ceteDlM2gzudgpK7lNIbnJYzwn+zR/DJXRfsggSRc00=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=wQEAI/oth5lY3GUMYoxoLc+4+fVj1/y4L9SBDkjndopQXeEd8tGoJwFKeURSNvvG5 AeGGf0hgaNwoKBGsCJU5jo9RJUNWAt2G5W8g3oyXFxz7Eh2BSoZ5aKwq6mq6ZwWG8W E9Hd34LbvbdCcBVhbIocjqDgIYGxYlEyEJoMN61c= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727308AbfLJVG7 (ORCPT ); Tue, 10 Dec 2019 16:06:59 -0500 Received: from mail.kernel.org ([198.145.29.99]:49002 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727035AbfLJVEN (ORCPT ); Tue, 10 Dec 2019 16:04:13 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6801221D7D; Tue, 10 Dec 2019 21:04:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576011852; bh=ceteDlM2gzudgpK7lNIbnJYzwn+zR/DJXRfsggSRc00=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nWZLDrdgdmxqvSiASswsIDBFiLH6jJIT7+masRpXwKfUip0Bpe44enKWZwftOMnH6 Xgi/nAiSZa4oG5/NNZYE8QftEGp0OugucXwWPc7v4niwQ6E+JveTvD5zfKRU5nehJK lDxex0ew0pRBUmI64CMLZdUB8tZmzH6kzNu8CuJc= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Daniel Vetter , =?UTF-8?q?Jos=C3=A9=20Roberto=20de=20Souza?= , =?UTF-8?q?Noralf=20Tr=C3=B8nnes?= , Maarten Lankhorst , Maxime Ripard , Sean Paul , Alex Deucher , Andres Rodriguez , Daniel Vetter , Sasha Levin , dri-devel@lists.freedesktop.org Subject: [PATCH AUTOSEL 5.4 007/350] drm: Use EOPNOTSUPP, not ENOTSUPP Date: Tue, 10 Dec 2019 15:58:19 -0500 Message-Id: <20191210210402.8367-7-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191210210402.8367-1-sashal@kernel.org> References: <20191210210402.8367-1-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Daniel Vetter [ Upstream commit c7581a414d28413c1dd6d116d44859b5a52e0950 ] - it's what we recommend in our docs: https://dri.freedesktop.org/docs/drm/gpu/drm-uapi.html#recommended-ioctl-return-values - it's the overwhelmingly used error code for "operation not supported", at least in drm core (slightly less so in drivers): $ git grep EOPNOTSUPP -- drivers/gpu/drm/*c | wc -l 83 $ git grep ENOTSUPP -- drivers/gpu/drm/*c | wc -l 5 - include/linux/errno.h makes it fairly clear that these are for nfsv3 (plus they also have error codes above 512, which is the block with some special behaviour ...) /* Defined for the NFSv3 protocol */ If the above isn't reflecting current practice, then I guess we should at least update the docs. Noralf commented: Ben Hutchings made this comment[1] in a thread about use of ENOTSUPP in drivers: glibc's strerror() returns these strings for ENOTSUPP and EOPNOTSUPP respectively: "Unknown error 524" "Operation not supported" So at least for errors returned to userspace EOPNOTSUPP makes sense. José asked: > Hopefully this will not break any userspace None of the functions in drm_edid.c affected by this reach userspace, it's all driver internal. Same for the mipi function, that error code should be handled by drivers. Drivers are supposed to remap "the hw is on fire" to EIO when reporting up to userspace, but I think if a driver sees this it would be a driver bug. v2: Augment commit message with comments from Noralf and José Reviewed-by: José Roberto de Souza Acked-by: Noralf Trønnes Cc: José Roberto de Souza Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Sean Paul Cc: Alex Deucher Cc: Andres Rodriguez Cc: Noralf Trønnes Signed-off-by: Daniel Vetter Link: https://patchwork.freedesktop.org/patch/msgid/20190904143942.31756-1-daniel.vetter@ffwll.ch Signed-off-by: Sasha Levin --- drivers/gpu/drm/drm_edid.c | 6 +++--- drivers/gpu/drm/drm_mipi_dbi.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 6b0177112e18d..3f50b8865db4c 100644 --- a/drivers/gpu/drm/drm_edid.c +++ b/drivers/gpu/drm/drm_edid.c @@ -3722,7 +3722,7 @@ cea_db_offsets(const u8 *cea, int *start, int *end) if (*end < 4 || *end > 127) return -ERANGE; } else { - return -ENOTSUPP; + return -EOPNOTSUPP; } return 0; @@ -4191,7 +4191,7 @@ int drm_edid_to_sad(struct edid *edid, struct cea_sad **sads) if (cea_revision(cea) < 3) { DRM_DEBUG_KMS("SAD: wrong CEA revision\n"); - return -ENOTSUPP; + return -EOPNOTSUPP; } if (cea_db_offsets(cea, &start, &end)) { @@ -4252,7 +4252,7 @@ int drm_edid_to_speaker_allocation(struct edid *edid, u8 **sadb) if (cea_revision(cea) < 3) { DRM_DEBUG_KMS("SAD: wrong CEA revision\n"); - return -ENOTSUPP; + return -EOPNOTSUPP; } if (cea_db_offsets(cea, &start, &end)) { diff --git a/drivers/gpu/drm/drm_mipi_dbi.c b/drivers/gpu/drm/drm_mipi_dbi.c index c4ee2709a6f32..f8154316a3b0d 100644 --- a/drivers/gpu/drm/drm_mipi_dbi.c +++ b/drivers/gpu/drm/drm_mipi_dbi.c @@ -955,7 +955,7 @@ static int mipi_dbi_typec1_command(struct mipi_dbi *dbi, u8 *cmd, int ret; if (mipi_dbi_command_is_read(dbi, *cmd)) - return -ENOTSUPP; + return -EOPNOTSUPP; MIPI_DBI_DEBUG_COMMAND(*cmd, parameters, num); -- 2.20.1