From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B70CCC43603 for ; Tue, 10 Dec 2019 22:07:24 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 866F42053B for ; Tue, 10 Dec 2019 22:07:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="MLqUObJ8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 866F42053B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BC29F6E9B7; Tue, 10 Dec 2019 22:07:22 +0000 (UTC) Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by gabe.freedesktop.org (Postfix) with ESMTPS id 959EB6E9A8 for ; Tue, 10 Dec 2019 22:07:21 +0000 (UTC) Received: by mail-wr1-x442.google.com with SMTP id d16so21822131wre.10 for ; Tue, 10 Dec 2019 14:07:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ptJt8UpVUt+TvsYxm4J67mpF+rXHgp/cv7qqisG2GRA=; b=MLqUObJ81drA0eXJYbMdW3P0zg6k8UvIqavv4+NEHMpFk4uQOUZM7AGGn3WZh9Rzhw 3n7GQu7QWCgx5eJF+hEeogaeMdL8wEC9aboR36ORSxBVWW0QUGNUL9e2coaTG/3YiJf8 EZcOhd0479ECh+LpXm5g9vv7B9kML+CXHgzdw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ptJt8UpVUt+TvsYxm4J67mpF+rXHgp/cv7qqisG2GRA=; b=ndYI0EndcszxHthgVaFCa1uo5ENN08qEYc126BsDlgmsED7m3knxWDO6bwlcr08Ieb g4sSLrqtl410lab1DqxHUy+JZBdHUN3N8xhOmz8UUasQ7xZxLl9n1tcSfJLiyYqds6Ua 9iPyRcnrxJAhzTZ0F4/m2JxXJGKZtjhMbZQjVQggMi5U4V4Ykg7vqXMnskif+vNevQk5 pXogqDaCEjobG1nttZiztZ1CYVt/Rc9wYIUhDU5fOitue54KFiYj3X2GDfzMGnSPq3RC zabas9FHbaVZmYt3XihDjbQhwo8jIuhNC6V5Yfk6pZ0jf+l1HVfmf3KsyzJqzAisVCL1 AlTQ== X-Gm-Message-State: APjAAAW4+BqtFwtb9SmdpL5GW6teEb7XepXcN8SPmNXj4TJQ/in00LCE 7K4PAjV51TzRbxwSXCkm9IqPYw== X-Google-Smtp-Source: APXvYqynFrQ1Q24pQQUBBH9773aGTAM/uCSmsEgciUNVh+e4sR+Ktxs67mwOB7Q0M250Fg24lexTWQ== X-Received: by 2002:adf:db41:: with SMTP id f1mr5868055wrj.392.1576015640314; Tue, 10 Dec 2019 14:07:20 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:564b:0:7567:bb67:3d7f:f863]) by smtp.gmail.com with ESMTPSA id c15sm4822185wrt.1.2019.12.10.14.07.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Dec 2019 14:07:19 -0800 (PST) Date: Tue, 10 Dec 2019 23:07:17 +0100 From: Daniel Vetter To: Jani Nikula Subject: Re: [PATCH 1/8] drm/print: introduce new struct drm_device based logging macros Message-ID: <20191210220717.GW624164@phenom.ffwll.local> References: <20191210123050.8799-1-jani.nikula@intel.com> <87o8wge4va.fsf@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87o8wge4va.fsf@intel.com> X-Operating-System: Linux phenom 5.3.0-2-amd64 User-Agent: Mutt/1.12.2 (2019-09-21) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sam Ravnborg , intel-gfx@lists.freedesktop.org, Sean Paul , dri-devel@lists.freedesktop.org, Rodrigo Vivi Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Dec 10, 2019 at 02:34:33PM +0200, Jani Nikula wrote: > On Tue, 10 Dec 2019, Jani Nikula wrote: > > Add new struct drm_device based logging macros modeled after the core > > kernel device based logging macros. These would be preferred over the > > drm printk and struct device based macros in drm code, where possible. > > As to cover letter, patches 2-8 using the logging macros introduced here > are just the beginning. It's not trivial to write a cocci script to dig > up struct drm_device * where there is none, so much of it may need to be > done manually. But we could start here. Can you pls do a patch for todo.rst to adjust the existing task to the new flavour of favorited debug printing? If cocci doesn't work we can at least throw random interns at this for starter tasks :-) -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E759FC43603 for ; Tue, 10 Dec 2019 22:07:22 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B3D9A2053B for ; Tue, 10 Dec 2019 22:07:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="MLqUObJ8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B3D9A2053B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 440C56E9A8; Tue, 10 Dec 2019 22:07:22 +0000 (UTC) Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by gabe.freedesktop.org (Postfix) with ESMTPS id AA2B06E9B4 for ; Tue, 10 Dec 2019 22:07:21 +0000 (UTC) Received: by mail-wr1-x441.google.com with SMTP id z7so21750001wrl.13 for ; Tue, 10 Dec 2019 14:07:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ptJt8UpVUt+TvsYxm4J67mpF+rXHgp/cv7qqisG2GRA=; b=MLqUObJ81drA0eXJYbMdW3P0zg6k8UvIqavv4+NEHMpFk4uQOUZM7AGGn3WZh9Rzhw 3n7GQu7QWCgx5eJF+hEeogaeMdL8wEC9aboR36ORSxBVWW0QUGNUL9e2coaTG/3YiJf8 EZcOhd0479ECh+LpXm5g9vv7B9kML+CXHgzdw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ptJt8UpVUt+TvsYxm4J67mpF+rXHgp/cv7qqisG2GRA=; b=jdX4nBt1YAe0AjZMrnHeitM79b/cDJqiiLz9sJkncOKLtk0ot9FM5O9FDEy+c0PDhc eur2qeZnw4Q1ynFH1k2Cuf9r8mvtwdDcaKNpVjd0mYlJEfaXyaaFljrQfbnIQf5a8jxa koT6lwUJ1bOSqOT0ViqI/jX26zJMGGTnsTAeFVwRw6PLhidCgbc4HB7uhP4EYDrrEwBd qLTGmhpk1RrCKWtPPtzP4eNrKI47t7XGX2709yPa4PpqUfMcEPHXxADvTy9nfzAU0YcH kzMThsRBdkyNYjN/D4GIjcWN6v4uw5Yv9uaUFa6qaV28iXQvGc4pqiYgAub/jdrTk7Y5 7cbQ== X-Gm-Message-State: APjAAAUK6yOyj5al6VbPqavUvx/2r17BqItwha5xThpYHTzLDaXSfh66 OeiKMx8jgOxaiOiEurCnFS+0vw== X-Google-Smtp-Source: APXvYqynFrQ1Q24pQQUBBH9773aGTAM/uCSmsEgciUNVh+e4sR+Ktxs67mwOB7Q0M250Fg24lexTWQ== X-Received: by 2002:adf:db41:: with SMTP id f1mr5868055wrj.392.1576015640314; Tue, 10 Dec 2019 14:07:20 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:564b:0:7567:bb67:3d7f:f863]) by smtp.gmail.com with ESMTPSA id c15sm4822185wrt.1.2019.12.10.14.07.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Dec 2019 14:07:19 -0800 (PST) Date: Tue, 10 Dec 2019 23:07:17 +0100 From: Daniel Vetter To: Jani Nikula Message-ID: <20191210220717.GW624164@phenom.ffwll.local> References: <20191210123050.8799-1-jani.nikula@intel.com> <87o8wge4va.fsf@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87o8wge4va.fsf@intel.com> X-Operating-System: Linux phenom 5.3.0-2-amd64 User-Agent: Mutt/1.12.2 (2019-09-21) Subject: Re: [Intel-gfx] [PATCH 1/8] drm/print: introduce new struct drm_device based logging macros X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sam Ravnborg , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, Dec 10, 2019 at 02:34:33PM +0200, Jani Nikula wrote: > On Tue, 10 Dec 2019, Jani Nikula wrote: > > Add new struct drm_device based logging macros modeled after the core > > kernel device based logging macros. These would be preferred over the > > drm printk and struct device based macros in drm code, where possible. > > As to cover letter, patches 2-8 using the logging macros introduced here > are just the beginning. It's not trivial to write a cocci script to dig > up struct drm_device * where there is none, so much of it may need to be > done manually. But we could start here. Can you pls do a patch for todo.rst to adjust the existing task to the new flavour of favorited debug printing? If cocci doesn't work we can at least throw random interns at this for starter tasks :-) -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx