From: Martin Varghese <martinvarghesenokia@gmail.com>
To: Jiri Benc <jbenc@redhat.com>
Cc: netdev@vger.kernel.org, pshelar@ovn.org, davem@davemloft.net,
scott.drennan@nokia.com, martin.varghese@nokia.com
Subject: Re: [PATCH net-next 3/3] openvswitch: New MPLS actions for layer 2 tunnelling
Date: Wed, 11 Dec 2019 05:21:32 +0530 [thread overview]
Message-ID: <20191210235132.GA2687@martin-VirtualBox> (raw)
In-Reply-To: <20191210161122.0c329d9b@redhat.com>
On Tue, Dec 10, 2019 at 04:11:22PM +0100, Jiri Benc wrote:
> On Tue, 10 Dec 2019 13:46:41 +0530, Martin Varghese wrote:
> > +static int push_ptap_mpls(struct sk_buff *skb, struct sw_flow_key *key,
> > +static int ptap_pop_mpls(struct sk_buff *skb, struct sw_flow_key *key,
>
> The names are inconsistent (*_ptap_mpls vs. ptap_*_mpls). Otherwise,
> this looks good to me.
>
Thanks Jiri
>
next prev parent reply other threads:[~2019-12-10 23:51 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-10 8:15 [PATCH net-next 0/3] New openvswitch MPLS actions for layer 2 tunnelling Martin Varghese
2019-12-10 8:15 ` [PATCH net-next 1/3] net: skb_mpls_push() modified to allow MPLS header push at start of packet Martin Varghese
2019-12-11 1:43 ` David Miller
2019-12-11 3:06 ` Varghese, Martin (Nokia - IN/Bangalore)
2019-12-10 8:16 ` [PATCH net-next 2/3] net: Rephrased comments section of skb_mpls_pop() Martin Varghese
2019-12-10 8:16 ` [PATCH net-next 3/3] openvswitch: New MPLS actions for layer 2 tunnelling Martin Varghese
2019-12-10 15:11 ` Jiri Benc
2019-12-10 23:51 ` Martin Varghese [this message]
2019-12-10 21:22 ` Pravin Shelar
2019-12-11 0:02 ` Martin Varghese
2019-12-11 6:15 ` Pravin Shelar
2019-12-11 15:39 ` Martin Varghese
2019-12-12 4:19 ` Pravin Shelar
2019-12-12 16:02 ` Martin Varghese
2019-12-13 3:15 ` Pravin Shelar
2019-12-13 3:53 ` Martin Varghese
2019-12-13 7:57 ` Pravin Shelar
2019-12-11 6:15 ` Pravin Shelar
2019-12-11 15:42 ` Martin Varghese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191210235132.GA2687@martin-VirtualBox \
--to=martinvarghesenokia@gmail.com \
--cc=davem@davemloft.net \
--cc=jbenc@redhat.com \
--cc=martin.varghese@nokia.com \
--cc=netdev@vger.kernel.org \
--cc=pshelar@ovn.org \
--cc=scott.drennan@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.