From: Minchan Kim <minchan@kernel.org>
To: Oleksandr Natalenko <oleksandr@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-api@vger.kernel.org
Subject: Re: [PATCH NOTFORMERGE 0/5] Extend remote madvise API to KSM hints
Date: Tue, 10 Dec 2019 17:35:03 -0800 [thread overview]
Message-ID: <20191211013503.GA134194@google.com> (raw)
In-Reply-To: <20191210104939.jauw5hnv3smhtvtr@butterfly.localdomain>
Hi Oleksandr,
On Tue, Dec 10, 2019 at 11:49:39AM +0100, Oleksandr Natalenko wrote:
> Hello, Minchan.
>
> On Sun, Jun 16, 2019 at 10:58:30AM +0200, Oleksandr Natalenko wrote:
> > This is a set of commits based on our discussion on your submission [1].
> >
> > First 2 implement minor suggestions just for you to not forget to take
> > them into account.
> >
> > uio.h inclusion was needed for me to be able to compile your series
> > successfully. Also please note I had to enable "Transparent Hugepage
> > Support" as well as "Enable idle page tracking" options, otherwise the
> > build failed. I guess this can be addressed by you better since the
> > errors are introduced with MADV_COLD introduction.
> >
> > Last 2 commits are the actual KSM hints enablement. The first one
> > implements additional check for the case where the mmap_sem is taken for
> > write, and the second one just allows KSM hints to be used by the remote
> > interface.
> >
> > I'm not Cc'ing else anyone except two mailing lists to not distract
> > people unnecessarily. If you are fine with this addition, please use it
> > for your next iteration of process_madvise(), and then you'll Cc all the
> > people needed.
> >
> > Thanks.
> >
> > [1] https://lore.kernel.org/lkml/20190531064313.193437-1-minchan@kernel.org/
> >
> > Oleksandr Natalenko (5):
> > mm: rename madvise_core to madvise_common
> > mm: revert madvise_inject_error line split
> > mm: include uio.h to madvise.c
> > mm/madvise: employ mmget_still_valid for write lock
> > mm/madvise: allow KSM hints for remote API
> >
> > mm/madvise.c | 23 ++++++++++++++---------
> > 1 file changed, 14 insertions(+), 9 deletions(-)
> >
> > --
> > 2.22.0
> >
>
> This is a gentle ping. Are you still planning to submit process_madvise() solution?
I'm really sorry for being slow progress.
I am stuck with internal stuff of company.
I will do best effort to send it within one or two weeks.
Thanks.
prev parent reply other threads:[~2019-12-11 1:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-16 8:58 [PATCH NOTFORMERGE 0/5] Extend remote madvise API to KSM hints Oleksandr Natalenko
2019-06-16 8:58 ` [PATCH NOTFORMERGE 1/5] mm: rename madvise_core to madvise_common Oleksandr Natalenko
2019-06-16 8:58 ` [PATCH NOTFORMERGE 2/5] mm: revert madvise_inject_error line split Oleksandr Natalenko
2019-06-16 8:58 ` [PATCH NOTFORMERGE 3/5] mm: include uio.h to madvise.c Oleksandr Natalenko
2019-06-16 8:58 ` [PATCH NOTFORMERGE 4/5] mm/madvise: employ mmget_still_valid for write lock Oleksandr Natalenko
2019-06-16 8:58 ` [PATCH NOTFORMERGE 5/5] mm/madvise: allow KSM hints for remote API Oleksandr Natalenko
2019-12-10 10:49 ` [PATCH NOTFORMERGE 0/5] Extend remote madvise API to KSM hints Oleksandr Natalenko
2019-12-11 1:35 ` Minchan Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191211013503.GA134194@google.com \
--to=minchan@kernel.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=oleksandr@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.