Re: Insufficiently documented deprecated command arguments

[Kevin Wolf <kwolf@redhat.com>]

Am 11.12.2019 um 10:33 hat Peter Krempa geschrieben:
> On Wed, Dec 11, 2019 at 09:12:41 +0100, Markus Armbruster wrote:
> >     Commit 7a9877a026 "block: Accept device model name for
> >     block_set_io_throttle" (v2.8.0) deprecated block_set_io_throttle
> >     argument @device.
> 
> This one is more complex. The command is used both in 'blockdev' and in
> 'drive' mode:
> 
> In 'drive' mode we pass the alias of the 'drive' as the @device
> argument.
> 
> In 'blockdev' mode we pass the qom name as @id

Any reason you couldn't use the QOM name even in 'drive' mode for any
QEMU version that has the @id option?

> >     Commit c42e8742f5 "block: Use JSON null instead of "" to disable
> >     backing file" (v2.10.0) deprecated blockdev-add empty string
> >     argument @backing.
> 
> This is used in 'blockdev' mode only and we always pass the JSON null or
> a node name string.

Here the thing to consider might be that JSON null isn't easy to use on
the command line for manual users.

> >     These were missed in commit eb22aeca65 "docs: document deprecation
> >     policy & deprecated features in appendix" (v2.10.0).
> > 
> >     Commit 3c605f4074 "commit: Add top-node/base-node options" (v3.1.0)
> >     deprecated block-commit arguments @base and @top.
> 
> This command also has two modes:
> 
> In 'drive' mode we pass in path strings as @base and @ top.
> 
> In 'blockdev' mode we pass in nodenames as @base-node and @top-node.
> 
> Starting from qemu-4.2 libvirt uses 'blockdev' mode for VMs unless an SD
> card is configured as we didn't convert to the '-device' approach for
> those as AFAIK not everything is possible to be converted.

Hm... I guess in 'drive' mode, you stil don't assign node names, so you
actually have to rely on paths?

Kevin