From: Daniel Borkmann <daniel@iogearbox.net>
To: "Toke Høiland-Jørgensen" <toke@redhat.com>
Cc: Alexei Starovoitov <alexei.starovoitov@gmail.com>,
lkml <linux-kernel@vger.kernel.org>,
netdev@vger.kernel.org, bpf@vger.kernel.org,
Martin Lau <kafai@fb.com>
Subject: Re: [PATCH bpf v2] bpftool: Don't crash on missing jited insns or ksyms
Date: Wed, 11 Dec 2019 14:01:47 +0100 [thread overview]
Message-ID: <20191211130147.GA23383@linux.fritz.box> (raw)
In-Reply-To: <20191210181412.151226-1-toke@redhat.com>
On Tue, Dec 10, 2019 at 07:14:12PM +0100, Toke Høiland-Jørgensen wrote:
> When the kptr_restrict sysctl is set, the kernel can fail to return
> jited_ksyms or jited_prog_insns, but still have positive values in
> nr_jited_ksyms and jited_prog_len. This causes bpftool to crash when trying
> to dump the program because it only checks the len fields not the actual
> pointers to the instructions and ksyms.
>
> Fix this by adding the missing checks.
>
> Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>
Applied, thanks!
prev parent reply other threads:[~2019-12-11 13:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-10 18:14 [PATCH bpf v2] bpftool: Don't crash on missing jited insns or ksyms Toke Høiland-Jørgensen
2019-12-10 18:21 ` Martin Lau
2019-12-10 20:54 ` Jakub Kicinski
2019-12-10 21:09 ` Toke Høiland-Jørgensen
2019-12-10 21:24 ` Jakub Kicinski
2019-12-10 21:31 ` Alexei Starovoitov
2019-12-10 21:52 ` Jakub Kicinski
2019-12-10 22:53 ` Alexei Starovoitov
2019-12-11 13:08 ` Daniel Borkmann
2019-12-11 13:20 ` Toke Høiland-Jørgensen
2019-12-11 13:33 ` Daniel Borkmann
2019-12-11 13:01 ` Daniel Borkmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191211130147.GA23383@linux.fritz.box \
--to=daniel@iogearbox.net \
--cc=alexei.starovoitov@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=kafai@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.