From: Venkata Sandeep Dhanalakota <venkata.s.dhanalakota@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Use the i915_device name for identifying our request fences
Date: Wed, 11 Dec 2019 07:59:09 -0800 [thread overview]
Message-ID: <20191211155908.GC47225@intel.com> (raw)
In-Reply-To: <20191211150204.133471-1-chris@chris-wilson.co.uk>
On 19/12/11 03:02, Chris Wilson wrote:
> Use the dev_name(i915) to identify the requests for debugging, so we can
> tell different device timelines apart.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Venkata Sandeep Dhanalakota <venkata.s.dhanalakota@intel.com>
> ---
> drivers/gpu/drm/i915/i915_request.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_request.c b/drivers/gpu/drm/i915/i915_request.c
> index a6238c626a16..9646e02edea3 100644
> --- a/drivers/gpu/drm/i915/i915_request.c
> +++ b/drivers/gpu/drm/i915/i915_request.c
> @@ -57,7 +57,7 @@ static struct i915_global_request {
>
> static const char *i915_fence_get_driver_name(struct dma_fence *fence)
> {
> - return "i915";
> + return dev_name(to_request(fence)->i915->drm.dev);
> }
>
Sure, should we also update i915_fence_get_timeline_name()
return to_request(fence)->gem_context->name ?:
i915_fence_get_driver_name(fence);
> static const char *i915_fence_get_timeline_name(struct dma_fence *fence)
> --
> 2.24.0
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-12-11 15:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 15:02 [Intel-gfx] [PATCH] drm/i915: Use the i915_device name for identifying our request fences Chris Wilson
2019-12-11 15:59 ` Venkata Sandeep Dhanalakota [this message]
2019-12-11 16:07 ` Chris Wilson
2019-12-11 16:12 ` Venkata Sandeep Dhanalakota
2019-12-11 21:18 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2019-12-11 22:02 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2019-12-12 8:17 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191211155908.GC47225@intel.com \
--to=venkata.s.dhanalakota@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.