From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67D5CC00454 for ; Wed, 11 Dec 2019 16:12:18 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4266F2173E for ; Wed, 11 Dec 2019 16:12:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4266F2173E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D5B6B6E110; Wed, 11 Dec 2019 16:12:17 +0000 (UTC) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id C04F46E110 for ; Wed, 11 Dec 2019 16:12:16 +0000 (UTC) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Dec 2019 08:12:15 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,301,1571727600"; d="scan'208";a="414905804" Received: from linux.fm.intel.com (HELO intel.com) ([10.1.27.42]) by fmsmga006.fm.intel.com with ESMTP; 11 Dec 2019 08:12:15 -0800 Date: Wed, 11 Dec 2019 08:12:15 -0800 From: Venkata Sandeep Dhanalakota To: Chris Wilson Message-ID: <20191211161215.GD47225@intel.com> References: <20191211150204.133471-1-chris@chris-wilson.co.uk> <20191211155908.GC47225@intel.com> <157608042677.27099.2108685443689165611@skylake-alporthouse-com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <157608042677.27099.2108685443689165611@skylake-alporthouse-com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [Intel-gfx] [PATCH] drm/i915: Use the i915_device name for identifying our request fences X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 19/12/11 04:07, Chris Wilson wrote: > Quoting Venkata Sandeep Dhanalakota (2019-12-11 15:59:09) > > On 19/12/11 03:02, Chris Wilson wrote: > > > Use the dev_name(i915) to identify the requests for debugging, so we can > > > tell different device timelines apart. > > > > > > Signed-off-by: Chris Wilson > > > Cc: Venkata Sandeep Dhanalakota > > > --- > > > drivers/gpu/drm/i915/i915_request.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/gpu/drm/i915/i915_request.c b/drivers/gpu/drm/i915/i915_request.c > > > index a6238c626a16..9646e02edea3 100644 > > > --- a/drivers/gpu/drm/i915/i915_request.c > > > +++ b/drivers/gpu/drm/i915/i915_request.c > > > @@ -57,7 +57,7 @@ static struct i915_global_request { > > > > > > static const char *i915_fence_get_driver_name(struct dma_fence *fence) > > > { > > > - return "i915"; > > > + return dev_name(to_request(fence)->i915->drm.dev); > > > } > > > > > Sure, should we also update i915_fence_get_timeline_name() > > return to_request(fence)->gem_context->name ?: > > i915_fence_get_driver_name(fence); > > No need really. It's either a user context or a kernel context, the less > said to userspace about internals the better. It will be presented as > > 00:00:02.00 i915::[i915] (or something like that) > > If you would rather that "[i915]" be "[k]" or probably better yet "[" > DRIVER_NAME "]" got it, having "[i915]" makes sense. Reviewed-by: Venkata Sandeep Dhanalakota > -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx