From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Date: Wed, 11 Dec 2019 16:23:22 +0000 Subject: Re: [PATCH][next] drm/i915: remove redundant checks for a null fb pointer Message-Id: <20191211162322.GL1208@intel.com> List-Id: References: <20191210142349.333171-1-colin.king@canonical.com> In-Reply-To: <20191210142349.333171-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: Colin King Cc: David Airlie , intel-gfx@lists.freedesktop.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rodrigo Vivi On Tue, Dec 10, 2019 at 02:23:49PM +0000, Colin King wrote: > From: Colin Ian King >=20 > A prior check and return when pointer fb is null makes > subsequent null checks on fb redundant. Remove the redundant > null checks. >=20 > Addresses-Coverity: ("Logically dead code") > Signed-off-by: Colin Ian King > --- > drivers/gpu/drm/i915/i915_debugfs.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i= 915_debugfs.c > index 062e5bef637a..a48478be6e8f 100644 > --- a/drivers/gpu/drm/i915/i915_debugfs.c > +++ b/drivers/gpu/drm/i915/i915_debugfs.c > @@ -2600,8 +2600,8 @@ static void intel_plane_hw_info(struct seq_file *m,= struct intel_plane *plane) > plane_state->hw.rotation); > =20 > seq_printf(m, "\t\thw: fb=3D%d,%s,%dx%d, visible=3D%s, src=3D" DRM_RECT= _FP_FMT ", dst=3D" DRM_RECT_FMT ", rotation=3D%s\n", > - fb ? fb->base.id : 0, fb ? format_name.str : "n/a", > - fb ? fb->width : 0, fb ? fb->height : 0, > + fb->base.id, format_name.str, > + fb->width, fb->height, Thanks. Pushed to drm-intel-next-queued. > yesno(plane_state->uapi.visible), > DRM_RECT_FP_ARG(&plane_state->uapi.src), > DRM_RECT_ARG(&plane_state->uapi.dst), > --=20 > 2.24.0 >=20 > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel --=20 Ville Syrj=E4l=E4 Intel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 661F2C43603 for ; Wed, 11 Dec 2019 16:23:29 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4642D21556 for ; Wed, 11 Dec 2019 16:23:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4642D21556 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AAC256EB7E; Wed, 11 Dec 2019 16:23:28 +0000 (UTC) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 47B736EB7E; Wed, 11 Dec 2019 16:23:27 +0000 (UTC) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Dec 2019 08:23:26 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,301,1571727600"; d="scan'208";a="264926006" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by FMSMGA003.fm.intel.com with SMTP; 11 Dec 2019 08:23:23 -0800 Received: by stinkbox (sSMTP sendmail emulation); Wed, 11 Dec 2019 18:23:22 +0200 Date: Wed, 11 Dec 2019 18:23:22 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Colin King Subject: Re: [PATCH][next] drm/i915: remove redundant checks for a null fb pointer Message-ID: <20191211162322.GL1208@intel.com> References: <20191210142349.333171-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191210142349.333171-1-colin.king@canonical.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , intel-gfx@lists.freedesktop.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rodrigo Vivi Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Dec 10, 2019 at 02:23:49PM +0000, Colin King wrote: > From: Colin Ian King > = > A prior check and return when pointer fb is null makes > subsequent null checks on fb redundant. Remove the redundant > null checks. > = > Addresses-Coverity: ("Logically dead code") > Signed-off-by: Colin Ian King > --- > drivers/gpu/drm/i915/i915_debugfs.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > = > diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i= 915_debugfs.c > index 062e5bef637a..a48478be6e8f 100644 > --- a/drivers/gpu/drm/i915/i915_debugfs.c > +++ b/drivers/gpu/drm/i915/i915_debugfs.c > @@ -2600,8 +2600,8 @@ static void intel_plane_hw_info(struct seq_file *m,= struct intel_plane *plane) > plane_state->hw.rotation); > = > seq_printf(m, "\t\thw: fb=3D%d,%s,%dx%d, visible=3D%s, src=3D" DRM_RECT= _FP_FMT ", dst=3D" DRM_RECT_FMT ", rotation=3D%s\n", > - fb ? fb->base.id : 0, fb ? format_name.str : "n/a", > - fb ? fb->width : 0, fb ? fb->height : 0, > + fb->base.id, format_name.str, > + fb->width, fb->height, Thanks. Pushed to drm-intel-next-queued. > yesno(plane_state->uapi.visible), > DRM_RECT_FP_ARG(&plane_state->uapi.src), > DRM_RECT_ARG(&plane_state->uapi.dst), > -- = > 2.24.0 > = > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- = Ville Syrj=E4l=E4 Intel _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA4B9C3F68F for ; Wed, 11 Dec 2019 16:23:33 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BEDAE21556 for ; Wed, 11 Dec 2019 16:23:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BEDAE21556 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DAA076EB81; Wed, 11 Dec 2019 16:23:28 +0000 (UTC) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 47B736EB7E; Wed, 11 Dec 2019 16:23:27 +0000 (UTC) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Dec 2019 08:23:26 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,301,1571727600"; d="scan'208";a="264926006" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by FMSMGA003.fm.intel.com with SMTP; 11 Dec 2019 08:23:23 -0800 Received: by stinkbox (sSMTP sendmail emulation); Wed, 11 Dec 2019 18:23:22 +0200 Date: Wed, 11 Dec 2019 18:23:22 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Colin King Message-ID: <20191211162322.GL1208@intel.com> References: <20191210142349.333171-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191210142349.333171-1-colin.king@canonical.com> User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [Intel-gfx] [PATCH][next] drm/i915: remove redundant checks for a null fb pointer X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , intel-gfx@lists.freedesktop.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, Dec 10, 2019 at 02:23:49PM +0000, Colin King wrote: > From: Colin Ian King > = > A prior check and return when pointer fb is null makes > subsequent null checks on fb redundant. Remove the redundant > null checks. > = > Addresses-Coverity: ("Logically dead code") > Signed-off-by: Colin Ian King > --- > drivers/gpu/drm/i915/i915_debugfs.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > = > diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i= 915_debugfs.c > index 062e5bef637a..a48478be6e8f 100644 > --- a/drivers/gpu/drm/i915/i915_debugfs.c > +++ b/drivers/gpu/drm/i915/i915_debugfs.c > @@ -2600,8 +2600,8 @@ static void intel_plane_hw_info(struct seq_file *m,= struct intel_plane *plane) > plane_state->hw.rotation); > = > seq_printf(m, "\t\thw: fb=3D%d,%s,%dx%d, visible=3D%s, src=3D" DRM_RECT= _FP_FMT ", dst=3D" DRM_RECT_FMT ", rotation=3D%s\n", > - fb ? fb->base.id : 0, fb ? format_name.str : "n/a", > - fb ? fb->width : 0, fb ? fb->height : 0, > + fb->base.id, format_name.str, > + fb->width, fb->height, Thanks. Pushed to drm-intel-next-queued. > yesno(plane_state->uapi.visible), > DRM_RECT_FP_ARG(&plane_state->uapi.src), > DRM_RECT_ARG(&plane_state->uapi.dst), > -- = > 2.24.0 > = > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- = Ville Syrj=E4l=E4 Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03C33C2D0C6 for ; Wed, 11 Dec 2019 16:23:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CE9BC2073D for ; Wed, 11 Dec 2019 16:23:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730673AbfLKQX1 (ORCPT ); Wed, 11 Dec 2019 11:23:27 -0500 Received: from mga05.intel.com ([192.55.52.43]:17304 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730062AbfLKQX1 (ORCPT ); Wed, 11 Dec 2019 11:23:27 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Dec 2019 08:23:26 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,301,1571727600"; d="scan'208";a="264926006" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by FMSMGA003.fm.intel.com with SMTP; 11 Dec 2019 08:23:23 -0800 Received: by stinkbox (sSMTP sendmail emulation); Wed, 11 Dec 2019 18:23:22 +0200 Date: Wed, 11 Dec 2019 18:23:22 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Colin King Cc: Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , David Airlie , Daniel Vetter , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][next] drm/i915: remove redundant checks for a null fb pointer Message-ID: <20191211162322.GL1208@intel.com> References: <20191210142349.333171-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20191210142349.333171-1-colin.king@canonical.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 10, 2019 at 02:23:49PM +0000, Colin King wrote: > From: Colin Ian King > > A prior check and return when pointer fb is null makes > subsequent null checks on fb redundant. Remove the redundant > null checks. > > Addresses-Coverity: ("Logically dead code") > Signed-off-by: Colin Ian King > --- > drivers/gpu/drm/i915/i915_debugfs.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c > index 062e5bef637a..a48478be6e8f 100644 > --- a/drivers/gpu/drm/i915/i915_debugfs.c > +++ b/drivers/gpu/drm/i915/i915_debugfs.c > @@ -2600,8 +2600,8 @@ static void intel_plane_hw_info(struct seq_file *m, struct intel_plane *plane) > plane_state->hw.rotation); > > seq_printf(m, "\t\thw: fb=%d,%s,%dx%d, visible=%s, src=" DRM_RECT_FP_FMT ", dst=" DRM_RECT_FMT ", rotation=%s\n", > - fb ? fb->base.id : 0, fb ? format_name.str : "n/a", > - fb ? fb->width : 0, fb ? fb->height : 0, > + fb->base.id, format_name.str, > + fb->width, fb->height, Thanks. Pushed to drm-intel-next-queued. > yesno(plane_state->uapi.visible), > DRM_RECT_FP_ARG(&plane_state->uapi.src), > DRM_RECT_ARG(&plane_state->uapi.dst), > -- > 2.24.0 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Ville Syrjälä Intel