From: Stephan Gerhold <stephan@gerhold.net>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: lee.jones@linaro.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: ab8500: Fix ab8500-clk typo
Date: Wed, 11 Dec 2019 18:18:08 +0100 [thread overview]
Message-ID: <20191211171808.GB1530@gerhold.net> (raw)
In-Reply-To: <20191211114639.748463-1-linus.walleij@linaro.org>
On Wed, Dec 11, 2019 at 12:46:39PM +0100, Linus Walleij wrote:
> Commit f4d41ad84433 ("mfd: ab8500: Example using new OF_MFD_CELL MACRO")
> has a typo error renaming "ab8500-clk" to "abx500-clk"
> with the result att ALSA SoC audio broke as the clock
> driver was not probing anymore. Fixed it up.
>
> Cc: Stephan Gerhold <stephan@gerhold.net>
> Fixes: f4d41ad84433 ("mfd: ab8500: Example using new OF_MFD_CELL MACRO")
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
FWIW:
Reviewed-by: Stephan Gerhold <stephan@gerhold.net>
> ---
> drivers/mfd/ab8500-core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mfd/ab8500-core.c b/drivers/mfd/ab8500-core.c
> index bafc729fc434..3c6fda68e6bc 100644
> --- a/drivers/mfd/ab8500-core.c
> +++ b/drivers/mfd/ab8500-core.c
> @@ -631,8 +631,8 @@ static const struct mfd_cell ab8500_devs[] = {
> NULL, NULL, 0, 0, "stericsson,ab8500-ext-regulator"),
> OF_MFD_CELL("ab8500-regulator",
> NULL, NULL, 0, 0, "stericsson,ab8500-regulator"),
> - OF_MFD_CELL("abx500-clk",
> - NULL, NULL, 0, 0, "stericsson,abx500-clk"),
> + OF_MFD_CELL("ab8500-clk",
> + NULL, NULL, 0, 0, "stericsson,ab8500-clk"),
> OF_MFD_CELL("ab8500-gpadc",
> NULL, NULL, 0, 0, "stericsson,ab8500-gpadc"),
> OF_MFD_CELL("ab8500-rtc",
> --
> 2.23.0
>
next prev parent reply other threads:[~2019-12-11 17:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 11:46 [PATCH] mfd: ab8500: Fix ab8500-clk typo Linus Walleij
2019-12-11 17:18 ` Stephan Gerhold [this message]
2019-12-16 15:22 ` Lee Jones
2020-01-17 10:17 ` Linus Walleij
2020-01-17 13:41 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191211171808.GB1530@gerhold.net \
--to=stephan@gerhold.net \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.