From: Borislav Petkov <bp@alien8.de>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Jann Horn <jannh@google.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Andrey Ryabinin <aryabinin@virtuozzo.com>,
Alexander Potapenko <glider@google.com>,
Dmitry Vyukov <dvyukov@google.com>,
kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org,
Andrey Konovalov <andreyknvl@google.com>,
Andy Lutomirski <luto@kernel.org>,
Sean Christopherson <sean.j.christopherson@intel.com>
Subject: Re: [PATCH v6 2/4] x86/traps: Print address on #GP
Date: Wed, 11 Dec 2019 18:29:45 +0100 [thread overview]
Message-ID: <20191211172945.GE14821@zn.tnic> (raw)
In-Reply-To: <BC48F4AD-8330-4ED6-8BE8-254C835506A5@amacapital.net>
On Wed, Dec 11, 2019 at 09:22:30AM -0800, Andy Lutomirski wrote:
> Could we spare a few extra bytes to make this more readable? I can never keep track of which number is the oops count, which is the cpu, and which is the error code. How about:
>
> OOPS 1: general protection blah blah blah (CPU 0)
>
> and put in the next couple lines “#GP(0)”.
Well, right now it is:
[ 2.470492] general protection fault, probably for non-canonical address 0xdfff000000000001: 0000 [#1] PREEMPT SMP
[ 2.471615] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 5.5.0-rc1+ #6
and the CPU is on the second line, the error code is before the number -
[#1] - in that case.
If we pull the number in front, we can do:
[ 2.470492] [#1] general protection fault, probably for non-canonical address 0xdfff000000000001: 0000 PREEMPT SMP
[ 2.471615] [#1] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 5.5.0-rc1+ #6
and this way you know that the error code is there, after the first
line's description.
I guess we can do:
[ 2.470492] [#1] general protection fault, probably for non-canonical address 0xdfff000000000001 Error Code: 0000 PREEMPT SMP
to make it even more explicit...
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2019-12-11 17:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-09 14:31 [PATCH v6 1/4] x86/insn-eval: Add support for 64-bit kernel mode Jann Horn
2019-12-09 14:31 ` [PATCH v6 2/4] x86/traps: Print address on #GP Jann Horn
2019-12-11 17:06 ` Borislav Petkov
2019-12-11 17:22 ` Andy Lutomirski
2019-12-11 17:29 ` Borislav Petkov [this message]
2019-12-11 18:17 ` Andy Lutomirski
2019-12-19 11:29 ` Borislav Petkov
2019-12-18 21:55 ` Jann Horn
2019-12-09 14:31 ` [PATCH v6 3/4] x86/dumpstack: Split out header line printing from __die() Jann Horn
2019-12-09 14:31 ` [PATCH v6 4/4] x86/kasan: Print original address on #GP Jann Horn
2019-12-11 17:37 ` Borislav Petkov
2019-12-18 22:33 ` Jann Horn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191211172945.GE14821@zn.tnic \
--to=bp@alien8.de \
--cc=andreyknvl@google.com \
--cc=aryabinin@virtuozzo.com \
--cc=dvyukov@google.com \
--cc=glider@google.com \
--cc=hpa@zytor.com \
--cc=jannh@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=sean.j.christopherson@intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.