From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F606C43603 for ; Wed, 11 Dec 2019 20:06:57 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 78A0920836 for ; Wed, 11 Dec 2019 20:06:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 78A0920836 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E2D5E6EBC3; Wed, 11 Dec 2019 20:06:56 +0000 (UTC) Received: from asavdk3.altibox.net (asavdk3.altibox.net [109.247.116.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5BB406EBC7 for ; Wed, 11 Dec 2019 20:06:56 +0000 (UTC) Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 53575200A3; Wed, 11 Dec 2019 21:06:53 +0100 (CET) Date: Wed, 11 Dec 2019 21:06:51 +0100 From: Sam Ravnborg To: Jerry Han Subject: Re: [PATCH] drm/panel: Add Boe Himax8279d MIPI-DSI LCD panel Message-ID: <20191211200651.GA10693@ravnborg.org> References: <20191209014641.24685-1-jerry.han.hq@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191209014641.24685-1-jerry.han.hq@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=eMA9ckh1 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=gl-9RGMvwZyvjzrOo0oA:9 a=CjuIK1q_8ugA:10 a=26CFN5KYESCqVWovzqLp:22 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jitao Shi , Rock wang , dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Jerry. > Support Boe Himax8279d 8.0" 1200x1920 TFT LCD panel, it is a MIPI DSI > panel. Thanks for your persistence with this driver. Unfortunately the driver no longer builds after the drm_panel work we committed earlier this week to drm-misc-next. > > V9: > - Adjust init code, make the format more concise > - kill off default_off_cmds (Emil) > - use mipi_dsi_dcs_set_display_{on,off} in their enable/disable > callbacks. (Emil) > - Adjusting the delay function (Emil) ... > + > +struct panel_info { > + struct drm_panel base; > + struct mipi_dsi_device *link; > + const struct panel_desc *desc; > + > + struct backlight_device *backlight; We have included backlight support in drm_panel. Can you please introduce this and post a patch updating the driver to use this. See other panle patches what is required to use it. (Mostly deleting code) I took a look at the rest of the driver and everything looks good. Sorry for causing you this extra trouble due to the drm_panel changes. Sam _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel