From: Christoph Hellwig <hch@infradead.org>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Keith Busch <kbusch@kernel.org>,
tsutomu.owa@kioxia.com, linux-nvme@lists.infradead.org,
hch@infradead.org
Subject: Re: [RFC PATCH 0/5] to add more nvme reset functions
Date: Thu, 12 Dec 2019 00:30:09 -0800 [thread overview]
Message-ID: <20191212083009.GA18522@infradead.org> (raw)
In-Reply-To: <d4583505-d3f2-238b-c323-94216c910e29@grimberg.me>
On Wed, Dec 11, 2019 at 04:50:23PM -0800, Sagi Grimberg wrote:
>
> > > Any comments would be highly appreciated.
> >
> > The majority of this series is at the pci protocol level, and the pci
> > driver already provides the requested capabilities (but with a more
> > safe implementation). Let's not reinvent it just because one nvme
> > transport happens to use the pci bus.
>
> This is messy. Everything here needs to live in nvme-pci.
I really don't see any good reason to have any of this code to be
honest.
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2019-12-12 8:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 2:34 [RFC PATCH 0/5] to add more nvme reset functions tsutomu.owa
2019-12-11 16:18 ` Keith Busch
2019-12-12 0:50 ` Sagi Grimberg
2019-12-12 8:30 ` Christoph Hellwig [this message]
2019-12-12 8:41 ` tsutomu.owa
2019-12-12 8:36 ` tsutomu.owa
2019-12-12 18:36 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191212083009.GA18522@infradead.org \
--to=hch@infradead.org \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=tsutomu.owa@kioxia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.