From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49C80C3F68F for ; Thu, 12 Dec 2019 09:41:01 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id D09E42465B for ; Thu, 12 Dec 2019 09:41:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="o/9lLUez" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D09E42465B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 5E9794ACD6; Thu, 12 Dec 2019 04:41:00 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@kernel.org Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wIlZHLTyZOzp; Thu, 12 Dec 2019 04:40:59 -0500 (EST) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 3E2614AEAB; Thu, 12 Dec 2019 04:40:59 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id A584E4AEA4 for ; Thu, 12 Dec 2019 04:40:57 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Gr09XC9R6zM4 for ; Thu, 12 Dec 2019 04:40:56 -0500 (EST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 9F7414ACD6 for ; Thu, 12 Dec 2019 04:40:56 -0500 (EST) Received: from localhost.localdomain (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0B37B24654; Thu, 12 Dec 2019 09:40:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576143655; bh=Rr7kCvNdPW3e2IBJnliH3eTMWWlqAlnaKNJfjBbxn3s=; h=From:To:Cc:Subject:Date:From; b=o/9lLUezdKlavsdvjIBXsTOvuw3E3zZTN9Ja5z0/TirEBSPaaZMc7xjY3+/teFHW3 b0rQZzbv9qi+ZQsTvG7h3kcnTKxxC32C6lWbH5GKWBCQjcCsO/GB0vRo4HIWv22ja6 CDlloQV5Yk05Dhr03Isp4flcMUL6DpXqTroiKHPM= From: Will Deacon To: kvmarm@lists.cs.columbia.edu Subject: [PATCH] KVM: arm64: Ensure 'params' is initialised when looking up sys register Date: Thu, 12 Dec 2019 09:40:49 +0000 Message-Id: <20191212094049.12437-1-will@kernel.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Cc: Will Deacon , stable@vger.kernel.org, Vijaya Kumar K , Marc Zyngier , kernel-team@android.com, linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu Q29tbWl0IDRiOTI3Yjk0ZDVkZiAoIktWTTogYXJtL2FybTY0OiB2Z2ljOiBJbnRyb2R1Y2UgZmlu ZF9yZWdfYnlfaWQoKSIpCmludHJvZHVjZWQgJ2ZpbmRfcmVnX2J5X2lkKCknLCB3aGljaCBsb29r cyB1cCBhIHN5c3RlbSByZWdpc3RlciBvbmx5IGlmCnRoZSAnaWQnIGluZGV4IHBhcmFtZXRlciBp ZGVudGlmaWVzIGEgdmFsaWQgc3lzdGVtIHJlZ2lzdGVyLiBBcyBwYXJ0IG9mCnRoZSBwYXRjaCwg ZXhpc3RpbmcgY2FsbGVycyBvZiAnZmluZF9yZWcoKScgd2VyZSBwb3J0ZWQgb3ZlciB0byB0aGUg bmV3CmludGVyZmFjZSwgYnV0IHRoaXMgYnJlYWtzICdpbmRleF90b19zeXNfcmVnX2Rlc2MoKScg aW4gdGhlIGNhc2UgdGhhdCB0aGUKaW5pdGlhbCBsb29rdXAgaW4gdGhlIHZDUFUgdGFyZ2V0IHRh YmxlIGZhaWxzIGJlY2F1c2Ugd2Ugd2lsbCB0aGVuIGNhbGwKaW50byAnZmluZF9yZWcoKScgZm9y IHRoZSBzeXN0ZW0gcmVnaXN0ZXIgdGFibGUgd2l0aCBhbiB1bmluaXRpYWxpc2VkCidwYXJhbScg YXMgdGhlIGtleSB0byB0aGUgbG9va3VwLgoKR0NDIDEwIGlzIGJyaWdodCBlbm91Z2ggdG8gc3Bv dCB0aGlzIChhbW9uZ3N0IGEgdG9ubmUgb2YgZmFsc2UgcG9zaXRpdmVzLApidXQgaGV5ISk6Cgog IHwgYXJjaC9hcm02NC9rdm0vc3lzX3JlZ3MuYzogSW4gZnVuY3Rpb24g4oCYaW5kZXhfdG9fc3lz X3JlZ19kZXNjLnBhcnQuMC5pc3Jh4oCZOgogIHwgYXJjaC9hcm02NC9rdm0vc3lzX3JlZ3MuYzo5 ODM6MzM6IHdhcm5pbmc6IOKAmHBhcmFtcy5PcDLigJkgbWF5IGJlIHVzZWQgdW5pbml0aWFsaXpl ZCBpbiB0aGlzIGZ1bmN0aW9uIFstV21heWJlLXVuaW5pdGlhbGl6ZWRdCiAgfCAgIDk4MyB8ICAg KHUzMikoeCktPkNSbiwgKHUzMikoeCktPkNSbSwgKHUzMikoeCktPk9wMik7CiAgfCBbLi4uXQoK UmV2ZXJ0IHRoZSBodW5rIG9mIDRiOTI3Yjk0ZDVkZiB3aGljaCBicmVha3MgJ2luZGV4X3RvX3N5 c19yZWdfZGVzYygpJyBzbwp0aGF0IHRoZSBvbGQgYmVoYXZpb3VyIG9mIGNoZWNraW5nIHRoZSBp bmRleCB1cGZyb250IGlzIHJlc3RvcmVkLgoKQ2M6IDxzdGFibGVAdmdlci5rZXJuZWwub3JnPgpD YzogTWFyYyBaeW5naWVyIDxtYXpAa2VybmVsLm9yZz4KQ2M6IFZpamF5YSBLdW1hciBLIDxWaWph eWEuS3VtYXJAY2F2aXVtLmNvbT4KRml4ZXM6IDRiOTI3Yjk0ZDVkZiAoIktWTTogYXJtL2FybTY0 OiB2Z2ljOiBJbnRyb2R1Y2UgZmluZF9yZWdfYnlfaWQoKSIpClNpZ25lZC1vZmYtYnk6IFdpbGwg RGVhY29uIDx3aWxsQGtlcm5lbC5vcmc+Ci0tLQogYXJjaC9hcm02NC9rdm0vc3lzX3JlZ3MuYyB8 IDUgKysrKy0KIDEgZmlsZSBjaGFuZ2VkLCA0IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkK CmRpZmYgLS1naXQgYS9hcmNoL2FybTY0L2t2bS9zeXNfcmVncy5jIGIvYXJjaC9hcm02NC9rdm0v c3lzX3JlZ3MuYwppbmRleCA0NjgyMmFmYzU3ZTAuLjAxYTUxNWUwMTcxZSAxMDA2NDQKLS0tIGEv YXJjaC9hcm02NC9rdm0vc3lzX3JlZ3MuYworKysgYi9hcmNoL2FybTY0L2t2bS9zeXNfcmVncy5j CkBAIC0yMzYwLDggKzIzNjAsMTEgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBzeXNfcmVnX2Rlc2Mg KmluZGV4X3RvX3N5c19yZWdfZGVzYyhzdHJ1Y3Qga3ZtX3ZjcHUgKnZjcHUsCiAJaWYgKChpZCAm IEtWTV9SRUdfQVJNX0NPUFJPQ19NQVNLKSAhPSBLVk1fUkVHX0FSTTY0X1NZU1JFRykKIAkJcmV0 dXJuIE5VTEw7CiAKKwlpZiAoIWluZGV4X3RvX3BhcmFtcyhpZCwgJnBhcmFtcykpCisJCXJldHVy biBOVUxMOworCiAJdGFibGUgPSBnZXRfdGFyZ2V0X3RhYmxlKHZjcHUtPmFyY2gudGFyZ2V0LCB0 cnVlLCAmbnVtKTsKLQlyID0gZmluZF9yZWdfYnlfaWQoaWQsICZwYXJhbXMsIHRhYmxlLCBudW0p OworCXIgPSBmaW5kX3JlZygmcGFyYW1zLCB0YWJsZSwgbnVtKTsKIAlpZiAoIXIpCiAJCXIgPSBm aW5kX3JlZygmcGFyYW1zLCBzeXNfcmVnX2Rlc2NzLCBBUlJBWV9TSVpFKHN5c19yZWdfZGVzY3Mp KTsKIAotLSAKMi4yNC4xLjczNS5nMDNmNGU3MjgxNy1nb29nCgpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwprdm1hcm0gbWFpbGluZyBsaXN0Cmt2bWFybUBs aXN0cy5jcy5jb2x1bWJpYS5lZHUKaHR0cHM6Ly9saXN0cy5jcy5jb2x1bWJpYS5lZHUvbWFpbG1h bi9saXN0aW5mby9rdm1hcm0K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE2F7C2D0CA for ; Thu, 12 Dec 2019 09:41:08 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6F75C2173E for ; Thu, 12 Dec 2019 09:41:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="DptT+RUE"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="o/9lLUez" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6F75C2173E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=Ss34Nb0DjX9WHSvTdtASFit+TeqG4ZalXpU8RorM9Ic=; b=DptT+RUE8joaCZ nlaDMPxNM6it18LUUcqx7NDpZXGEUEP+2DdfJk+Kq6se8568v6/9dwwzO2h+dBrGEeLdkX+VWrgZi dM/9xUC1hL31YclxvAkJqCbDBeYuZqe9GgfDddhfOW7D10MCypkDecWEZCbFeJTTeytC8IHg3KDo4 rO/f/642Z3sh3kUhvdcH33oQa/jvt95bDivFjKAjxfO55JoiYS/hNHSF3gq4up686zd55fZWkf5AF gejWi6Ol3etjEEIkCWUVZjBJM4qyH+JhaDHQFUt+a0Bu8Imkhxqdr+LZRHoRnubC6cCHi8v2E7OGn F2cxbgO+u+29ndU3MQpg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ifKxx-0002Ai-AN; Thu, 12 Dec 2019 09:41:01 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ifKxt-00028e-EO for linux-arm-kernel@lists.infradead.org; Thu, 12 Dec 2019 09:40:59 +0000 Received: from localhost.localdomain (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0B37B24654; Thu, 12 Dec 2019 09:40:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576143655; bh=Rr7kCvNdPW3e2IBJnliH3eTMWWlqAlnaKNJfjBbxn3s=; h=From:To:Cc:Subject:Date:From; b=o/9lLUezdKlavsdvjIBXsTOvuw3E3zZTN9Ja5z0/TirEBSPaaZMc7xjY3+/teFHW3 b0rQZzbv9qi+ZQsTvG7h3kcnTKxxC32C6lWbH5GKWBCQjcCsO/GB0vRo4HIWv22ja6 CDlloQV5Yk05Dhr03Isp4flcMUL6DpXqTroiKHPM= From: Will Deacon To: kvmarm@lists.cs.columbia.edu Subject: [PATCH] KVM: arm64: Ensure 'params' is initialised when looking up sys register Date: Thu, 12 Dec 2019 09:40:49 +0000 Message-Id: <20191212094049.12437-1-will@kernel.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191212_014057_518161_7FCCAD5A X-CRM114-Status: GOOD ( 11.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: suzuki.poulose@arm.com, Will Deacon , stable@vger.kernel.org, Vijaya Kumar K , james.morse@arm.com, Marc Zyngier , kernel-team@android.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Q29tbWl0IDRiOTI3Yjk0ZDVkZiAoIktWTTogYXJtL2FybTY0OiB2Z2ljOiBJbnRyb2R1Y2UgZmlu ZF9yZWdfYnlfaWQoKSIpCmludHJvZHVjZWQgJ2ZpbmRfcmVnX2J5X2lkKCknLCB3aGljaCBsb29r cyB1cCBhIHN5c3RlbSByZWdpc3RlciBvbmx5IGlmCnRoZSAnaWQnIGluZGV4IHBhcmFtZXRlciBp ZGVudGlmaWVzIGEgdmFsaWQgc3lzdGVtIHJlZ2lzdGVyLiBBcyBwYXJ0IG9mCnRoZSBwYXRjaCwg ZXhpc3RpbmcgY2FsbGVycyBvZiAnZmluZF9yZWcoKScgd2VyZSBwb3J0ZWQgb3ZlciB0byB0aGUg bmV3CmludGVyZmFjZSwgYnV0IHRoaXMgYnJlYWtzICdpbmRleF90b19zeXNfcmVnX2Rlc2MoKScg aW4gdGhlIGNhc2UgdGhhdCB0aGUKaW5pdGlhbCBsb29rdXAgaW4gdGhlIHZDUFUgdGFyZ2V0IHRh YmxlIGZhaWxzIGJlY2F1c2Ugd2Ugd2lsbCB0aGVuIGNhbGwKaW50byAnZmluZF9yZWcoKScgZm9y IHRoZSBzeXN0ZW0gcmVnaXN0ZXIgdGFibGUgd2l0aCBhbiB1bmluaXRpYWxpc2VkCidwYXJhbScg YXMgdGhlIGtleSB0byB0aGUgbG9va3VwLgoKR0NDIDEwIGlzIGJyaWdodCBlbm91Z2ggdG8gc3Bv dCB0aGlzIChhbW9uZ3N0IGEgdG9ubmUgb2YgZmFsc2UgcG9zaXRpdmVzLApidXQgaGV5ISk6Cgog IHwgYXJjaC9hcm02NC9rdm0vc3lzX3JlZ3MuYzogSW4gZnVuY3Rpb24g4oCYaW5kZXhfdG9fc3lz X3JlZ19kZXNjLnBhcnQuMC5pc3Jh4oCZOgogIHwgYXJjaC9hcm02NC9rdm0vc3lzX3JlZ3MuYzo5 ODM6MzM6IHdhcm5pbmc6IOKAmHBhcmFtcy5PcDLigJkgbWF5IGJlIHVzZWQgdW5pbml0aWFsaXpl ZCBpbiB0aGlzIGZ1bmN0aW9uIFstV21heWJlLXVuaW5pdGlhbGl6ZWRdCiAgfCAgIDk4MyB8ICAg KHUzMikoeCktPkNSbiwgKHUzMikoeCktPkNSbSwgKHUzMikoeCktPk9wMik7CiAgfCBbLi4uXQoK UmV2ZXJ0IHRoZSBodW5rIG9mIDRiOTI3Yjk0ZDVkZiB3aGljaCBicmVha3MgJ2luZGV4X3RvX3N5 c19yZWdfZGVzYygpJyBzbwp0aGF0IHRoZSBvbGQgYmVoYXZpb3VyIG9mIGNoZWNraW5nIHRoZSBp bmRleCB1cGZyb250IGlzIHJlc3RvcmVkLgoKQ2M6IDxzdGFibGVAdmdlci5rZXJuZWwub3JnPgpD YzogTWFyYyBaeW5naWVyIDxtYXpAa2VybmVsLm9yZz4KQ2M6IFZpamF5YSBLdW1hciBLIDxWaWph eWEuS3VtYXJAY2F2aXVtLmNvbT4KRml4ZXM6IDRiOTI3Yjk0ZDVkZiAoIktWTTogYXJtL2FybTY0 OiB2Z2ljOiBJbnRyb2R1Y2UgZmluZF9yZWdfYnlfaWQoKSIpClNpZ25lZC1vZmYtYnk6IFdpbGwg RGVhY29uIDx3aWxsQGtlcm5lbC5vcmc+Ci0tLQogYXJjaC9hcm02NC9rdm0vc3lzX3JlZ3MuYyB8 IDUgKysrKy0KIDEgZmlsZSBjaGFuZ2VkLCA0IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkK CmRpZmYgLS1naXQgYS9hcmNoL2FybTY0L2t2bS9zeXNfcmVncy5jIGIvYXJjaC9hcm02NC9rdm0v c3lzX3JlZ3MuYwppbmRleCA0NjgyMmFmYzU3ZTAuLjAxYTUxNWUwMTcxZSAxMDA2NDQKLS0tIGEv YXJjaC9hcm02NC9rdm0vc3lzX3JlZ3MuYworKysgYi9hcmNoL2FybTY0L2t2bS9zeXNfcmVncy5j CkBAIC0yMzYwLDggKzIzNjAsMTEgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBzeXNfcmVnX2Rlc2Mg KmluZGV4X3RvX3N5c19yZWdfZGVzYyhzdHJ1Y3Qga3ZtX3ZjcHUgKnZjcHUsCiAJaWYgKChpZCAm IEtWTV9SRUdfQVJNX0NPUFJPQ19NQVNLKSAhPSBLVk1fUkVHX0FSTTY0X1NZU1JFRykKIAkJcmV0 dXJuIE5VTEw7CiAKKwlpZiAoIWluZGV4X3RvX3BhcmFtcyhpZCwgJnBhcmFtcykpCisJCXJldHVy biBOVUxMOworCiAJdGFibGUgPSBnZXRfdGFyZ2V0X3RhYmxlKHZjcHUtPmFyY2gudGFyZ2V0LCB0 cnVlLCAmbnVtKTsKLQlyID0gZmluZF9yZWdfYnlfaWQoaWQsICZwYXJhbXMsIHRhYmxlLCBudW0p OworCXIgPSBmaW5kX3JlZygmcGFyYW1zLCB0YWJsZSwgbnVtKTsKIAlpZiAoIXIpCiAJCXIgPSBm aW5kX3JlZygmcGFyYW1zLCBzeXNfcmVnX2Rlc2NzLCBBUlJBWV9TSVpFKHN5c19yZWdfZGVzY3Mp KTsKIAotLSAKMi4yNC4xLjczNS5nMDNmNGU3MjgxNy1nb29nCgoKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxp c3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZy YWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2489BC2D0C8 for ; Thu, 12 Dec 2019 09:40:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EA10124671 for ; Thu, 12 Dec 2019 09:40:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576143659; bh=Rr7kCvNdPW3e2IBJnliH3eTMWWlqAlnaKNJfjBbxn3s=; h=From:To:Cc:Subject:Date:List-ID:From; b=P4VV7YxkkvLqG8q2PFVkv8j2xLaOMm5wOOt4sFZA2iPTIuSiV+3L1WmcOLA/gtlsb 3eXNRpuY5+YqTfIlfrCNigOeUor0q7Wswa5ZVHVDGPOXOUmFeTgW6ebqluaTHX6q6F BUQM71oU47kUz1k7A+2owp+Qvd1zxnHu3OTz4CT8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728494AbfLLJk5 (ORCPT ); Thu, 12 Dec 2019 04:40:57 -0500 Received: from mail.kernel.org ([198.145.29.99]:41936 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728352AbfLLJk4 (ORCPT ); Thu, 12 Dec 2019 04:40:56 -0500 Received: from localhost.localdomain (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0B37B24654; Thu, 12 Dec 2019 09:40:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576143655; bh=Rr7kCvNdPW3e2IBJnliH3eTMWWlqAlnaKNJfjBbxn3s=; h=From:To:Cc:Subject:Date:From; b=o/9lLUezdKlavsdvjIBXsTOvuw3E3zZTN9Ja5z0/TirEBSPaaZMc7xjY3+/teFHW3 b0rQZzbv9qi+ZQsTvG7h3kcnTKxxC32C6lWbH5GKWBCQjcCsO/GB0vRo4HIWv22ja6 CDlloQV5Yk05Dhr03Isp4flcMUL6DpXqTroiKHPM= From: Will Deacon To: kvmarm@lists.cs.columbia.edu Cc: linux-arm-kernel@lists.infradead.org, james.morse@arm.com, suzuki.poulose@arm.com, kernel-team@android.com, Will Deacon , stable@vger.kernel.org, Marc Zyngier , Vijaya Kumar K Subject: [PATCH] KVM: arm64: Ensure 'params' is initialised when looking up sys register Date: Thu, 12 Dec 2019 09:40:49 +0000 Message-Id: <20191212094049.12437-1-will@kernel.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Commit 4b927b94d5df ("KVM: arm/arm64: vgic: Introduce find_reg_by_id()") introduced 'find_reg_by_id()', which looks up a system register only if the 'id' index parameter identifies a valid system register. As part of the patch, existing callers of 'find_reg()' were ported over to the new interface, but this breaks 'index_to_sys_reg_desc()' in the case that the initial lookup in the vCPU target table fails because we will then call into 'find_reg()' for the system register table with an uninitialised 'param' as the key to the lookup. GCC 10 is bright enough to spot this (amongst a tonne of false positives, but hey!): | arch/arm64/kvm/sys_regs.c: In function ‘index_to_sys_reg_desc.part.0.isra’: | arch/arm64/kvm/sys_regs.c:983:33: warning: ‘params.Op2’ may be used uninitialized in this function [-Wmaybe-uninitialized] | 983 | (u32)(x)->CRn, (u32)(x)->CRm, (u32)(x)->Op2); | [...] Revert the hunk of 4b927b94d5df which breaks 'index_to_sys_reg_desc()' so that the old behaviour of checking the index upfront is restored. Cc: Cc: Marc Zyngier Cc: Vijaya Kumar K Fixes: 4b927b94d5df ("KVM: arm/arm64: vgic: Introduce find_reg_by_id()") Signed-off-by: Will Deacon --- arch/arm64/kvm/sys_regs.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/arch/arm64/kvm/sys_regs.c b/arch/arm64/kvm/sys_regs.c index 46822afc57e0..01a515e0171e 100644 --- a/arch/arm64/kvm/sys_regs.c +++ b/arch/arm64/kvm/sys_regs.c @@ -2360,8 +2360,11 @@ static const struct sys_reg_desc *index_to_sys_reg_desc(struct kvm_vcpu *vcpu, if ((id & KVM_REG_ARM_COPROC_MASK) != KVM_REG_ARM64_SYSREG) return NULL; + if (!index_to_params(id, ¶ms)) + return NULL; + table = get_target_table(vcpu->arch.target, true, &num); - r = find_reg_by_id(id, ¶ms, table, num); + r = find_reg(¶ms, table, num); if (!r) r = find_reg(¶ms, sys_reg_descs, ARRAY_SIZE(sys_reg_descs)); -- 2.24.1.735.g03f4e72817-goog