From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v4 00/13] use host-systemd to enable units
Date: Thu, 12 Dec 2019 11:14:38 +0100 [thread overview]
Message-ID: <20191212111438.562923cb@windsurf> (raw)
In-Reply-To: <20191212075400.1499536-1-jeremy.rosen@smile.fr>
Hello J?r?my,
I have a very minor comment, no need to resend just for that: I'd like
the commit titles to be a bit nicer. See below for some suggestions.
On Thu, 12 Dec 2019 08:53:47 +0100
J?r?my Rosen <jeremy.rosen@smile.fr> wrote:
> J?r?my Rosen (13):
> new recipe : host-systemd
Should be:
package/systemd: add host variant
> use host-systemctl preset all to enable units
package/systemd: use host-systemctl preset-all to enable units
> fix tty handling
package/systemd: fix tty handling
> fix trivial packages with buildroot-provided services
package: rely on systemctl preset-all for buildroot-provided services
> fix trivial cases, upstream-provided services
package: rely on systemctl preset-all for upstream-provided services
> package/connman: adapt to preset-all
package/commman: adapt to systemctl preset-all
> package/linuxptp adapt to preset-all
> package/network-manager: adapt to preset-all
> package/wpa_supplicant: adapt for preset-all
Ditto for those ones.
> package/sysrepo: update to new systemd
> package/syslog-ng: implement default using DefaultInstance
> package/rauc: add a WantedBy section to the unit
> package/alsa-utils: add a WantedBy section to the unit
In those last three ones, perhaps have "systemd" somewhere in the
commit title.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2019-12-12 10:14 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-12 7:53 [Buildroot] [PATCH v4 00/13] use host-systemd to enable units Jérémy Rosen
2019-12-12 7:53 ` [Buildroot] [PATCH v4 01/13] new recipe : host-systemd Jérémy Rosen
2019-12-12 10:19 ` Thomas Petazzoni
2019-12-12 10:35 ` Jérémy ROSEN
2019-12-12 17:31 ` Yann E. MORIN
2019-12-12 7:53 ` [Buildroot] [PATCH v4 02/13] use host-systemctl preset all to enable units Jérémy Rosen
2019-12-12 7:53 ` [Buildroot] [PATCH v4 03/13] fix tty handling Jérémy Rosen
2019-12-12 7:53 ` [Buildroot] [PATCH v4 04/13] fix trivial packages with buildroot-provided services Jérémy Rosen
2019-12-12 7:53 ` [Buildroot] [PATCH v4 05/13] fix trivial cases, upstream-provided services Jérémy Rosen
2019-12-12 7:53 ` [Buildroot] [PATCH v4 06/13] package/connman: adapt to preset-all Jérémy Rosen
2019-12-12 7:53 ` [Buildroot] [PATCH v4 07/13] package/linuxptp " Jérémy Rosen
2019-12-12 7:53 ` [Buildroot] [PATCH v4 08/13] package/network-manager: " Jérémy Rosen
2019-12-12 7:53 ` [Buildroot] [PATCH v4 09/13] package/wpa_supplicant: adapt for preset-all Jérémy Rosen
2019-12-12 7:53 ` [Buildroot] [PATCH v4 10/13] package/sysrepo: update to new systemd Jérémy Rosen
2019-12-12 7:53 ` [Buildroot] [PATCH v4 11/13] package/syslog-ng: implement default using DefaultInstance Jérémy Rosen
2019-12-12 7:53 ` [Buildroot] [PATCH v4 12/13] package/rauc: add a WantedBy section to the unit Jérémy Rosen
2019-12-12 7:54 ` [Buildroot] [PATCH v4 13/13] package/alsa-utils: " Jérémy Rosen
2019-12-12 10:14 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191212111438.562923cb@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.