From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH 1/4] ARM: dts: am437x-gp-evm: add HDMI support Date: Thu, 12 Dec 2019 09:21:04 -0800 Message-ID: <20191212172104.GY35479@atomide.com> References: <20191125131100.9839-1-tomi.valkeinen@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20191125131100.9839-1-tomi.valkeinen@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Tomi Valkeinen Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, linux-omap@vger.kernel.org, dri-devel@lists.freedesktop.org, robh+dt@kernel.org List-Id: linux-omap@vger.kernel.org Hi, * Tomi Valkeinen [191125 05:11]: > Add HDMI support for AM437x GP EVM. The HDMI uses SiI9022 HDMI encoder, > and is mutually exclusive with the LCD. The choice between LCD and HDMI > is made by booting either with am437x-gp-evm.dtb or > am437x-gp-evm-hdmi.dtb. So Linux kernel needs a new board device tree file to toggle a GPIO line to switch between LCD mode and HDMI? That does not sound very user friendly for something that's supposed to be hot pluggabe :) > +/* Override SelLCDorHDMI from am437x-gp-evm.dts to select HDMI */ > +&gpio5 { > + p8 { > + output-low; > + }; > +}; How about just leave the gpio unconfigured and document that a userspace tool or /sys/kernel/debug/gpio is needed to toggle between the modes? Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06909C43603 for ; Thu, 12 Dec 2019 17:21:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D8046205C9 for ; Thu, 12 Dec 2019 17:21:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730065AbfLLRVH (ORCPT ); Thu, 12 Dec 2019 12:21:07 -0500 Received: from muru.com ([72.249.23.125]:46476 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730033AbfLLRVH (ORCPT ); Thu, 12 Dec 2019 12:21:07 -0500 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 25D8D80C0; Thu, 12 Dec 2019 17:21:46 +0000 (UTC) Date: Thu, 12 Dec 2019 09:21:04 -0800 From: Tony Lindgren To: Tomi Valkeinen Cc: linux-omap@vger.kernel.org, devicetree@vger.kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, dri-devel@lists.freedesktop.org Subject: Re: [PATCH 1/4] ARM: dts: am437x-gp-evm: add HDMI support Message-ID: <20191212172104.GY35479@atomide.com> References: <20191125131100.9839-1-tomi.valkeinen@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191125131100.9839-1-tomi.valkeinen@ti.com> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi, * Tomi Valkeinen [191125 05:11]: > Add HDMI support for AM437x GP EVM. The HDMI uses SiI9022 HDMI encoder, > and is mutually exclusive with the LCD. The choice between LCD and HDMI > is made by booting either with am437x-gp-evm.dtb or > am437x-gp-evm-hdmi.dtb. So Linux kernel needs a new board device tree file to toggle a GPIO line to switch between LCD mode and HDMI? That does not sound very user friendly for something that's supposed to be hot pluggabe :) > +/* Override SelLCDorHDMI from am437x-gp-evm.dts to select HDMI */ > +&gpio5 { > + p8 { > + output-low; > + }; > +}; How about just leave the gpio unconfigured and document that a userspace tool or /sys/kernel/debug/gpio is needed to toggle between the modes? Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBA9EC2D0C9 for ; Fri, 13 Dec 2019 08:23:05 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B85A324658 for ; Fri, 13 Dec 2019 08:23:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B85A324658 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E5EE36E2C0; Fri, 13 Dec 2019 08:22:27 +0000 (UTC) Received: from muru.com (muru.com [72.249.23.125]) by gabe.freedesktop.org (Postfix) with ESMTP id 012BF6E0D3 for ; Thu, 12 Dec 2019 17:21:07 +0000 (UTC) Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 25D8D80C0; Thu, 12 Dec 2019 17:21:46 +0000 (UTC) Date: Thu, 12 Dec 2019 09:21:04 -0800 From: Tony Lindgren To: Tomi Valkeinen Subject: Re: [PATCH 1/4] ARM: dts: am437x-gp-evm: add HDMI support Message-ID: <20191212172104.GY35479@atomide.com> References: <20191125131100.9839-1-tomi.valkeinen@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191125131100.9839-1-tomi.valkeinen@ti.com> User-Agent: Mutt/1.12.2 (2019-09-21) X-Mailman-Approved-At: Fri, 13 Dec 2019 08:22:24 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, linux-omap@vger.kernel.org, dri-devel@lists.freedesktop.org, robh+dt@kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, * Tomi Valkeinen [191125 05:11]: > Add HDMI support for AM437x GP EVM. The HDMI uses SiI9022 HDMI encoder, > and is mutually exclusive with the LCD. The choice between LCD and HDMI > is made by booting either with am437x-gp-evm.dtb or > am437x-gp-evm-hdmi.dtb. So Linux kernel needs a new board device tree file to toggle a GPIO line to switch between LCD mode and HDMI? That does not sound very user friendly for something that's supposed to be hot pluggabe :) > +/* Override SelLCDorHDMI from am437x-gp-evm.dts to select HDMI */ > +&gpio5 { > + p8 { > + output-low; > + }; > +}; How about just leave the gpio unconfigured and document that a userspace tool or /sys/kernel/debug/gpio is needed to toggle between the modes? Regards, Tony _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel