All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Bin Liu <b-liu@ti.com>,
	Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org, linux-omap@vger.kernel.org,
	Merlijn Wajer <merlijn@wizzup.org>, Pavel Machek <pavel@ucw.cz>,
	Sebastian Reichel <sre@kernel.org>
Subject: Re: [PATCH] usb: musb: fix idling for suspend after disconnect interrupt
Date: Thu, 12 Dec 2019 09:26:14 -0800	[thread overview]
Message-ID: <20191212172614.GZ35479@atomide.com> (raw)
In-Reply-To: <20191212172157.GJ16429@iaqt7>

* Bin Liu <b-liu@ti.com> [191212 17:23]:
> On Tue, Nov 26, 2019 at 09:45:15AM -0800, Tony Lindgren wrote:
> > * Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> [191126 10:21]:
> > > Hello!
> > > 
> > > On 26.11.2019 6:41, Tony Lindgren wrote:
> > > 
> > > > When disconnected as USB B-device, we sometimes get a suspend interrupt
> > > > after disconnect interrupt. In that case we have devctl set to 99 with
> > > > VBUS still valid and musb_pm_runtime_check_session() wrongly things we
> > > 
> > >     Thinks?
> > 
> > Thanks will fix.
> 
> Is this the only update needed? I can fix it locally when queuing the
> patch.

So it seems. Maybe also add your explanation for why the wrong
ordering of interrupts can happen while at it.

Regards,

Tony

  reply	other threads:[~2019-12-12 17:26 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-26  3:41 [PATCH] usb: musb: fix idling for suspend after disconnect interrupt Tony Lindgren
2019-11-26 10:20 ` Sergei Shtylyov
2019-11-26 17:45   ` Tony Lindgren
2019-12-12 17:21     ` Bin Liu
2019-12-12 17:26       ` Tony Lindgren [this message]
2019-12-12 16:00 ` Bin Liu
2019-12-12 16:09   ` Tony Lindgren
2019-12-12 17:08     ` Bin Liu
2019-12-12 17:15       ` Tony Lindgren
2020-10-27  4:55 ` Bhushan Shah
2020-10-27  6:17   ` Tony Lindgren
2020-10-27  7:59     ` Bhushan Shah
2020-10-28  8:42       ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191212172614.GZ35479@atomide.com \
    --to=tony@atomide.com \
    --cc=b-liu@ti.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=merlijn@wizzup.org \
    --cc=pavel@ucw.cz \
    --cc=sergei.shtylyov@cogentembedded.com \
    --cc=sre@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.