From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C184C00454 for ; Thu, 12 Dec 2019 17:28:56 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 10EDD21655 for ; Thu, 12 Dec 2019 17:28:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 10EDD21655 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id BF0424AEC5; Thu, 12 Dec 2019 12:28:55 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3AVWnHR-lWf8; Thu, 12 Dec 2019 12:28:54 -0500 (EST) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id E24B04AEB8; Thu, 12 Dec 2019 12:28:51 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 6E4424AEBC for ; Thu, 12 Dec 2019 12:28:49 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NxsqvrRsQTDO for ; Thu, 12 Dec 2019 12:28:48 -0500 (EST) Received: from inca-roads.misterjones.org (inca-roads.misterjones.org [213.251.177.50]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 511A44AC88 for ; Thu, 12 Dec 2019 12:28:48 -0500 (EST) Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=why.lan) by cheepnis.misterjones.org with esmtpsa (TLSv1.2:DHE-RSA-AES128-GCM-SHA256:128) (Exim 4.80) (envelope-from ) id 1ifSGa-00069s-F9; Thu, 12 Dec 2019 18:28:44 +0100 From: Marc Zyngier To: Paolo Bonzini , =?UTF-8?q?Radim=20Kr=C4=8Dm=C3=A1=C5=99?= Subject: [PATCH 7/8] KVM: arm64: Ensure 'params' is initialised when looking up sys register Date: Thu, 12 Dec 2019 17:28:23 +0000 Message-Id: <20191212172824.11523-8-maz@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191212172824.11523-1-maz@kernel.org> References: <20191212172824.11523-1-maz@kernel.org> MIME-Version: 1.0 X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: pbonzini@redhat.com, rkrcmar@redhat.com, alexandru.elisei@arm.com, ard.biesheuvel@linaro.org, christoffer.dall@arm.com, eric.auger@redhat.com, james.morse@arm.com, justin.he@arm.com, mark.rutland@arm.com, linmiaohe@huawei.com, steven.price@arm.com, will@kernel.org, kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com, stable@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on cheepnis.misterjones.org); SAEximRunCond expanded to false Cc: Jia He , kvm@vger.kernel.org, Ard Biesheuvel , Will Deacon , stable@vger.kernel.org, Steven Price , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu RnJvbTogV2lsbCBEZWFjb24gPHdpbGxAa2VybmVsLm9yZz4KCkNvbW1pdCA0YjkyN2I5NGQ1ZGYg KCJLVk06IGFybS9hcm02NDogdmdpYzogSW50cm9kdWNlIGZpbmRfcmVnX2J5X2lkKCkiKQppbnRy b2R1Y2VkICdmaW5kX3JlZ19ieV9pZCgpJywgd2hpY2ggbG9va3MgdXAgYSBzeXN0ZW0gcmVnaXN0 ZXIgb25seSBpZgp0aGUgJ2lkJyBpbmRleCBwYXJhbWV0ZXIgaWRlbnRpZmllcyBhIHZhbGlkIHN5 c3RlbSByZWdpc3Rlci4gQXMgcGFydCBvZgp0aGUgcGF0Y2gsIGV4aXN0aW5nIGNhbGxlcnMgb2Yg J2ZpbmRfcmVnKCknIHdlcmUgcG9ydGVkIG92ZXIgdG8gdGhlIG5ldwppbnRlcmZhY2UsIGJ1dCB0 aGlzIGJyZWFrcyAnaW5kZXhfdG9fc3lzX3JlZ19kZXNjKCknIGluIHRoZSBjYXNlIHRoYXQgdGhl CmluaXRpYWwgbG9va3VwIGluIHRoZSB2Q1BVIHRhcmdldCB0YWJsZSBmYWlscyBiZWNhdXNlIHdl IHdpbGwgdGhlbiBjYWxsCmludG8gJ2ZpbmRfcmVnKCknIGZvciB0aGUgc3lzdGVtIHJlZ2lzdGVy IHRhYmxlIHdpdGggYW4gdW5pbml0aWFsaXNlZAoncGFyYW0nIGFzIHRoZSBrZXkgdG8gdGhlIGxv b2t1cC4KCkdDQyAxMCBpcyBicmlnaHQgZW5vdWdoIHRvIHNwb3QgdGhpcyAoYW1vbmdzdCBhIHRv bm5lIG9mIGZhbHNlIHBvc2l0aXZlcywKYnV0IGhleSEpOgoKICB8IGFyY2gvYXJtNjQva3ZtL3N5 c19yZWdzLmM6IEluIGZ1bmN0aW9uIOKAmGluZGV4X3RvX3N5c19yZWdfZGVzYy5wYXJ0LjAuaXNy YeKAmToKICB8IGFyY2gvYXJtNjQva3ZtL3N5c19yZWdzLmM6OTgzOjMzOiB3YXJuaW5nOiDigJhw YXJhbXMuT3Ay4oCZIG1heSBiZSB1c2VkIHVuaW5pdGlhbGl6ZWQgaW4gdGhpcyBmdW5jdGlvbiBb LVdtYXliZS11bmluaXRpYWxpemVkXQogIHwgICA5ODMgfCAgICh1MzIpKHgpLT5DUm4sICh1MzIp KHgpLT5DUm0sICh1MzIpKHgpLT5PcDIpOwogIHwgWy4uLl0KClJldmVydCB0aGUgaHVuayBvZiA0 YjkyN2I5NGQ1ZGYgd2hpY2ggYnJlYWtzICdpbmRleF90b19zeXNfcmVnX2Rlc2MoKScgc28KdGhh dCB0aGUgb2xkIGJlaGF2aW91ciBvZiBjaGVja2luZyB0aGUgaW5kZXggdXBmcm9udCBpcyByZXN0 b3JlZC4KCkZpeGVzOiA0YjkyN2I5NGQ1ZGYgKCJLVk06IGFybS9hcm02NDogdmdpYzogSW50cm9k dWNlIGZpbmRfcmVnX2J5X2lkKCkiKQpTaWduZWQtb2ZmLWJ5OiBXaWxsIERlYWNvbiA8d2lsbEBr ZXJuZWwub3JnPgpTaWduZWQtb2ZmLWJ5OiBNYXJjIFp5bmdpZXIgPG1hekBrZXJuZWwub3JnPgpD YzogPHN0YWJsZUB2Z2VyLmtlcm5lbC5vcmc+Ckxpbms6IGh0dHBzOi8vbG9yZS5rZXJuZWwub3Jn L3IvMjAxOTEyMTIwOTQwNDkuMTI0MzctMS13aWxsQGtlcm5lbC5vcmcKLS0tCiBhcmNoL2FybTY0 L2t2bS9zeXNfcmVncy5jIHwgNSArKysrLQogMSBmaWxlIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygr KSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL2FyY2gvYXJtNjQva3ZtL3N5c19yZWdzLmMg Yi9hcmNoL2FybTY0L2t2bS9zeXNfcmVncy5jCmluZGV4IGJkMmFjMzc5NmQ4ZC4uZDc4YjcyNmQ0 NzIyIDEwMDY0NAotLS0gYS9hcmNoL2FybTY0L2t2bS9zeXNfcmVncy5jCisrKyBiL2FyY2gvYXJt NjQva3ZtL3N5c19yZWdzLmMKQEAgLTIzNjQsOCArMjM2NCwxMSBAQCBzdGF0aWMgY29uc3Qgc3Ry dWN0IHN5c19yZWdfZGVzYyAqaW5kZXhfdG9fc3lzX3JlZ19kZXNjKHN0cnVjdCBrdm1fdmNwdSAq dmNwdSwKIAlpZiAoKGlkICYgS1ZNX1JFR19BUk1fQ09QUk9DX01BU0spICE9IEtWTV9SRUdfQVJN NjRfU1lTUkVHKQogCQlyZXR1cm4gTlVMTDsKIAorCWlmICghaW5kZXhfdG9fcGFyYW1zKGlkLCAm cGFyYW1zKSkKKwkJcmV0dXJuIE5VTEw7CisKIAl0YWJsZSA9IGdldF90YXJnZXRfdGFibGUodmNw dS0+YXJjaC50YXJnZXQsIHRydWUsICZudW0pOwotCXIgPSBmaW5kX3JlZ19ieV9pZChpZCwgJnBh cmFtcywgdGFibGUsIG51bSk7CisJciA9IGZpbmRfcmVnKCZwYXJhbXMsIHRhYmxlLCBudW0pOwog CWlmICghcikKIAkJciA9IGZpbmRfcmVnKCZwYXJhbXMsIHN5c19yZWdfZGVzY3MsIEFSUkFZX1NJ WkUoc3lzX3JlZ19kZXNjcykpOwogCi0tIAoyLjIwLjEKCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCmt2bWFybSBtYWlsaW5nIGxpc3QKa3ZtYXJtQGxpc3Rz LmNzLmNvbHVtYmlhLmVkdQpodHRwczovL2xpc3RzLmNzLmNvbHVtYmlhLmVkdS9tYWlsbWFuL2xp c3RpbmZvL2t2bWFybQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9377C43603 for ; Thu, 12 Dec 2019 17:30:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BF9B921655 for ; Thu, 12 Dec 2019 17:30:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="HzcJBRff" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BF9B921655 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aVZtEtXwnDw1m5y18rXZUSsJMVZKmFgR/HOSxCvGh2M=; b=HzcJBRff7gwiSB CSrwWSpMg4LJOcNZ6meKy0qerCyysA2ksuDUrgnZX6DvwC6Tln2AOGW0CE+8x4y6fUXwCeKUKub/G viqH+iVhAipYQNUVnMC6xuQc99+AfCWGE3ne+lrryM4HXQ7h0RBTg9u5rD+Fgu95Bu/nbbI3N2LIX +ryXX0YmejiYb5JezJpbkfQnVCuH/omNgE4yKQyOnp/2gSM34Au5k1Xj/buHyt2c5f0EuJWbhssuz gS2oeuD1ZhIZnfzxyA3PGctWz4ZY5QyHTPA/3xHXcqmkKRkuoAmGr6xtGIBCP9UxKWApIWWOVldcn 3n6cd60BQ5I4zX04UaDw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ifSIS-0007vv-DC; Thu, 12 Dec 2019 17:30:40 +0000 Received: from inca-roads.misterjones.org ([213.251.177.50]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ifSGf-0005AL-L2 for linux-arm-kernel@lists.infradead.org; Thu, 12 Dec 2019 17:28:53 +0000 Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=why.lan) by cheepnis.misterjones.org with esmtpsa (TLSv1.2:DHE-RSA-AES128-GCM-SHA256:128) (Exim 4.80) (envelope-from ) id 1ifSGa-00069s-F9; Thu, 12 Dec 2019 18:28:44 +0100 From: Marc Zyngier To: Paolo Bonzini , =?UTF-8?q?Radim=20Kr=C4=8Dm=C3=A1=C5=99?= Subject: [PATCH 7/8] KVM: arm64: Ensure 'params' is initialised when looking up sys register Date: Thu, 12 Dec 2019 17:28:23 +0000 Message-Id: <20191212172824.11523-8-maz@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191212172824.11523-1-maz@kernel.org> References: <20191212172824.11523-1-maz@kernel.org> MIME-Version: 1.0 X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: pbonzini@redhat.com, rkrcmar@redhat.com, alexandru.elisei@arm.com, ard.biesheuvel@linaro.org, christoffer.dall@arm.com, eric.auger@redhat.com, james.morse@arm.com, justin.he@arm.com, mark.rutland@arm.com, linmiaohe@huawei.com, steven.price@arm.com, will@kernel.org, kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com, stable@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on cheepnis.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191212_092849_829438_384125E7 X-CRM114-Status: GOOD ( 10.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Miaohe Lin , Jia He , kvm@vger.kernel.org, Ard Biesheuvel , Will Deacon , Suzuki K Poulose , Christoffer Dall , stable@vger.kernel.org, Steven Price , Eric Auger , James Morse , Julien Thierry , Alexandru Elisei , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org RnJvbTogV2lsbCBEZWFjb24gPHdpbGxAa2VybmVsLm9yZz4KCkNvbW1pdCA0YjkyN2I5NGQ1ZGYg KCJLVk06IGFybS9hcm02NDogdmdpYzogSW50cm9kdWNlIGZpbmRfcmVnX2J5X2lkKCkiKQppbnRy b2R1Y2VkICdmaW5kX3JlZ19ieV9pZCgpJywgd2hpY2ggbG9va3MgdXAgYSBzeXN0ZW0gcmVnaXN0 ZXIgb25seSBpZgp0aGUgJ2lkJyBpbmRleCBwYXJhbWV0ZXIgaWRlbnRpZmllcyBhIHZhbGlkIHN5 c3RlbSByZWdpc3Rlci4gQXMgcGFydCBvZgp0aGUgcGF0Y2gsIGV4aXN0aW5nIGNhbGxlcnMgb2Yg J2ZpbmRfcmVnKCknIHdlcmUgcG9ydGVkIG92ZXIgdG8gdGhlIG5ldwppbnRlcmZhY2UsIGJ1dCB0 aGlzIGJyZWFrcyAnaW5kZXhfdG9fc3lzX3JlZ19kZXNjKCknIGluIHRoZSBjYXNlIHRoYXQgdGhl CmluaXRpYWwgbG9va3VwIGluIHRoZSB2Q1BVIHRhcmdldCB0YWJsZSBmYWlscyBiZWNhdXNlIHdl IHdpbGwgdGhlbiBjYWxsCmludG8gJ2ZpbmRfcmVnKCknIGZvciB0aGUgc3lzdGVtIHJlZ2lzdGVy IHRhYmxlIHdpdGggYW4gdW5pbml0aWFsaXNlZAoncGFyYW0nIGFzIHRoZSBrZXkgdG8gdGhlIGxv b2t1cC4KCkdDQyAxMCBpcyBicmlnaHQgZW5vdWdoIHRvIHNwb3QgdGhpcyAoYW1vbmdzdCBhIHRv bm5lIG9mIGZhbHNlIHBvc2l0aXZlcywKYnV0IGhleSEpOgoKICB8IGFyY2gvYXJtNjQva3ZtL3N5 c19yZWdzLmM6IEluIGZ1bmN0aW9uIOKAmGluZGV4X3RvX3N5c19yZWdfZGVzYy5wYXJ0LjAuaXNy YeKAmToKICB8IGFyY2gvYXJtNjQva3ZtL3N5c19yZWdzLmM6OTgzOjMzOiB3YXJuaW5nOiDigJhw YXJhbXMuT3Ay4oCZIG1heSBiZSB1c2VkIHVuaW5pdGlhbGl6ZWQgaW4gdGhpcyBmdW5jdGlvbiBb LVdtYXliZS11bmluaXRpYWxpemVkXQogIHwgICA5ODMgfCAgICh1MzIpKHgpLT5DUm4sICh1MzIp KHgpLT5DUm0sICh1MzIpKHgpLT5PcDIpOwogIHwgWy4uLl0KClJldmVydCB0aGUgaHVuayBvZiA0 YjkyN2I5NGQ1ZGYgd2hpY2ggYnJlYWtzICdpbmRleF90b19zeXNfcmVnX2Rlc2MoKScgc28KdGhh dCB0aGUgb2xkIGJlaGF2aW91ciBvZiBjaGVja2luZyB0aGUgaW5kZXggdXBmcm9udCBpcyByZXN0 b3JlZC4KCkZpeGVzOiA0YjkyN2I5NGQ1ZGYgKCJLVk06IGFybS9hcm02NDogdmdpYzogSW50cm9k dWNlIGZpbmRfcmVnX2J5X2lkKCkiKQpTaWduZWQtb2ZmLWJ5OiBXaWxsIERlYWNvbiA8d2lsbEBr ZXJuZWwub3JnPgpTaWduZWQtb2ZmLWJ5OiBNYXJjIFp5bmdpZXIgPG1hekBrZXJuZWwub3JnPgpD YzogPHN0YWJsZUB2Z2VyLmtlcm5lbC5vcmc+Ckxpbms6IGh0dHBzOi8vbG9yZS5rZXJuZWwub3Jn L3IvMjAxOTEyMTIwOTQwNDkuMTI0MzctMS13aWxsQGtlcm5lbC5vcmcKLS0tCiBhcmNoL2FybTY0 L2t2bS9zeXNfcmVncy5jIHwgNSArKysrLQogMSBmaWxlIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygr KSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL2FyY2gvYXJtNjQva3ZtL3N5c19yZWdzLmMg Yi9hcmNoL2FybTY0L2t2bS9zeXNfcmVncy5jCmluZGV4IGJkMmFjMzc5NmQ4ZC4uZDc4YjcyNmQ0 NzIyIDEwMDY0NAotLS0gYS9hcmNoL2FybTY0L2t2bS9zeXNfcmVncy5jCisrKyBiL2FyY2gvYXJt NjQva3ZtL3N5c19yZWdzLmMKQEAgLTIzNjQsOCArMjM2NCwxMSBAQCBzdGF0aWMgY29uc3Qgc3Ry dWN0IHN5c19yZWdfZGVzYyAqaW5kZXhfdG9fc3lzX3JlZ19kZXNjKHN0cnVjdCBrdm1fdmNwdSAq dmNwdSwKIAlpZiAoKGlkICYgS1ZNX1JFR19BUk1fQ09QUk9DX01BU0spICE9IEtWTV9SRUdfQVJN NjRfU1lTUkVHKQogCQlyZXR1cm4gTlVMTDsKIAorCWlmICghaW5kZXhfdG9fcGFyYW1zKGlkLCAm cGFyYW1zKSkKKwkJcmV0dXJuIE5VTEw7CisKIAl0YWJsZSA9IGdldF90YXJnZXRfdGFibGUodmNw dS0+YXJjaC50YXJnZXQsIHRydWUsICZudW0pOwotCXIgPSBmaW5kX3JlZ19ieV9pZChpZCwgJnBh cmFtcywgdGFibGUsIG51bSk7CisJciA9IGZpbmRfcmVnKCZwYXJhbXMsIHRhYmxlLCBudW0pOwog CWlmICghcikKIAkJciA9IGZpbmRfcmVnKCZwYXJhbXMsIHN5c19yZWdfZGVzY3MsIEFSUkFZX1NJ WkUoc3lzX3JlZ19kZXNjcykpOwogCi0tIAoyLjIwLjEKCgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdAps aW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVh ZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AC0AC00454 for ; Thu, 12 Dec 2019 17:28:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2574121655 for ; Thu, 12 Dec 2019 17:28:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576171733; bh=7j0AJrofIDs+cg17AsQVqj5tBtG2W5BnRJ3zlV8KqNU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=L6dBcqs1OiDhHqXhO1ntPwmNTb7tEs5wGTxBJuj0LqPoqnsK3a+4U655zoEqKkAhM weINcRime3bACSLnJF+CQLNiz3fncJ0wNqZ6NqxHSicsgGwK4YZROI0XAaxa8W2Tmx 5HBPXsa8zEuleO5aFWzG2dADqnD6R9iLqGPMAvis= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730173AbfLLR2w (ORCPT ); Thu, 12 Dec 2019 12:28:52 -0500 Received: from inca-roads.misterjones.org ([213.251.177.50]:47958 "EHLO inca-roads.misterjones.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730168AbfLLR2v (ORCPT ); Thu, 12 Dec 2019 12:28:51 -0500 Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=why.lan) by cheepnis.misterjones.org with esmtpsa (TLSv1.2:DHE-RSA-AES128-GCM-SHA256:128) (Exim 4.80) (envelope-from ) id 1ifSGa-00069s-F9; Thu, 12 Dec 2019 18:28:44 +0100 From: Marc Zyngier To: Paolo Bonzini , =?UTF-8?q?Radim=20Kr=C4=8Dm=C3=A1=C5=99?= Cc: Alexandru Elisei , Ard Biesheuvel , Christoffer Dall , Eric Auger , James Morse , Jia He , Mark Rutland , Miaohe Lin , Steven Price , Will Deacon , kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, Julien Thierry , Suzuki K Poulose , stable@vger.kernel.org Subject: [PATCH 7/8] KVM: arm64: Ensure 'params' is initialised when looking up sys register Date: Thu, 12 Dec 2019 17:28:23 +0000 Message-Id: <20191212172824.11523-8-maz@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191212172824.11523-1-maz@kernel.org> References: <20191212172824.11523-1-maz@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: pbonzini@redhat.com, rkrcmar@redhat.com, alexandru.elisei@arm.com, ard.biesheuvel@linaro.org, christoffer.dall@arm.com, eric.auger@redhat.com, james.morse@arm.com, justin.he@arm.com, mark.rutland@arm.com, linmiaohe@huawei.com, steven.price@arm.com, will@kernel.org, kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com, stable@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on cheepnis.misterjones.org); SAEximRunCond expanded to false Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org From: Will Deacon Commit 4b927b94d5df ("KVM: arm/arm64: vgic: Introduce find_reg_by_id()") introduced 'find_reg_by_id()', which looks up a system register only if the 'id' index parameter identifies a valid system register. As part of the patch, existing callers of 'find_reg()' were ported over to the new interface, but this breaks 'index_to_sys_reg_desc()' in the case that the initial lookup in the vCPU target table fails because we will then call into 'find_reg()' for the system register table with an uninitialised 'param' as the key to the lookup. GCC 10 is bright enough to spot this (amongst a tonne of false positives, but hey!): | arch/arm64/kvm/sys_regs.c: In function ‘index_to_sys_reg_desc.part.0.isra’: | arch/arm64/kvm/sys_regs.c:983:33: warning: ‘params.Op2’ may be used uninitialized in this function [-Wmaybe-uninitialized] | 983 | (u32)(x)->CRn, (u32)(x)->CRm, (u32)(x)->Op2); | [...] Revert the hunk of 4b927b94d5df which breaks 'index_to_sys_reg_desc()' so that the old behaviour of checking the index upfront is restored. Fixes: 4b927b94d5df ("KVM: arm/arm64: vgic: Introduce find_reg_by_id()") Signed-off-by: Will Deacon Signed-off-by: Marc Zyngier Cc: Link: https://lore.kernel.org/r/20191212094049.12437-1-will@kernel.org --- arch/arm64/kvm/sys_regs.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/arch/arm64/kvm/sys_regs.c b/arch/arm64/kvm/sys_regs.c index bd2ac3796d8d..d78b726d4722 100644 --- a/arch/arm64/kvm/sys_regs.c +++ b/arch/arm64/kvm/sys_regs.c @@ -2364,8 +2364,11 @@ static const struct sys_reg_desc *index_to_sys_reg_desc(struct kvm_vcpu *vcpu, if ((id & KVM_REG_ARM_COPROC_MASK) != KVM_REG_ARM64_SYSREG) return NULL; + if (!index_to_params(id, ¶ms)) + return NULL; + table = get_target_table(vcpu->arch.target, true, &num); - r = find_reg_by_id(id, ¶ms, table, num); + r = find_reg(¶ms, table, num); if (!r) r = find_reg(¶ms, sys_reg_descs, ARRAY_SIZE(sys_reg_descs)); -- 2.20.1