All of lore.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@zeniv.linux.org.uk>
To: Dominik Brodowski <linux@dominikbrodowski.net>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Ingo Molnar <mingo@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] fs: remove ksys_dup()
Date: Thu, 12 Dec 2019 18:38:48 +0000	[thread overview]
Message-ID: <20191212183848.GJ4203@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20191212140752.347520-3-linux@dominikbrodowski.net>

On Thu, Dec 12, 2019 at 03:07:52PM +0100, Dominik Brodowski wrote:
> ksys_dup() is used only at one place in the kernel, namely to duplicate
> fd 0 of /dev/console to stdout and stderr. The same functionality can be
> achieved by using functions already available within the kernel namespace.

Let's not expose the kernel guts to init/*.c more than absolutely unavoidable.

  parent reply	other threads:[~2019-12-12 18:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-12 14:07 [PATCH 0/2] remove ksys_dup() Dominik Brodowski
2019-12-12 14:07 ` [PATCH 1/2] init: unify opening /dev/console as stdin/stdout/stderr Dominik Brodowski
2019-12-12 14:07 ` [PATCH 2/2] fs: remove ksys_dup() Dominik Brodowski
2019-12-12 17:09   ` Linus Torvalds
2019-12-12 18:38   ` Al Viro [this message]
2019-12-12 18:48     ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191212183848.GJ4203@ZenIV.linux.org.uk \
    --to=viro@zeniv.linux.org.uk \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@dominikbrodowski.net \
    --cc=mingo@kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.