From: Bin Liu <b-liu@ti.com>
To: "Ben Dooks (Codethink)" <ben.dooks@codethink.co.uk>
Cc: <linux-kernel@lists.codethink.co.uk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
<linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] USB: musb: fix __iomem in trace functions
Date: Thu, 12 Dec 2019 14:43:26 -0600 [thread overview]
Message-ID: <20191212204326.GK16429@iaqt7> (raw)
In-Reply-To: <20191015150309.17364-1-ben.dooks@codethink.co.uk>
Hi,
On Tue, Oct 15, 2019 at 04:03:09PM +0100, Ben Dooks (Codethink) wrote:
> The trace functions should have __iomem on the addr
> pointers. Add __iomem to avoid the following warnings
> from sparse:
>
> drivers/usb/musb/musb_core.c:253:55: warning: incorrect type in argument 2 (different address spaces)
> drivers/usb/musb/musb_core.c:253:55: expected void const *addr
> drivers/usb/musb/musb_core.c:253:55: got void const [noderef] <asn:2> *addr
> drivers/usb/musb/musb_core.c:259:56: warning: incorrect type in argument 2 (different address spaces)
> drivers/usb/musb/musb_core.c:259:56: expected void const *addr
> drivers/usb/musb/musb_core.c:259:56: got void [noderef] <asn:2> *addr
> drivers/usb/musb/musb_core.c:267:55: warning: incorrect type in argument 2 (different address spaces)
> drivers/usb/musb/musb_core.c:267:55: expected void const *addr
> drivers/usb/musb/musb_core.c:267:55: got void const [noderef] <asn:2> *addr
> drivers/usb/musb/musb_core.c:273:56: warning: incorrect type in argument 2 (different address spaces)
> drivers/usb/musb/musb_core.c:273:56: expected void const *addr
> drivers/usb/musb/musb_core.c:273:56: got void [noderef] <asn:2> *addr
> drivers/usb/musb/musb_core.c:383:55: warning: incorrect type in argument 2 (different address spaces)
> drivers/usb/musb/musb_core.c:383:55: expected void const *addr
> drivers/usb/musb/musb_core.c:383:55: got void const [noderef] <asn:2> *addr
> drivers/usb/musb/musb_core.c:390:56: warning: incorrect type in argument 2 (different address spaces)
> drivers/usb/musb/musb_core.c:390:56: expected void const *addr
> drivers/usb/musb/musb_core.c:390:56: got void [noderef] <asn:2> *addr
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
Thanks for the patch. But checkpatch.pl complains that the author and
Signed-off-by do not match. Can you please fix it and re-send?
-Bin.
next prev parent reply other threads:[~2019-12-12 20:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-15 15:03 [PATCH] USB: musb: fix __iomem in trace functions Ben Dooks (Codethink)
2019-12-12 20:43 ` Bin Liu [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-12-16 17:48 Ben Dooks (Codethink)
2019-12-17 17:53 ` Bin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191212204326.GK16429@iaqt7 \
--to=b-liu@ti.com \
--cc=ben.dooks@codethink.co.uk \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@lists.codethink.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.